[INFO] updating cached repository remexre/resolution [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/remexre/resolution [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/remexre/resolution" "work/ex/clippy-test-run/sources/stable/gh/remexre/resolution"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/remexre/resolution'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/remexre/resolution" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remexre/resolution"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remexre/resolution'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6e29fcfa965f667d4433cef9c5f3b78853307c88 [INFO] sha for GitHub repo remexre/resolution: 6e29fcfa965f667d4433cef9c5f3b78853307c88 [INFO] validating manifest of remexre/resolution on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of remexre/resolution on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing remexre/resolution [INFO] finished frobbing remexre/resolution [INFO] frobbed toml for remexre/resolution written to work/ex/clippy-test-run/sources/stable/gh/remexre/resolution/Cargo.toml [INFO] started frobbing remexre/resolution [INFO] finished frobbing remexre/resolution [INFO] frobbed toml for remexre/resolution written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remexre/resolution/Cargo.toml [INFO] crate remexre/resolution has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting remexre/resolution against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/remexre/resolution:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2999cbdbf9134f7dc80081aead57768472a912e3f43d2701279fbda70229ef8f [INFO] running `"docker" "start" "-a" "2999cbdbf9134f7dc80081aead57768472a912e3f43d2701279fbda70229ef8f"` [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking stderrlog v0.4.1 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking resolution v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output/ascii.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | write!(self.0, " [{}]\n", right)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output/ascii.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | write!(self.0, " [{}]\n", right)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output/latex.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | fn render_term(&mut self, term: &Term) -> Fallible<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/term.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn display_unicode<'a>(&'a self) -> impl 'a + Display { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output/latex.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | fn render_term(&mut self, term: &Term) -> Fallible<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/term.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn display_unicode<'a>(&'a self) -> impl 'a + Display { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.96s [INFO] running `"docker" "inspect" "2999cbdbf9134f7dc80081aead57768472a912e3f43d2701279fbda70229ef8f"` [INFO] running `"docker" "rm" "-f" "2999cbdbf9134f7dc80081aead57768472a912e3f43d2701279fbda70229ef8f"` [INFO] [stdout] 2999cbdbf9134f7dc80081aead57768472a912e3f43d2701279fbda70229ef8f