[INFO] updating cached repository remexre/datalog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/remexre/datalog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/remexre/datalog" "work/ex/clippy-test-run/sources/stable/gh/remexre/datalog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/remexre/datalog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/remexre/datalog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remexre/datalog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remexre/datalog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 58da741a50543d581c6f29a5a56dac7b90dec907 [INFO] sha for GitHub repo remexre/datalog: 58da741a50543d581c6f29a5a56dac7b90dec907 [INFO] validating manifest of remexre/datalog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of remexre/datalog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing remexre/datalog [INFO] finished frobbing remexre/datalog [INFO] frobbed toml for remexre/datalog written to work/ex/clippy-test-run/sources/stable/gh/remexre/datalog/Cargo.toml [INFO] started frobbing remexre/datalog [INFO] finished frobbing remexre/datalog [INFO] frobbed toml for remexre/datalog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/remexre/datalog/Cargo.toml [INFO] crate remexre/datalog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting remexre/datalog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/remexre/datalog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38d2fb72c576f63e6f5971a87e60d14db2f703cdbde7c91c57a24016ae6c7933 [INFO] running `"docker" "start" "-a" "38d2fb72c576f63e6f5971a87e60d14db2f703cdbde7c91c57a24016ae6c7933"` [INFO] [stderr] Checking spin v0.4.6 [INFO] [stderr] Compiling pest v1.0.2 [INFO] [stderr] Checking try_opt v0.1.1 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking proptest v0.4.2 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking symbol v0.1.1 [INFO] [stderr] Compiling pest_derive v1.0.2 [INFO] [stderr] Checking liner v0.4.4 [INFO] [stderr] Checking sparkly v0.1.4 [INFO] [stderr] Checking datalog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/mod.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | const _GRAMMAR: &'static str = include_str!("datalog.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lv` [INFO] [stderr] --> src/ast/pattern_match.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | (Term::Var(lv), Term::Var(rv)) => {} [INFO] [stderr] | ^^ help: consider using `_lv` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rv` [INFO] [stderr] --> src/ast/pattern_match.rs:32:39 [INFO] [stderr] | [INFO] [stderr] 32 | (Term::Var(lv), Term::Var(rv)) => {} [INFO] [stderr] | ^^ help: consider using `_rv` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/ast/eq.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn alpha_eq(&self, other: &Clause) -> bool { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/ast/mod.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | let Clause(head, body) = self.clone(); [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/ast/mod.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | let Literal(name, mut hargs) = head; [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clause` [INFO] [stderr] --> src/naive/mod.rs:103:34 [INFO] [stderr] | [INFO] [stderr] 103 | fn run_retraction(&mut self, clause: Clause) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_clause` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `entry_fn` [INFO] [stderr] --> src/util.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn entry_fn(map: &mut HashMap, key: K, f: F) [INFO] [stderr] 8 | | where [INFO] [stderr] 9 | | F: FnOnce(&K, Option) -> Option, [INFO] [stderr] 10 | | K: Eq + Hash, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/print.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if body.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/mod.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | if body.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `naive::NaiveInterpreter` [INFO] [stderr] --> src/naive/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> NaiveInterpreter { [INFO] [stderr] 18 | | NaiveInterpreter { [INFO] [stderr] 19 | | facts: HashMap::new(), [INFO] [stderr] 20 | | rules: HashMap::new(), [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn convert_program<'a>( [INFO] [stderr] 11 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 12 | | ) -> Result> { [INFO] [stderr] 13 | | as_one(pairs, Rule::program, |pairs| { [INFO] [stderr] ... | [INFO] [stderr] 19 | | }) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn convert_statement<'a>( [INFO] [stderr] 23 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 24 | | ) -> Result> { [INFO] [stderr] 25 | | as_one(pairs, Rule::stmt, convert_statement_one) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn convert_statement_one<'a>( [INFO] [stderr] 29 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 30 | | ) -> Result> { [INFO] [stderr] 31 | | as_one_any(pairs, Rule::stmt, |token| match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn convert_clause<'a>( [INFO] [stderr] 50 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 51 | | ) -> Result> { [INFO] [stderr] 52 | | as_one(pairs, Rule::clause, |pairs| { [INFO] [stderr] ... | [INFO] [stderr] 64 | | }) [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn convert_literal<'a>( [INFO] [stderr] 68 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 69 | | ) -> Result> { [INFO] [stderr] 70 | | as_one(pairs, Rule::literal, convert_literal_one) [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:73:1 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn convert_literal_one<'a>( [INFO] [stderr] 74 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 75 | | ) -> Result> { [INFO] [stderr] 76 | | as_amb(pairs, Rule::name, Rule::term_list, |pred, args| { [INFO] [stderr] ... | [INFO] [stderr] 84 | | }) [INFO] [stderr] 85 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn convert_term_one<'a>( [INFO] [stderr] 95 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 96 | | ) -> Result> { [INFO] [stderr] 97 | | as_one_any(pairs, Rule::term, |token| match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 105 | | }) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn convert_name_one<'a>( [INFO] [stderr] 116 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 117 | | ) -> Result> { [INFO] [stderr] 118 | | as_one_any(pairs, Rule::name, |token| { [INFO] [stderr] ... | [INFO] [stderr] 144 | | }) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn convert_char<'a>( [INFO] [stderr] 148 | | token: Pair<'a, Rule>, [INFO] [stderr] 149 | | ) -> Result> { [INFO] [stderr] 150 | | match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:171:1 [INFO] [stderr] | [INFO] [stderr] 171 | / pub fn convert_escape<'a>( [INFO] [stderr] 172 | | token: Pair<'a, Rule>, [INFO] [stderr] 173 | | ) -> Result> { [INFO] [stderr] 174 | | match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:231:1 [INFO] [stderr] | [INFO] [stderr] 231 | / pub fn convert_variable_one<'a>(token: Pair<'a, Rule>) -> Variable { [INFO] [stderr] 232 | | Variable::new(token.as_str()).unwrap() [INFO] [stderr] 233 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | / match err.kind() { [INFO] [stderr] 99 | | &ErrorKind::Io(ref err) => match err.kind() { [INFO] [stderr] 100 | | IoErrorKind::UnexpectedEof => break Ok(()), [INFO] [stderr] 101 | | IoErrorKind::Interrupted => continue, [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | if let &ErrorKind::Io(ref err) = err.kind() { match err.kind() { [INFO] [stderr] 99 | IoErrorKind::UnexpectedEof => break Ok(()), [INFO] [stderr] 100 | IoErrorKind::Interrupted => continue, [INFO] [stderr] 101 | _ => {} [INFO] [stderr] 102 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | / match err.kind() { [INFO] [stderr] 99 | | &ErrorKind::Io(ref err) => match err.kind() { [INFO] [stderr] 100 | | IoErrorKind::UnexpectedEof => break Ok(()), [INFO] [stderr] 101 | | IoErrorKind::Interrupted => continue, [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *err.kind() { [INFO] [stderr] 99 | ErrorKind::Io(ref err) => match err.kind() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | / match err.kind() { [INFO] [stderr] 99 | | &ErrorKind::Io(ref err) => match err.kind() { [INFO] [stderr] 100 | | IoErrorKind::UnexpectedEof => break Ok(()), [INFO] [stderr] 101 | | IoErrorKind::Interrupted => continue, [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | if let &ErrorKind::Io(ref err) = err.kind() { match err.kind() { [INFO] [stderr] 99 | IoErrorKind::UnexpectedEof => break Ok(()), [INFO] [stderr] 100 | IoErrorKind::Interrupted => continue, [INFO] [stderr] 101 | _ => {} [INFO] [stderr] 102 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | / match err.kind() { [INFO] [stderr] 99 | | &ErrorKind::Io(ref err) => match err.kind() { [INFO] [stderr] 100 | | IoErrorKind::UnexpectedEof => break Ok(()), [INFO] [stderr] 101 | | IoErrorKind::Interrupted => continue, [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *err.kind() { [INFO] [stderr] 99 | ErrorKind::Io(ref err) => match err.kind() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/mod.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | const _GRAMMAR: &'static str = include_str!("datalog.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lv` [INFO] [stderr] --> src/ast/pattern_match.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | (Term::Var(lv), Term::Var(rv)) => {} [INFO] [stderr] | ^^ help: consider using `_lv` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rv` [INFO] [stderr] --> src/ast/pattern_match.rs:32:39 [INFO] [stderr] | [INFO] [stderr] 32 | (Term::Var(lv), Term::Var(rv)) => {} [INFO] [stderr] | ^^ help: consider using `_rv` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/ast/eq.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn alpha_eq(&self, other: &Clause) -> bool { [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body` [INFO] [stderr] --> src/ast/mod.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | let Clause(head, body) = self.clone(); [INFO] [stderr] | ^^^^ help: consider using `_body` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/ast/mod.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | let Literal(name, mut hargs) = head; [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clause` [INFO] [stderr] --> src/naive/mod.rs:103:34 [INFO] [stderr] | [INFO] [stderr] 103 | fn run_retraction(&mut self, clause: Clause) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_clause` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `entry_fn` [INFO] [stderr] --> src/util.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn entry_fn(map: &mut HashMap, key: K, f: F) [INFO] [stderr] 8 | | where [INFO] [stderr] 9 | | F: FnOnce(&K, Option) -> Option, [INFO] [stderr] 10 | | K: Eq + Hash, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/print.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if body.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ast/mod.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | if body.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `naive::NaiveInterpreter` [INFO] [stderr] --> src/naive/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> NaiveInterpreter { [INFO] [stderr] 18 | | NaiveInterpreter { [INFO] [stderr] 19 | | facts: HashMap::new(), [INFO] [stderr] 20 | | rules: HashMap::new(), [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn convert_program<'a>( [INFO] [stderr] 11 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 12 | | ) -> Result> { [INFO] [stderr] 13 | | as_one(pairs, Rule::program, |pairs| { [INFO] [stderr] ... | [INFO] [stderr] 19 | | }) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn convert_statement<'a>( [INFO] [stderr] 23 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 24 | | ) -> Result> { [INFO] [stderr] 25 | | as_one(pairs, Rule::stmt, convert_statement_one) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn convert_statement_one<'a>( [INFO] [stderr] 29 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 30 | | ) -> Result> { [INFO] [stderr] 31 | | as_one_any(pairs, Rule::stmt, |token| match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn convert_clause<'a>( [INFO] [stderr] 50 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 51 | | ) -> Result> { [INFO] [stderr] 52 | | as_one(pairs, Rule::clause, |pairs| { [INFO] [stderr] ... | [INFO] [stderr] 64 | | }) [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn convert_literal<'a>( [INFO] [stderr] 68 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 69 | | ) -> Result> { [INFO] [stderr] 70 | | as_one(pairs, Rule::literal, convert_literal_one) [INFO] [stderr] 71 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:73:1 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn convert_literal_one<'a>( [INFO] [stderr] 74 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 75 | | ) -> Result> { [INFO] [stderr] 76 | | as_amb(pairs, Rule::name, Rule::term_list, |pred, args| { [INFO] [stderr] ... | [INFO] [stderr] 84 | | }) [INFO] [stderr] 85 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn convert_term<'a>( [INFO] [stderr] 89 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 90 | | ) -> Result> { [INFO] [stderr] 91 | | as_one(pairs, Rule::term, convert_term_one) [INFO] [stderr] 92 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn convert_term_one<'a>( [INFO] [stderr] 95 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 96 | | ) -> Result> { [INFO] [stderr] 97 | | as_one_any(pairs, Rule::term, |token| match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 105 | | }) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:109:1 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn convert_name<'a>( [INFO] [stderr] 110 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 111 | | ) -> Result> { [INFO] [stderr] 112 | | as_one(pairs, Rule::name, convert_name_one) [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn convert_name_one<'a>( [INFO] [stderr] 116 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 117 | | ) -> Result> { [INFO] [stderr] 118 | | as_one_any(pairs, Rule::name, |token| { [INFO] [stderr] ... | [INFO] [stderr] 144 | | }) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn convert_char<'a>( [INFO] [stderr] 148 | | token: Pair<'a, Rule>, [INFO] [stderr] 149 | | ) -> Result> { [INFO] [stderr] 150 | | match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:171:1 [INFO] [stderr] | [INFO] [stderr] 171 | / pub fn convert_escape<'a>( [INFO] [stderr] 172 | | token: Pair<'a, Rule>, [INFO] [stderr] 173 | | ) -> Result> { [INFO] [stderr] 174 | | match token.as_rule() { [INFO] [stderr] ... | [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:223:1 [INFO] [stderr] | [INFO] [stderr] 223 | / pub fn convert_variable<'a>( [INFO] [stderr] 224 | | pairs: Pairs<'a, Rule>, [INFO] [stderr] 225 | | ) -> Result> { [INFO] [stderr] 226 | | as_one_any(pairs, Rule::variable, |token| { [INFO] [stderr] 227 | | Ok(convert_variable_one(token)) [INFO] [stderr] 228 | | }) [INFO] [stderr] 229 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser/convert.rs:231:1 [INFO] [stderr] | [INFO] [stderr] 231 | / pub fn convert_variable_one<'a>(token: Pair<'a, Rule>) -> Variable { [INFO] [stderr] 232 | | Variable::new(token.as_str()).unwrap() [INFO] [stderr] 233 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 80 [INFO] [stderr] --> src/parser/cst_tests.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn strings() { [INFO] [stderr] 37 | | parses_to! { [INFO] [stderr] 38 | | parser: DatalogParser, [INFO] [stderr] 39 | | input: r#""""#, [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 170 [INFO] [stderr] --> src/parser/cst_tests.rs:83:1 [INFO] [stderr] | [INFO] [stderr] 83 | / fn literals() { [INFO] [stderr] 84 | | parses_to! { [INFO] [stderr] 85 | | parser: DatalogParser, [INFO] [stderr] 86 | | input: "zero-arity-literal", [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.88s [INFO] running `"docker" "inspect" "38d2fb72c576f63e6f5971a87e60d14db2f703cdbde7c91c57a24016ae6c7933"` [INFO] running `"docker" "rm" "-f" "38d2fb72c576f63e6f5971a87e60d14db2f703cdbde7c91c57a24016ae6c7933"` [INFO] [stdout] 38d2fb72c576f63e6f5971a87e60d14db2f703cdbde7c91c57a24016ae6c7933