[INFO] updating cached repository reilleya/rustBoy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/reilleya/rustBoy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/reilleya/rustBoy" "work/ex/clippy-test-run/sources/stable/gh/reilleya/rustBoy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/reilleya/rustBoy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/reilleya/rustBoy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reilleya/rustBoy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reilleya/rustBoy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1e59436bf938c96e2dd54f66843e949c62b788e2 [INFO] sha for GitHub repo reilleya/rustBoy: 1e59436bf938c96e2dd54f66843e949c62b788e2 [INFO] validating manifest of reilleya/rustBoy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reilleya/rustBoy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reilleya/rustBoy [INFO] finished frobbing reilleya/rustBoy [INFO] frobbed toml for reilleya/rustBoy written to work/ex/clippy-test-run/sources/stable/gh/reilleya/rustBoy/Cargo.toml [INFO] started frobbing reilleya/rustBoy [INFO] finished frobbing reilleya/rustBoy [INFO] frobbed toml for reilleya/rustBoy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reilleya/rustBoy/Cargo.toml [INFO] crate reilleya/rustBoy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reilleya/rustBoy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/reilleya/rustBoy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8447cb325ff25389ef5c2082d6ea874542e5ad37c1d97d995c949d01a91194c7 [INFO] running `"docker" "start" "-a" "8447cb325ff25389ef5c2082d6ea874542e5ad37c1d97d995c949d01a91194c7"` [INFO] [stderr] Checking rustBoy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/core/mod.rs:1014:3 [INFO] [stderr] | [INFO] [stderr] 1014 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/core/mod.rs:1014:3 [INFO] [stderr] | [INFO] [stderr] 1014 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | (self.f & 0b10000000) == 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | (self.f & 0b10000000) == 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | self.f = (self.f & 0b01111111) | ((z as u8) << 7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | (self.f & 0b01000000) == 0b01000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | (self.f & 0b01000000) == 0b01000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:99:22 [INFO] [stderr] | [INFO] [stderr] 99 | self.f = (self.f & 0b10111111) | ((n as u8) << 6); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | (self.f & 0b00100000) == 0b00100000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | (self.f & 0b00100000) == 0b00100000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | self.f = (self.f & 0b11011111) | ((h as u8) << 5); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | (self.f & 0b00010000) == 0b00010000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:111:28 [INFO] [stderr] | [INFO] [stderr] 111 | (self.f & 0b00010000) == 0b00010000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | self.f = (self.f & 0b11101111) | ((c as u8) << 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::Core` [INFO] [stderr] --> src/core/memory.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::Core; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/memory.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | return Memory{ [INFO] [stderr] | _________^ [INFO] [stderr] 17 | | rom: ROM::create_rom(), [INFO] [stderr] 18 | | ram: [0; 0x207F], [INFO] [stderr] 19 | | disp: Display::create(), [INFO] [stderr] 20 | | timer: Timer::create() [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Memory{ [INFO] [stderr] 17 | rom: ROM::create_rom(), [INFO] [stderr] 18 | ram: [0; 0x207F], [INFO] [stderr] 19 | disp: Display::create(), [INFO] [stderr] 20 | timer: Timer::create() [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core/mod.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | ((a & 0xFFF) + (b & 0xFFF) & 0x1000) == 0x1000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((a & 0xFFF) + (b & 0xFFF)) & 0x1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core/mod.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | (((a & 0x0FFF) + 0x1000) - (b & 0x0FFF) & 0x1000) == 0x1000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(((a & 0x0FFF) + 0x1000) - (b & 0x0FFF)) & 0x1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | (self.f & 0b10000000) == 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | (self.f & 0b10000000) == 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | self.f = (self.f & 0b01111111) | ((z as u8) << 7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | (self.f & 0b01000000) == 0b01000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | (self.f & 0b01000000) == 0b01000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:99:22 [INFO] [stderr] | [INFO] [stderr] 99 | self.f = (self.f & 0b10111111) | ((n as u8) << 6); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | (self.f & 0b00100000) == 0b00100000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | (self.f & 0b00100000) == 0b00100000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | self.f = (self.f & 0b11011111) | ((h as u8) << 5); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | (self.f & 0b00010000) == 0b00010000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:111:28 [INFO] [stderr] | [INFO] [stderr] 111 | (self.f & 0b00010000) == 0b00010000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/registers.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | self.f = (self.f & 0b11101111) | ((c as u8) << 4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::Core` [INFO] [stderr] --> src/core/memory.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::Core; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/memory.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | return Memory{ [INFO] [stderr] | _________^ [INFO] [stderr] 17 | | rom: ROM::create_rom(), [INFO] [stderr] 18 | | ram: [0; 0x207F], [INFO] [stderr] 19 | | disp: Display::create(), [INFO] [stderr] 20 | | timer: Timer::create() [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Memory{ [INFO] [stderr] 17 | rom: ROM::create_rom(), [INFO] [stderr] 18 | ram: [0; 0x207F], [INFO] [stderr] 19 | disp: Display::create(), [INFO] [stderr] 20 | timer: Timer::create() [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core/mod.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | ((a & 0xFFF) + (b & 0xFFF) & 0x1000) == 0x1000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((a & 0xFFF) + (b & 0xFFF)) & 0x1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core/mod.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | (((a & 0x0FFF) + 0x1000) - (b & 0x0FFF) & 0x1000) == 0x1000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(((a & 0x0FFF) + 0x1000) - (b & 0x0FFF)) & 0x1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1389:35 [INFO] [stderr] | [INFO] [stderr] 1389 | assert_eq!(check_sub_half_carry(0b00000000, 0x00000000), false); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1389:47 [INFO] [stderr] | [INFO] [stderr] 1389 | assert_eq!(check_sub_half_carry(0b00000000, 0x00000000), false); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1390:35 [INFO] [stderr] | [INFO] [stderr] 1390 | assert_eq!(check_sub_half_carry(0b10100110, 0x00000000), false); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1390:47 [INFO] [stderr] | [INFO] [stderr] 1390 | assert_eq!(check_sub_half_carry(0b10100110, 0x00000000), false); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1391:35 [INFO] [stderr] | [INFO] [stderr] 1391 | assert_eq!(check_sub_half_carry(0b10101100, 0b00000001), false); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1391:47 [INFO] [stderr] | [INFO] [stderr] 1391 | assert_eq!(check_sub_half_carry(0b10101100, 0b00000001), false); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1392:35 [INFO] [stderr] | [INFO] [stderr] 1392 | assert_eq!(check_sub_half_carry(0b10000000, 0b00000001), true); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1392:47 [INFO] [stderr] | [INFO] [stderr] 1392 | assert_eq!(check_sub_half_carry(0b10000000, 0b00000001), true); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1393:35 [INFO] [stderr] | [INFO] [stderr] 1393 | assert_eq!(check_sub_half_carry(0b10010000, 0b00000001), true); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/mod.rs:1393:47 [INFO] [stderr] | [INFO] [stderr] 1393 | assert_eq!(check_sub_half_carry(0b10010000, 0b00000001), true); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/core/memory.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | 0 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loc` [INFO] [stderr] --> src/core/display.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn set_mem(&mut self, loc:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider using `_loc` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/core/display.rs:36:37 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn set_mem(&mut self, loc:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op_Carry` [INFO] [stderr] --> src/core/mod.rs:802:19 [INFO] [stderr] | [INFO] [stderr] 802 | let (operand, op_Carry) = self.get_8_pc(1).overflowing_add(self.reg.get_c() as u8); [INFO] [stderr] | ^^^^^^^^ help: consider using `_op_Carry` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `f` [INFO] [stderr] --> src/core/registers.rs:3:2 [INFO] [stderr] | [INFO] [stderr] 3 | f, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_sub_half_carry_16` [INFO] [stderr] --> src/core/mod.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | fn check_sub_half_carry_16(a:u16, b:u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dec_a` [INFO] [stderr] --> src/core/mod.rs:1196:2 [INFO] [stderr] | [INFO] [stderr] 1196 | fn dec_a(&mut self) -> (u16, u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `rustBoy` should have a snake case name such as `rust_boy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `a` should have a camel case name such as `A` [INFO] [stderr] --> src/core/registers.rs:2:2 [INFO] [stderr] | [INFO] [stderr] 2 | a, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `f` should have a camel case name such as `F` [INFO] [stderr] --> src/core/registers.rs:3:2 [INFO] [stderr] | [INFO] [stderr] 3 | f, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `b` should have a camel case name such as `B` [INFO] [stderr] --> src/core/registers.rs:4:2 [INFO] [stderr] | [INFO] [stderr] 4 | b, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `c` should have a camel case name such as `C` [INFO] [stderr] --> src/core/registers.rs:5:2 [INFO] [stderr] | [INFO] [stderr] 5 | c, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `d` should have a camel case name such as `D` [INFO] [stderr] --> src/core/registers.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | d, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `e` should have a camel case name such as `E` [INFO] [stderr] --> src/core/registers.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | e, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `h` should have a camel case name such as `H` [INFO] [stderr] --> src/core/registers.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | h, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `l` should have a camel case name such as `L` [INFO] [stderr] --> src/core/registers.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | l [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:46:4 [INFO] [stderr] | [INFO] [stderr] 46 | ((self.a as u16) << 8) | (self.f as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | ((self.a as u16) << 8) | (self.f as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | ((self.b as u16) << 8) | (self.c as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:55:28 [INFO] [stderr] | [INFO] [stderr] 55 | ((self.b as u16) << 8) | (self.c as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.d as u16) << 8) | (self.e as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.d as u16) << 8) | (self.e as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | ((self.h as u16) << 8) | (self.l as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | ((self.h as u16) << 8) | (self.l as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/core/rom.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => panic!("Can't read {}", filename) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/rom.rs:22:6 [INFO] [stderr] | [INFO] [stderr] 22 | fo.read(&mut self.data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | self.reg.pc += raw as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(raw)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:195:19 [INFO] [stderr] | [INFO] [stderr] 195 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:233:19 [INFO] [stderr] | [INFO] [stderr] 233 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:289:5 [INFO] [stderr] | [INFO] [stderr] 289 | self.reg.sp = self.reg.sp - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.sp -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | self.reg.a = self.reg.a | operand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.a |= operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `op_Carry` should have a snake case name such as `op_carry` [INFO] [stderr] --> src/core/mod.rs:802:19 [INFO] [stderr] | [INFO] [stderr] 802 | let (operand, op_Carry) = self.get_8_pc(1).overflowing_add(self.reg.get_c() as u8); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:903:25 [INFO] [stderr] | [INFO] [stderr] 903 | let addr = 0xFF00 + (self.get_8_pc(1) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:913:25 [INFO] [stderr] | [INFO] [stderr] 913 | let addr = 0xFF00 + (self.reg.c as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:958:25 [INFO] [stderr] | [INFO] [stderr] 958 | let addr = 0xFF00 + (self.get_8_pc(1) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1024:4 [INFO] [stderr] | [INFO] [stderr] 1024 | ((self.get_8_pc(offset + 1) as u16) << 8) + (self.get_8_pc(offset) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(offset + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1024:47 [INFO] [stderr] | [INFO] [stderr] 1024 | ((self.get_8_pc(offset + 1) as u16) << 8) + (self.get_8_pc(offset) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1034:13 [INFO] [stderr] | [INFO] [stderr] 1034 | let low = self.mem.get_mem(self.reg.sp + 2) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem.get_mem(self.reg.sp + 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1035:14 [INFO] [stderr] | [INFO] [stderr] 1035 | let high = self.mem.get_mem(self.reg.sp + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem.get_mem(self.reg.sp + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:1041:3 [INFO] [stderr] | [INFO] [stderr] 1041 | self.reg.a = self.reg.a | operand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.a |= operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:1048:3 [INFO] [stderr] | [INFO] [stderr] 1048 | self.reg.a = self.reg.a & operand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.a &= operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/core/mod.rs:1085:4 [INFO] [stderr] | [INFO] [stderr] 1085 | 0x00 ..= 0x07 => operand, // Rotate left through carry [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/core/mod.rs:1086:4 [INFO] [stderr] | [INFO] [stderr] 1086 | 0x07 ..= 0x0F => operand, // Rotate right through carry [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1197:14 [INFO] [stderr] | [INFO] [stderr] 1197 | let half = self.reg.a & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.a.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1207:14 [INFO] [stderr] | [INFO] [stderr] 1207 | let half = self.reg.b & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.b.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1217:14 [INFO] [stderr] | [INFO] [stderr] 1217 | let half = self.reg.c & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.c.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1227:14 [INFO] [stderr] | [INFO] [stderr] 1227 | let half = self.reg.d & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.d.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1237:14 [INFO] [stderr] | [INFO] [stderr] 1237 | let half = self.reg.e & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.e.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1247:14 [INFO] [stderr] | [INFO] [stderr] 1247 | let half = self.reg.h & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.h.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1257:14 [INFO] [stderr] | [INFO] [stderr] 1257 | let half = self.reg.l & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.l.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/core/memory.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | 0 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loc` [INFO] [stderr] --> src/core/display.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn set_mem(&mut self, loc:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider using `_loc` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/core/display.rs:36:37 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn set_mem(&mut self, loc:u16, val:u8) { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op_Carry` [INFO] [stderr] --> src/core/mod.rs:802:19 [INFO] [stderr] | [INFO] [stderr] 802 | let (operand, op_Carry) = self.get_8_pc(1).overflowing_add(self.reg.get_c() as u8); [INFO] [stderr] | ^^^^^^^^ help: consider using `_op_Carry` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `f` [INFO] [stderr] --> src/core/registers.rs:3:2 [INFO] [stderr] | [INFO] [stderr] 3 | f, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_sub_half_carry_16` [INFO] [stderr] --> src/core/mod.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | fn check_sub_half_carry_16(a:u16, b:u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dec_a` [INFO] [stderr] --> src/core/mod.rs:1196:2 [INFO] [stderr] | [INFO] [stderr] 1196 | fn dec_a(&mut self) -> (u16, u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `rustBoy` should have a snake case name such as `rust_boy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `a` should have a camel case name such as `A` [INFO] [stderr] --> src/core/registers.rs:2:2 [INFO] [stderr] | [INFO] [stderr] 2 | a, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `f` should have a camel case name such as `F` [INFO] [stderr] --> src/core/registers.rs:3:2 [INFO] [stderr] | [INFO] [stderr] 3 | f, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `b` should have a camel case name such as `B` [INFO] [stderr] --> src/core/registers.rs:4:2 [INFO] [stderr] | [INFO] [stderr] 4 | b, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `c` should have a camel case name such as `C` [INFO] [stderr] --> src/core/registers.rs:5:2 [INFO] [stderr] | [INFO] [stderr] 5 | c, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `d` should have a camel case name such as `D` [INFO] [stderr] --> src/core/registers.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | d, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `e` should have a camel case name such as `E` [INFO] [stderr] --> src/core/registers.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | e, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `h` should have a camel case name such as `H` [INFO] [stderr] --> src/core/registers.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | h, [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variant `l` should have a camel case name such as `L` [INFO] [stderr] --> src/core/registers.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | l [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:46:4 [INFO] [stderr] | [INFO] [stderr] 46 | ((self.a as u16) << 8) | (self.f as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | ((self.a as u16) << 8) | (self.f as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | ((self.b as u16) << 8) | (self.c as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:55:28 [INFO] [stderr] | [INFO] [stderr] 55 | ((self.b as u16) << 8) | (self.c as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.d as u16) << 8) | (self.e as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | ((self.d as u16) << 8) | (self.e as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | ((self.h as u16) << 8) | (self.l as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/registers.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | ((self.h as u16) << 8) | (self.l as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/core/rom.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => panic!("Can't read {}", filename) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/core/rom.rs:22:6 [INFO] [stderr] | [INFO] [stderr] 22 | fo.read(&mut self.data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | self.reg.pc += raw as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(raw)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:195:19 [INFO] [stderr] | [INFO] [stderr] 195 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:233:19 [INFO] [stderr] | [INFO] [stderr] 233 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | let offset = self.get_8_pc(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:289:5 [INFO] [stderr] | [INFO] [stderr] 289 | self.reg.sp = self.reg.sp - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.sp -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | self.reg.a = self.reg.a | operand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.a |= operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `op_Carry` should have a snake case name such as `op_carry` [INFO] [stderr] --> src/core/mod.rs:802:19 [INFO] [stderr] | [INFO] [stderr] 802 | let (operand, op_Carry) = self.get_8_pc(1).overflowing_add(self.reg.get_c() as u8); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:903:25 [INFO] [stderr] | [INFO] [stderr] 903 | let addr = 0xFF00 + (self.get_8_pc(1) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:913:25 [INFO] [stderr] | [INFO] [stderr] 913 | let addr = 0xFF00 + (self.reg.c as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:958:25 [INFO] [stderr] | [INFO] [stderr] 958 | let addr = 0xFF00 + (self.get_8_pc(1) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1024:4 [INFO] [stderr] | [INFO] [stderr] 1024 | ((self.get_8_pc(offset + 1) as u16) << 8) + (self.get_8_pc(offset) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(offset + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1024:47 [INFO] [stderr] | [INFO] [stderr] 1024 | ((self.get_8_pc(offset + 1) as u16) << 8) + (self.get_8_pc(offset) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_8_pc(offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1034:13 [INFO] [stderr] | [INFO] [stderr] 1034 | let low = self.mem.get_mem(self.reg.sp + 2) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem.get_mem(self.reg.sp + 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/mod.rs:1035:14 [INFO] [stderr] | [INFO] [stderr] 1035 | let high = self.mem.get_mem(self.reg.sp + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem.get_mem(self.reg.sp + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:1041:3 [INFO] [stderr] | [INFO] [stderr] 1041 | self.reg.a = self.reg.a | operand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.a |= operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:1048:3 [INFO] [stderr] | [INFO] [stderr] 1048 | self.reg.a = self.reg.a & operand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.reg.a &= operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/core/mod.rs:1085:4 [INFO] [stderr] | [INFO] [stderr] 1085 | 0x00 ..= 0x07 => operand, // Rotate left through carry [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/core/mod.rs:1086:4 [INFO] [stderr] | [INFO] [stderr] 1086 | 0x07 ..= 0x0F => operand, // Rotate right through carry [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1197:14 [INFO] [stderr] | [INFO] [stderr] 1197 | let half = self.reg.a & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.a.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1207:14 [INFO] [stderr] | [INFO] [stderr] 1207 | let half = self.reg.b & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.b.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1217:14 [INFO] [stderr] | [INFO] [stderr] 1217 | let half = self.reg.c & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.c.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1227:14 [INFO] [stderr] | [INFO] [stderr] 1227 | let half = self.reg.d & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.d.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1237:14 [INFO] [stderr] | [INFO] [stderr] 1237 | let half = self.reg.e & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.e.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1247:14 [INFO] [stderr] | [INFO] [stderr] 1247 | let half = self.reg.h & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.h.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/core/mod.rs:1257:14 [INFO] [stderr] | [INFO] [stderr] 1257 | let half = self.reg.l & 0xF == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.reg.l.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "8447cb325ff25389ef5c2082d6ea874542e5ad37c1d97d995c949d01a91194c7"` [INFO] running `"docker" "rm" "-f" "8447cb325ff25389ef5c2082d6ea874542e5ad37c1d97d995c949d01a91194c7"` [INFO] [stdout] 8447cb325ff25389ef5c2082d6ea874542e5ad37c1d97d995c949d01a91194c7