[INFO] updating cached repository redox-os/calc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/redox-os/calc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/redox-os/calc" "work/ex/clippy-test-run/sources/stable/gh/redox-os/calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/redox-os/calc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/redox-os/calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/redox-os/calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/redox-os/calc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a06be98d14d2cc23b36eb3a0b676a5fb7dacc331 [INFO] sha for GitHub repo redox-os/calc: a06be98d14d2cc23b36eb3a0b676a5fb7dacc331 [INFO] validating manifest of redox-os/calc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of redox-os/calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing redox-os/calc [INFO] finished frobbing redox-os/calc [INFO] frobbed toml for redox-os/calc written to work/ex/clippy-test-run/sources/stable/gh/redox-os/calc/Cargo.toml [INFO] started frobbing redox-os/calc [INFO] finished frobbing redox-os/calc [INFO] frobbed toml for redox-os/calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/redox-os/calc/Cargo.toml [INFO] crate redox-os/calc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting redox-os/calc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/redox-os/calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b7bc5f1bb91d1fc69604147e6708ad7209a826c66245527aa14b2ade0749081 [INFO] running `"docker" "start" "-a" "4b7bc5f1bb91d1fc69604147e6708ad7209a826c66245527aa14b2ade0749081"` [INFO] [stderr] Checking bytecount v0.1.7 [INFO] [stderr] Checking serde v1.0.16 [INFO] [stderr] Checking ord_subset v2.1.0 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Compiling decimal v2.0.0 [INFO] [stderr] Checking num-complex v0.1.41 [INFO] [stderr] Checking clap v2.27.0 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking liner v0.4.2 [INFO] [stderr] Checking num-bigint v0.1.41 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking backtrace v0.3.6 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking calculate v0.7.0 (/opt/crater/workdir) [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/lib.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, feature(test))] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `calculate`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/value.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | return Err(CalcError::BadTypes(PartialComp::unary("~", f))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CalcError::BadTypes(PartialComp::unary("~", f)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parse::DefaultEnvironment` [INFO] [stderr] --> src/parse.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / pub fn new() -> DefaultEnvironment { [INFO] [stderr] 281 | | DefaultEnvironment { recursion_level: 0 } [INFO] [stderr] 282 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 275 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/token.rs:330:12 [INFO] [stderr] | [INFO] [stderr] 330 | if values.len() == 0 || operators.len() != values.len() - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn merge(&self, that: &IntegralFmt) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn merge(&self, that: &IntegralFmt) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `IntegralFmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/value.rs:126:36 [INFO] [stderr] | [INFO] [stderr] 126 | n.to_i64().map(Into::into).ok_or(CalcError::WouldTruncate( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 127 | | PartialComp::ToFloat(n.to_string()), [INFO] [stderr] 128 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | n.to_i64().map(Into::into).ok_or_else(|| CalcError::WouldTruncate( [INFO] [stderr] 127 | PartialComp::ToFloat(n.to_string()), [INFO] [stderr] 128 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `v2 @ _` pattern can be written as just `v2` [INFO] [stderr] --> src/value.rs:172:36 [INFO] [stderr] | [INFO] [stderr] 172 | (v1 @ Value::Float(_), v2 @ _) | (v1 @ _, v2 @ Value::Float(_)) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `v1 @ _` pattern can be written as just `v1` [INFO] [stderr] --> src/value.rs:172:47 [INFO] [stderr] | [INFO] [stderr] 172 | (v1 @ Value::Float(_), v2 @ _) | (v1 @ _, v2 @ Value::Float(_)) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/value.rs:298:23 [INFO] [stderr] | [INFO] [stderr] 298 | if (n % m).is_zero() { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/value.rs:299:47 [INFO] [stderr] | [INFO] [stderr] 299 | Value::Integral(n / m, t1 + t2) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/value.rs:381:18 [INFO] [stderr] | [INFO] [stderr] 381 | .ok_or(CalcError::WouldOverflow(PartialComp::binary( [INFO] [stderr] | __________________^ [INFO] [stderr] 382 | | "<<", &self, &that, [INFO] [stderr] 383 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 381 | .ok_or_else(|| CalcError::WouldOverflow(PartialComp::binary( [INFO] [stderr] 382 | "<<", &self, &that, [INFO] [stderr] 383 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/value.rs:401:18 [INFO] [stderr] | [INFO] [stderr] 401 | .ok_or(CalcError::WouldOverflow(PartialComp::binary( [INFO] [stderr] | __________________^ [INFO] [stderr] 402 | | ">>", &self, &that, [INFO] [stderr] 403 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 401 | .ok_or_else(|| CalcError::WouldOverflow(PartialComp::binary( [INFO] [stderr] 402 | ">>", &self, &that, [INFO] [stderr] 403 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `calculate`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4b7bc5f1bb91d1fc69604147e6708ad7209a826c66245527aa14b2ade0749081"` [INFO] running `"docker" "rm" "-f" "4b7bc5f1bb91d1fc69604147e6708ad7209a826c66245527aa14b2ade0749081"` [INFO] [stdout] 4b7bc5f1bb91d1fc69604147e6708ad7209a826c66245527aa14b2ade0749081