[INFO] updating cached repository realityone/akarin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/realityone/akarin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/realityone/akarin" "work/ex/clippy-test-run/sources/stable/gh/realityone/akarin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/realityone/akarin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/realityone/akarin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/realityone/akarin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/realityone/akarin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6734d9b14288800ee23415a6a900fe115c803960 [INFO] sha for GitHub repo realityone/akarin: 6734d9b14288800ee23415a6a900fe115c803960 [INFO] validating manifest of realityone/akarin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of realityone/akarin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing realityone/akarin [INFO] finished frobbing realityone/akarin [INFO] frobbed toml for realityone/akarin written to work/ex/clippy-test-run/sources/stable/gh/realityone/akarin/Cargo.toml [INFO] started frobbing realityone/akarin [INFO] finished frobbing realityone/akarin [INFO] frobbed toml for realityone/akarin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/realityone/akarin/Cargo.toml [INFO] crate realityone/akarin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting realityone/akarin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/realityone/akarin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0df2caf69bf0d15545359fba45224d104f26460527f038a32349f05ce4cf4606 [INFO] running `"docker" "start" "-a" "0df2caf69bf0d15545359fba45224d104f26460527f038a32349f05ce4cf4606"` [INFO] [stderr] Compiling either v1.2.0 [INFO] [stderr] Compiling lazy_static v0.2.9 [INFO] [stderr] Compiling cc v1.0.0 [INFO] [stderr] Checking ioctl-sys v0.5.2 [INFO] [stderr] Compiling num_cpus v1.7.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking transient-hashmap v0.4.0 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Compiling backtrace-sys v0.1.14 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-core v0.1.10 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking pretty_env_logger v0.1.1 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking akarin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tun/sockaddr.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | ((parts[0] as c_uint)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tun/linux/../unix/tokio.rs.in:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tun/linux/../unix/tokio.rs.in:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem` [INFO] [stderr] --> src/akarin/server.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use std::{fmt, io, mem}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/akarin/mod.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn serve(self, mut core: Core, handle: Handle) -> Result<()>; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/akarin/mod.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | fn connect(self, mut core: Core, handle: Handle) -> Result<()>; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unused import: `common::error::*` [INFO] [stderr] --> src/transport/network.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use common::error::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tun/sockaddr.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | ((parts[0] as c_uint)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tun/linux/../unix/tokio.rs.in:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tun/linux/../unix/tokio.rs.in:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "unreachable state".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `mem` [INFO] [stderr] --> src/akarin/server.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | use std::{fmt, io, mem}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/akarin/mod.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn serve(self, mut core: Core, handle: Handle) -> Result<()>; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/akarin/mod.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | fn connect(self, mut core: Core, handle: Handle) -> Result<()>; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unused import: `common::error::*` [INFO] [stderr] --> src/transport/network.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use common::error::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `crypto` [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | let crypto = Ciphers::CHACHA20_POLY1305.init(password); [INFO] [stderr] | ^^^^^^ help: consider using `_crypto` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `token` [INFO] [stderr] --> src/akarin/server.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | if let Some(&(token, sockaddr)) = self.clients.get(client_id) {} [INFO] [stderr] | ^^^^^ help: consider using `_token` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sockaddr` [INFO] [stderr] --> src/akarin/server.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | if let Some(&(token, sockaddr)) = self.clients.get(client_id) {} [INFO] [stderr] | ^^^^^^^^ help: consider using `_sockaddr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handle` [INFO] [stderr] --> src/akarin/server.rs:163:40 [INFO] [stderr] | [INFO] [stderr] 163 | fn serve(mut self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_handle` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `core` [INFO] [stderr] --> src/akarin/client.rs:39:26 [INFO] [stderr] | [INFO] [stderr] 39 | fn connect(self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider using `_core` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handle` [INFO] [stderr] --> src/akarin/client.rs:39:38 [INFO] [stderr] | [INFO] [stderr] 39 | fn connect(self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_handle` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/akarin/server.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | fn serve(mut self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/akarin/client.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | fn connect(self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_in`) [INFO] [stderr] --> src/tun/sockaddr.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | Ok(SockAddr(ptr::read(value as *const _ as *const _))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | s_addr: ((parts[3] as c_uint) << 24) | ((parts[2] as c_uint) << 16) | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | s_addr: ((parts[3] as c_uint) << 24) | ((parts[2] as c_uint) << 16) | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:55:84 [INFO] [stderr] | [INFO] [stderr] 55 | s_addr: ((parts[3] as c_uint) << 24) | ((parts[2] as c_uint) << 16) | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | ((parts[0] as c_uint)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `crypto` [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | let crypto = Ciphers::CHACHA20_POLY1305.init(password); [INFO] [stderr] | ^^^^^^ help: consider using `_crypto` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `token` [INFO] [stderr] --> src/akarin/server.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | if let Some(&(token, sockaddr)) = self.clients.get(client_id) {} [INFO] [stderr] | ^^^^^ help: consider using `_token` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sockaddr` [INFO] [stderr] --> src/akarin/server.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | if let Some(&(token, sockaddr)) = self.clients.get(client_id) {} [INFO] [stderr] | ^^^^^^^^ help: consider using `_sockaddr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handle` [INFO] [stderr] --> src/akarin/server.rs:163:40 [INFO] [stderr] | [INFO] [stderr] 163 | fn serve(mut self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_handle` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `core` [INFO] [stderr] --> src/akarin/client.rs:39:26 [INFO] [stderr] | [INFO] [stderr] 39 | fn connect(self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider using `_core` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handle` [INFO] [stderr] --> src/akarin/client.rs:39:38 [INFO] [stderr] | [INFO] [stderr] 39 | fn connect(self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_handle` instead [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/akarin/server.rs:46:40 [INFO] [stderr] | [INFO] [stderr] 46 | id_set: HashSet::from_iter(id_range.into_iter()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `id_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/akarin/server.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | self.id_set.iter().map(|i| *i).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.id_set.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/akarin/server.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | Some(id) => id.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/akarin/server.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | core.run(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/akarin/server.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | fn serve(mut self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/akarin/client.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | fn connect(self, mut core: Core, handle: Handle) -> Result<()> { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_in`) [INFO] [stderr] --> src/tun/sockaddr.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | Ok(SockAddr(ptr::read(value as *const _ as *const _))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | s_addr: ((parts[3] as c_uint) << 24) | ((parts[2] as c_uint) << 16) | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | s_addr: ((parts[3] as c_uint) << 24) | ((parts[2] as c_uint) << 16) | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:55:84 [INFO] [stderr] | [INFO] [stderr] 55 | s_addr: ((parts[3] as c_uint) << 24) | ((parts[2] as c_uint) << 16) | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tun/sockaddr.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | ((parts[0] as c_uint)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `akarin`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/akarin/server.rs:46:40 [INFO] [stderr] | [INFO] [stderr] 46 | id_set: HashSet::from_iter(id_range.into_iter()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `id_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/akarin/server.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | self.id_set.iter().map(|i| *i).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.id_set.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/akarin/server.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | Some(id) => id.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/akarin/server.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | core.run(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/akarin/server.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | let ref mut us = ClientStorage::new(0..255, 60); [INFO] [stderr] | ----^^^^^^^^^^---------------------------------- help: try: `let us = &mut ClientStorage::new(0..255, 60);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `akarin`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0df2caf69bf0d15545359fba45224d104f26460527f038a32349f05ce4cf4606"` [INFO] running `"docker" "rm" "-f" "0df2caf69bf0d15545359fba45224d104f26460527f038a32349f05ce4cf4606"` [INFO] [stdout] 0df2caf69bf0d15545359fba45224d104f26460527f038a32349f05ce4cf4606