[INFO] updating cached repository rbi/rddns [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rbi/rddns [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rbi/rddns" "work/ex/clippy-test-run/sources/stable/gh/rbi/rddns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rbi/rddns'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rbi/rddns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rbi/rddns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rbi/rddns'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1bc05e9fe9c5f0b2cd6231a7f29e0ac27f16d4be [INFO] sha for GitHub repo rbi/rddns: 1bc05e9fe9c5f0b2cd6231a7f29e0ac27f16d4be [INFO] validating manifest of rbi/rddns on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rbi/rddns on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rbi/rddns [INFO] finished frobbing rbi/rddns [INFO] frobbed toml for rbi/rddns written to work/ex/clippy-test-run/sources/stable/gh/rbi/rddns/Cargo.toml [INFO] started frobbing rbi/rddns [INFO] finished frobbing rbi/rddns [INFO] frobbed toml for rbi/rddns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rbi/rddns/Cargo.toml [INFO] crate rbi/rddns has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rbi/rddns against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rbi/rddns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1087e94c086aecff8a0c26a5d859d1bc8099a8b67580bba544a95a25b54756ee [INFO] running `"docker" "start" "-a" "1087e94c086aecff8a0c26a5d859d1bc8099a8b67580bba544a95a25b54756ee"` [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Compiling openssl-sys v0.9.23 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking futures-cpupool v0.1.7 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking hyper v0.11.9 [INFO] [stderr] Compiling openssl v0.9.23 [INFO] [stderr] Checking simplelog v0.5.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking rddns v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/updater.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/updater.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_url` [INFO] [stderr] --> tests/rddns_driver/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get_url(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> tests/rddns_driver/mod.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_running(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> tests/rddns_driver/mod.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_running(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command_line.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | .unwrap_or_else(|| HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:134:38 [INFO] [stderr] | [INFO] [stderr] 134 | let iter = query.map(|q| q.split("&")); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / match iter { [INFO] [stderr] 136 | | Some(params) => for param in params { [INFO] [stderr] 137 | | let address_param = to_address_param(param); [INFO] [stderr] 138 | | match address_param { [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => () [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let Some(params) = iter for param in params { [INFO] [stderr] 136 | let address_param = to_address_param(param); [INFO] [stderr] 137 | match address_param { [INFO] [stderr] 138 | Some((key, value)) => match value.parse() { [INFO] [stderr] 139 | Ok(addr) => map.insert(key, addr), [INFO] [stderr] 140 | Err(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/resolver.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn resolve(entries: &Vec, address_defs: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[DdnsEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/resolver.rs:77:51 [INFO] [stderr] | [INFO] [stderr] 77 | IpAddress::Static { address } => Some(address.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/resolver.rs:139:38 [INFO] [stderr] | [INFO] [stderr] 139 | fn resolve_derived_ipv4(net_address: &Ipv4Addr, host_address: &Ipv4Addr, subnet_bits: u8) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/resolver.rs:139:63 [INFO] [stderr] | [INFO] [stderr] 139 | fn resolve_derived_ipv4(net_address: &Ipv4Addr, host_address: &Ipv4Addr, subnet_bits: u8) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/resolver.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let shift = subnet_bits as i16 - (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(subnet_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/resolver.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | let shift = subnet_bits as i16 - (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(subnet_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/updater.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | ddns_entry.original.username.clone().map(|username| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 32 | || let auth = Authorization( [INFO] [stderr] 33 | || Basic { [INFO] [stderr] 34 | || username: username, [INFO] [stderr] ... || [INFO] [stderr] 38 | || request.headers_mut().set(auth); [INFO] [stderr] 39 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(username) = ddns_entry.original.username.clone() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command_line.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | .unwrap_or_else(|| HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:96:79 [INFO] [stderr] | [INFO] [stderr] 96 | fn handle_error_while_updating(error: &mut String, entity: &Display, message: &String, return_error: bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:134:38 [INFO] [stderr] | [INFO] [stderr] 134 | let iter = query.map(|q| q.split("&")); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / match iter { [INFO] [stderr] 136 | | Some(params) => for param in params { [INFO] [stderr] 137 | | let address_param = to_address_param(param); [INFO] [stderr] 138 | | match address_param { [INFO] [stderr] ... | [INFO] [stderr] 149 | | _ => () [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let Some(params) = iter for param in params { [INFO] [stderr] 136 | let address_param = to_address_param(param); [INFO] [stderr] 137 | match address_param { [INFO] [stderr] 138 | Some((key, value)) => match value.parse() { [INFO] [stderr] 139 | Ok(addr) => map.insert(key, addr), [INFO] [stderr] 140 | Err(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/resolver.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn resolve(entries: &Vec, address_defs: &HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[DdnsEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/resolver.rs:77:51 [INFO] [stderr] | [INFO] [stderr] 77 | IpAddress::Static { address } => Some(address.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/resolver.rs:139:38 [INFO] [stderr] | [INFO] [stderr] 139 | fn resolve_derived_ipv4(net_address: &Ipv4Addr, host_address: &Ipv4Addr, subnet_bits: u8) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/resolver.rs:139:63 [INFO] [stderr] | [INFO] [stderr] 139 | fn resolve_derived_ipv4(net_address: &Ipv4Addr, host_address: &Ipv4Addr, subnet_bits: u8) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/resolver.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let shift = subnet_bits as i16 - (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(subnet_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/resolver.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | let shift = subnet_bits as i16 - (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(subnet_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/updater.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | ddns_entry.original.username.clone().map(|username| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 32 | || let auth = Authorization( [INFO] [stderr] 33 | || Basic { [INFO] [stderr] 34 | || username: username, [INFO] [stderr] ... || [INFO] [stderr] 38 | || request.headers_mut().set(auth); [INFO] [stderr] 39 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(username) = ddns_entry.original.username.clone() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:96:79 [INFO] [stderr] | [INFO] [stderr] 96 | fn handle_error_while_updating(error: &mut String, entity: &Display, message: &String, return_error: bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.41s [INFO] running `"docker" "inspect" "1087e94c086aecff8a0c26a5d859d1bc8099a8b67580bba544a95a25b54756ee"` [INFO] running `"docker" "rm" "-f" "1087e94c086aecff8a0c26a5d859d1bc8099a8b67580bba544a95a25b54756ee"` [INFO] [stdout] 1087e94c086aecff8a0c26a5d859d1bc8099a8b67580bba544a95a25b54756ee