[INFO] updating cached repository rayman520/Untitled1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rayman520/Untitled1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rayman520/Untitled1" "work/ex/clippy-test-run/sources/stable/gh/rayman520/Untitled1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rayman520/Untitled1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rayman520/Untitled1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rayman520/Untitled1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rayman520/Untitled1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a8c219db8ea7479f63e29a9df0e4a17a9770d80 [INFO] sha for GitHub repo rayman520/Untitled1: 1a8c219db8ea7479f63e29a9df0e4a17a9770d80 [INFO] validating manifest of rayman520/Untitled1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rayman520/Untitled1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rayman520/Untitled1 [INFO] finished frobbing rayman520/Untitled1 [INFO] frobbed toml for rayman520/Untitled1 written to work/ex/clippy-test-run/sources/stable/gh/rayman520/Untitled1/Cargo.toml [INFO] started frobbing rayman520/Untitled1 [INFO] finished frobbing rayman520/Untitled1 [INFO] frobbed toml for rayman520/Untitled1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rayman520/Untitled1/Cargo.toml [INFO] crate rayman520/Untitled1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rayman520/Untitled1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rayman520/Untitled1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba6e48895600a1e96a008bed17205882ec1360502678044d3eb6fb2eca7c5c9c [INFO] running `"docker" "start" "-a" "ba6e48895600a1e96a008bed17205882ec1360502678044d3eb6fb2eca7c5c9c"` [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking untitled1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/keyboard/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return g.sdl.event_pump.keyboard_state().pressed_scancodes().filter_map(Keycode::from_scancode).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `g.sdl.event_pump.keyboard_state().pressed_scancodes().filter_map(Keycode::from_scancode).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/init.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / return super::Globals{ [INFO] [stderr] 5 | | sdl: init_sdl(), [INFO] [stderr] 6 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 4 | super::Globals{ [INFO] [stderr] 5 | sdl: init_sdl(), [INFO] [stderr] 6 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/init.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return sdl_vars [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `sdl_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/keyboard/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return g.sdl.event_pump.keyboard_state().pressed_scancodes().filter_map(Keycode::from_scancode).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `g.sdl.event_pump.keyboard_state().pressed_scancodes().filter_map(Keycode::from_scancode).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/init.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / return super::Globals{ [INFO] [stderr] 5 | | sdl: init_sdl(), [INFO] [stderr] 6 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 4 | super::Globals{ [INFO] [stderr] 5 | sdl: init_sdl(), [INFO] [stderr] 6 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/init.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return sdl_vars [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `sdl_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/init.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut sdl_vars = super::SdlVars { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sdl` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | sdl: sdl2::Sdl, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `video_subsystem` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | video_subsystem: sdl2::VideoSubsystem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `window` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | window: sdl2::video::Window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/init.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut sdl_vars = super::SdlVars { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sdl` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | sdl: sdl2::Sdl, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `video_subsystem` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | video_subsystem: sdl2::VideoSubsystem, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `window` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | window: sdl2::video::Window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils/events/mod.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | / match event { [INFO] [stderr] 5 | | sdl2::event::Event::Quit { .. } => super::exit("window closed"), [INFO] [stderr] 6 | | _ => {/*println!("{:?}", event)*/}, [INFO] [stderr] 7 | | } [INFO] [stderr] | |_________^ help: try this: `if let sdl2::event::Event::Quit { .. } = event { super::exit("window closed") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils/events/mod.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | / match event { [INFO] [stderr] 5 | | sdl2::event::Event::Quit { .. } => super::exit("window closed"), [INFO] [stderr] 6 | | _ => {/*println!("{:?}", event)*/}, [INFO] [stderr] 7 | | } [INFO] [stderr] | |_________^ help: try this: `if let sdl2::event::Event::Quit { .. } = event { super::exit("window closed") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.20s [INFO] running `"docker" "inspect" "ba6e48895600a1e96a008bed17205882ec1360502678044d3eb6fb2eca7c5c9c"` [INFO] running `"docker" "rm" "-f" "ba6e48895600a1e96a008bed17205882ec1360502678044d3eb6fb2eca7c5c9c"` [INFO] [stdout] ba6e48895600a1e96a008bed17205882ec1360502678044d3eb6fb2eca7c5c9c