[INFO] updating cached repository raxod502/lucid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/raxod502/lucid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/raxod502/lucid" "work/ex/clippy-test-run/sources/stable/gh/raxod502/lucid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/raxod502/lucid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/raxod502/lucid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raxod502/lucid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raxod502/lucid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e74206b413bf95365bc4b620376f3d4a3c70cf54 [INFO] sha for GitHub repo raxod502/lucid: e74206b413bf95365bc4b620376f3d4a3c70cf54 [INFO] validating manifest of raxod502/lucid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of raxod502/lucid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing raxod502/lucid [INFO] finished frobbing raxod502/lucid [INFO] frobbed toml for raxod502/lucid written to work/ex/clippy-test-run/sources/stable/gh/raxod502/lucid/Cargo.toml [INFO] started frobbing raxod502/lucid [INFO] finished frobbing raxod502/lucid [INFO] frobbed toml for raxod502/lucid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raxod502/lucid/Cargo.toml [INFO] crate raxod502/lucid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting raxod502/lucid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/raxod502/lucid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b10c0b3eaac589b296973048f0aff9d96fb4c70901c8668fc78c1e3380c38ab3 [INFO] running `"docker" "start" "-a" "b10c0b3eaac589b296973048f0aff9d96fb4c70901c8668fc78c1e3380c38ab3"` [INFO] [stderr] Compiling gcc v0.3.45 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking lucid v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:144:42 [INFO] [stderr] | [INFO] [stderr] 144 | try!(write!(f, "{} {} {}\n", match &entry.data { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 145 | | &TreeEntryData::Blob { ref filetype, .. } => match filetype { [INFO] [stderr] 146 | | &FileType::NormalFile => "file", [INFO] [stderr] 147 | | &FileType::Executable => "exec", [INFO] [stderr] ... | [INFO] [stderr] 150 | | &TreeEntryData::Tree { .. } => "tree", [INFO] [stderr] 151 | | }, match &entry.data { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 144 | try!(write!(f, "{} {} {}\n", match entry.data { [INFO] [stderr] 145 | TreeEntryData::Blob { ref filetype, .. } => match filetype { [INFO] [stderr] 146 | &FileType::NormalFile => "file", [INFO] [stderr] 147 | &FileType::Executable => "exec", [INFO] [stderr] 148 | &FileType::SymbolicLink => "link", [INFO] [stderr] 149 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:145:62 [INFO] [stderr] | [INFO] [stderr] 145 | &TreeEntryData::Blob { ref filetype, .. } => match filetype { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 146 | | &FileType::NormalFile => "file", [INFO] [stderr] 147 | | &FileType::Executable => "exec", [INFO] [stderr] 148 | | &FileType::SymbolicLink => "link", [INFO] [stderr] 149 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | &TreeEntryData::Blob { ref filetype, .. } => match *filetype { [INFO] [stderr] 146 | FileType::NormalFile => "file", [INFO] [stderr] 147 | FileType::Executable => "exec", [INFO] [stderr] 148 | FileType::SymbolicLink => "link", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | }, match &entry.data { [INFO] [stderr] | ________________^ [INFO] [stderr] 152 | | &TreeEntryData::Blob { ref blob, .. } => blob.to_hash(), [INFO] [stderr] 153 | | &TreeEntryData::Tree { ref tree } => tree.to_hash(), [INFO] [stderr] 154 | | }, entry.name)); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | }, match entry.data { [INFO] [stderr] 152 | TreeEntryData::Blob { ref blob, .. } => blob.to_hash(), [INFO] [stderr] 153 | TreeEntryData::Tree { ref tree } => tree.to_hash(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:144:42 [INFO] [stderr] | [INFO] [stderr] 144 | try!(write!(f, "{} {} {}\n", match &entry.data { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 145 | | &TreeEntryData::Blob { ref filetype, .. } => match filetype { [INFO] [stderr] 146 | | &FileType::NormalFile => "file", [INFO] [stderr] 147 | | &FileType::Executable => "exec", [INFO] [stderr] ... | [INFO] [stderr] 150 | | &TreeEntryData::Tree { .. } => "tree", [INFO] [stderr] 151 | | }, match &entry.data { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 144 | try!(write!(f, "{} {} {}\n", match entry.data { [INFO] [stderr] 145 | TreeEntryData::Blob { ref filetype, .. } => match filetype { [INFO] [stderr] 146 | &FileType::NormalFile => "file", [INFO] [stderr] 147 | &FileType::Executable => "exec", [INFO] [stderr] 148 | &FileType::SymbolicLink => "link", [INFO] [stderr] 149 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:145:62 [INFO] [stderr] | [INFO] [stderr] 145 | &TreeEntryData::Blob { ref filetype, .. } => match filetype { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 146 | | &FileType::NormalFile => "file", [INFO] [stderr] 147 | | &FileType::Executable => "exec", [INFO] [stderr] 148 | | &FileType::SymbolicLink => "link", [INFO] [stderr] 149 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | &TreeEntryData::Blob { ref filetype, .. } => match *filetype { [INFO] [stderr] 146 | FileType::NormalFile => "file", [INFO] [stderr] 147 | FileType::Executable => "exec", [INFO] [stderr] 148 | FileType::SymbolicLink => "link", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | }, match &entry.data { [INFO] [stderr] | ________________^ [INFO] [stderr] 152 | | &TreeEntryData::Blob { ref blob, .. } => blob.to_hash(), [INFO] [stderr] 153 | | &TreeEntryData::Tree { ref tree } => tree.to_hash(), [INFO] [stderr] 154 | | }, entry.name)); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | }, match entry.data { [INFO] [stderr] 152 | TreeEntryData::Blob { ref blob, .. } => blob.to_hash(), [INFO] [stderr] 153 | TreeEntryData::Tree { ref tree } => tree.to_hash(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.21s [INFO] running `"docker" "inspect" "b10c0b3eaac589b296973048f0aff9d96fb4c70901c8668fc78c1e3380c38ab3"` [INFO] running `"docker" "rm" "-f" "b10c0b3eaac589b296973048f0aff9d96fb4c70901c8668fc78c1e3380c38ab3"` [INFO] [stdout] b10c0b3eaac589b296973048f0aff9d96fb4c70901c8668fc78c1e3380c38ab3