[INFO] updating cached repository ratorx/modman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ratorx/modman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ratorx/modman" "work/ex/clippy-test-run/sources/stable/gh/ratorx/modman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ratorx/modman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ratorx/modman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ratorx/modman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ratorx/modman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f7db3102094b34a6c559d641b6ab67814e54045a [INFO] sha for GitHub repo ratorx/modman: f7db3102094b34a6c559d641b6ab67814e54045a [INFO] validating manifest of ratorx/modman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ratorx/modman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ratorx/modman [INFO] finished frobbing ratorx/modman [INFO] frobbed toml for ratorx/modman written to work/ex/clippy-test-run/sources/stable/gh/ratorx/modman/Cargo.toml [INFO] started frobbing ratorx/modman [INFO] finished frobbing ratorx/modman [INFO] frobbed toml for ratorx/modman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ratorx/modman/Cargo.toml [INFO] crate ratorx/modman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting ratorx/modman against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ratorx/modman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 636ea79c286526d8c3b8bd0525f57118eb84ec57b38c7b9e2f72043f13812ea5 [INFO] running `"docker" "start" "-a" "636ea79c286526d8c3b8bd0525f57118eb84ec57b38c7b9e2f72043f13812ea5"` [INFO] [stderr] Checking modman v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:46 [INFO] [stderr] | [INFO] [stderr] 179 | Err(err @ ModuleError::Directory) => return Err(wrap_module_err(err)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(wrap_module_err(err))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / return Ok(Module::list(module_dir)? [INFO] [stderr] 194 | | .into_iter() [INFO] [stderr] 195 | | .filter_map(|m| m.ok()) [INFO] [stderr] 196 | | .filter(|m| !excluded_module_names.contains(m.name())) [INFO] [stderr] 197 | | .collect()); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 193 | Ok(Module::list(module_dir)? [INFO] [stderr] 194 | .into_iter() [INFO] [stderr] 195 | .filter_map(|m| m.ok()) [INFO] [stderr] 196 | .filter(|m| !excluded_module_names.contains(m.name())) [INFO] [stderr] 197 | .collect()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(modules); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(modules)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:46 [INFO] [stderr] | [INFO] [stderr] 179 | Err(err @ ModuleError::Directory) => return Err(wrap_module_err(err)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(wrap_module_err(err))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / return Ok(Module::list(module_dir)? [INFO] [stderr] 194 | | .into_iter() [INFO] [stderr] 195 | | .filter_map(|m| m.ok()) [INFO] [stderr] 196 | | .filter(|m| !excluded_module_names.contains(m.name())) [INFO] [stderr] 197 | | .collect()); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 193 | Ok(Module::list(module_dir)? [INFO] [stderr] 194 | .into_iter() [INFO] [stderr] 195 | .filter_map(|m| m.ok()) [INFO] [stderr] 196 | .filter(|m| !excluded_module_names.contains(m.name())) [INFO] [stderr] 197 | .collect()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(modules); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(modules)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match app.is_present("verbose") { [INFO] [stderr] 45 | | true => log::set_max_level(log::LevelFilter::Info), [INFO] [stderr] 46 | | _ => log::set_max_level(log::LevelFilter::Warn), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if app.is_present("verbose") { log::set_max_level(log::LevelFilter::Info) } else { log::set_max_level(log::LevelFilter::Warn) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / match err { [INFO] [stderr] 57 | | Err(err) => err.exit(), [INFO] [stderr] 58 | | _ => (), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = err { err.exit() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:216:40 [INFO] [stderr] | [INFO] [stderr] 216 | let modules = resolve(app).map_err(|err| wrap_module_err(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `wrap_module_err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:227:40 [INFO] [stderr] | [INFO] [stderr] 227 | let modules = resolve(app).map_err(|err| wrap_module_err(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `wrap_module_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match app.is_present("verbose") { [INFO] [stderr] 45 | | true => log::set_max_level(log::LevelFilter::Info), [INFO] [stderr] 46 | | _ => log::set_max_level(log::LevelFilter::Warn), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if app.is_present("verbose") { log::set_max_level(log::LevelFilter::Info) } else { log::set_max_level(log::LevelFilter::Warn) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / match err { [INFO] [stderr] 57 | | Err(err) => err.exit(), [INFO] [stderr] 58 | | _ => (), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = err { err.exit() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:216:40 [INFO] [stderr] | [INFO] [stderr] 216 | let modules = resolve(app).map_err(|err| wrap_module_err(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `wrap_module_err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:227:40 [INFO] [stderr] | [INFO] [stderr] 227 | let modules = resolve(app).map_err(|err| wrap_module_err(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `wrap_module_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "636ea79c286526d8c3b8bd0525f57118eb84ec57b38c7b9e2f72043f13812ea5"` [INFO] running `"docker" "rm" "-f" "636ea79c286526d8c3b8bd0525f57118eb84ec57b38c7b9e2f72043f13812ea5"` [INFO] [stdout] 636ea79c286526d8c3b8bd0525f57118eb84ec57b38c7b9e2f72043f13812ea5