[INFO] updating cached repository raskad/poker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/raskad/poker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/raskad/poker" "work/ex/clippy-test-run/sources/stable/gh/raskad/poker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/raskad/poker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/raskad/poker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raskad/poker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raskad/poker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64d32ad1de5f88757cc457eb155513aba6efd2eb [INFO] sha for GitHub repo raskad/poker: 64d32ad1de5f88757cc457eb155513aba6efd2eb [INFO] validating manifest of raskad/poker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of raskad/poker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing raskad/poker [INFO] finished frobbing raskad/poker [INFO] frobbed toml for raskad/poker written to work/ex/clippy-test-run/sources/stable/gh/raskad/poker/Cargo.toml [INFO] started frobbing raskad/poker [INFO] finished frobbing raskad/poker [INFO] frobbed toml for raskad/poker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raskad/poker/Cargo.toml [INFO] crate raskad/poker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting raskad/poker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/raskad/poker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 697cdd5cdd0ff1a73d04374f5229ddd199dbecfa14a1ad211281185f7260fb92 [INFO] running `"docker" "start" "-a" "697cdd5cdd0ff1a73d04374f5229ddd199dbecfa14a1ad211281185f7260fb92"` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking poker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | seat: seat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | seat: seat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `counts` [INFO] [stderr] --> src/hand.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (i, ) in counts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `counts` [INFO] [stderr] --> src/hand.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 192 | for (i, ) in counts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `counts` [INFO] [stderr] --> src/hand.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (i, ) in counts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `counts` [INFO] [stderr] --> src/hand.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 192 | for (i, ) in counts.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/hand.rs:501:5 [INFO] [stderr] | [INFO] [stderr] 501 | / fn compare() { [INFO] [stderr] 502 | | let royalflush = Hand::value([ [INFO] [stderr] 503 | | Card { rank: 14, suit: 0 }, [INFO] [stderr] 504 | | Card { rank: 13, suit: 1 }, [INFO] [stderr] ... | [INFO] [stderr] 636 | | assert_eq!(pair, pair); [INFO] [stderr] 637 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.86s [INFO] running `"docker" "inspect" "697cdd5cdd0ff1a73d04374f5229ddd199dbecfa14a1ad211281185f7260fb92"` [INFO] running `"docker" "rm" "-f" "697cdd5cdd0ff1a73d04374f5229ddd199dbecfa14a1ad211281185f7260fb92"` [INFO] [stdout] 697cdd5cdd0ff1a73d04374f5229ddd199dbecfa14a1ad211281185f7260fb92