[INFO] updating cached repository rasendubi/zink [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rasendubi/zink [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rasendubi/zink" "work/ex/clippy-test-run/sources/stable/gh/rasendubi/zink"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rasendubi/zink'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rasendubi/zink" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rasendubi/zink"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rasendubi/zink'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d903389688d52665d84832a5e25b5385d7ebab52 [INFO] sha for GitHub repo rasendubi/zink: d903389688d52665d84832a5e25b5385d7ebab52 [INFO] validating manifest of rasendubi/zink on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rasendubi/zink on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rasendubi/zink [INFO] finished frobbing rasendubi/zink [INFO] frobbed toml for rasendubi/zink written to work/ex/clippy-test-run/sources/stable/gh/rasendubi/zink/Cargo.toml [INFO] started frobbing rasendubi/zink [INFO] finished frobbing rasendubi/zink [INFO] frobbed toml for rasendubi/zink written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rasendubi/zink/Cargo.toml [INFO] crate rasendubi/zink has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rasendubi/zink against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rasendubi/zink:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13dfc18adfb1f92522f1d9663e1459362a2c2c4107bdc34b693209f7de2502fb [INFO] running `"docker" "start" "-a" "13dfc18adfb1f92522f1d9663e1459362a2c2c4107bdc34b693209f7de2502fb"` [INFO] [stderr] Checking bitflags v0.8.0 [INFO] [stderr] Checking either v1.0.3 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking num_cpus v1.4.0 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking serde_json v0.9.9 [INFO] [stderr] Compiling hyper v0.10.9 [INFO] [stderr] Checking clap v2.21.1 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking itertools v0.5.9 [INFO] [stderr] Checking aho-corasick v0.6.2 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking mqtt-protocol v0.4.2 [INFO] [stderr] Checking rs-jsonpath v0.1.0 [INFO] [stderr] Checking zink v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_data_processor.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | patterns: patterns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `patterns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_data_processor.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | patterns: patterns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `patterns` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/csv_data_processor.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | fn process_entries(&self, entries: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/csv_data_processor.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | for entry in entries.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/csv_data_processor.rs:35:66 [INFO] [stderr] | [INFO] [stderr] 35 | let res = look(&entry, &entry, path.clone()).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/influxdb_data_processor.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | fn process_entries(&self, entries: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/influxdb_data_processor.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | for entry in entries.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/influxdb_data_processor.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match (timestamp, tag_id, battery_level, temperature) { [INFO] [stderr] 36 | | (Ok(timestamp), Ok(tag_id), Ok(battery_level), Ok(temperature)) => { [INFO] [stderr] 37 | | let body = format!("sensor,tag={} temperature={},batteryLevel={} {}", [INFO] [stderr] 38 | | tag_id, temperature, battery_level, timestamp); [INFO] [stderr] ... | [INFO] [stderr] 48 | | }, [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let (Ok(timestamp), Ok(tag_id), Ok(battery_level), Ok(temperature)) = (timestamp, tag_id, battery_level, temperature) { [INFO] [stderr] 36 | let body = format!("sensor,tag={} temperature={},batteryLevel={} {}", [INFO] [stderr] 37 | tag_id, temperature, battery_level, timestamp); [INFO] [stderr] 38 | log!("{}", body); [INFO] [stderr] 39 | [INFO] [stderr] 40 | let res = self.client [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:42:78 [INFO] [stderr] | [INFO] [stderr] 42 | let jsonpaths: Vec = matches.value_of("JSONPATH").unwrap().split(",").map(String::from).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | fn handle_client<'a, 'b>(mut stream: TcpStream, app: &Application) -> Result<(), ZinkError<'a>> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:108:46 [INFO] [stderr] | [INFO] [stderr] 108 | x.payload().subscribes().into_iter().map(sub_to_ack).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/csv_data_processor.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | fn process_entries(&self, entries: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/csv_data_processor.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | for entry in entries.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/csv_data_processor.rs:35:66 [INFO] [stderr] | [INFO] [stderr] 35 | let res = look(&entry, &entry, path.clone()).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/influxdb_data_processor.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | fn process_entries(&self, entries: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/influxdb_data_processor.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | for entry in entries.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/influxdb_data_processor.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match (timestamp, tag_id, battery_level, temperature) { [INFO] [stderr] 36 | | (Ok(timestamp), Ok(tag_id), Ok(battery_level), Ok(temperature)) => { [INFO] [stderr] 37 | | let body = format!("sensor,tag={} temperature={},batteryLevel={} {}", [INFO] [stderr] 38 | | tag_id, temperature, battery_level, timestamp); [INFO] [stderr] ... | [INFO] [stderr] 48 | | }, [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let (Ok(timestamp), Ok(tag_id), Ok(battery_level), Ok(temperature)) = (timestamp, tag_id, battery_level, temperature) { [INFO] [stderr] 36 | let body = format!("sensor,tag={} temperature={},batteryLevel={} {}", [INFO] [stderr] 37 | tag_id, temperature, battery_level, timestamp); [INFO] [stderr] 38 | log!("{}", body); [INFO] [stderr] 39 | [INFO] [stderr] 40 | let res = self.client [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:42:78 [INFO] [stderr] | [INFO] [stderr] 42 | let jsonpaths: Vec = matches.value_of("JSONPATH").unwrap().split(",").map(String::from).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | fn handle_client<'a, 'b>(mut stream: TcpStream, app: &Application) -> Result<(), ZinkError<'a>> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:108:46 [INFO] [stderr] | [INFO] [stderr] 108 | x.payload().subscribes().into_iter().map(sub_to_ack).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.34s [INFO] running `"docker" "inspect" "13dfc18adfb1f92522f1d9663e1459362a2c2c4107bdc34b693209f7de2502fb"` [INFO] running `"docker" "rm" "-f" "13dfc18adfb1f92522f1d9663e1459362a2c2c4107bdc34b693209f7de2502fb"` [INFO] [stdout] 13dfc18adfb1f92522f1d9663e1459362a2c2c4107bdc34b693209f7de2502fb