[INFO] updating cached repository rappet/rust-pixelflut [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rappet/rust-pixelflut [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rappet/rust-pixelflut" "work/ex/clippy-test-run/sources/stable/gh/rappet/rust-pixelflut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rappet/rust-pixelflut'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rappet/rust-pixelflut" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rappet/rust-pixelflut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rappet/rust-pixelflut'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f730a33160112a356480d55527f0402b951f6167 [INFO] sha for GitHub repo rappet/rust-pixelflut: f730a33160112a356480d55527f0402b951f6167 [INFO] validating manifest of rappet/rust-pixelflut on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rappet/rust-pixelflut on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rappet/rust-pixelflut [INFO] finished frobbing rappet/rust-pixelflut [INFO] frobbed toml for rappet/rust-pixelflut written to work/ex/clippy-test-run/sources/stable/gh/rappet/rust-pixelflut/Cargo.toml [INFO] started frobbing rappet/rust-pixelflut [INFO] finished frobbing rappet/rust-pixelflut [INFO] frobbed toml for rappet/rust-pixelflut written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rappet/rust-pixelflut/Cargo.toml [INFO] crate rappet/rust-pixelflut has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rappet/rust-pixelflut against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rappet/rust-pixelflut:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd6a6e36937af7372a089e3206de59db3975cfab9c0856038a282c28a44f17f4 [INFO] running `"docker" "start" "-a" "bd6a6e36937af7372a089e3206de59db3975cfab9c0856038a282c28a44f17f4"` [INFO] [stderr] Compiling cc v1.0.8 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking pixelflut v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pixel.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn normalized(&self) -> (u8, u8, u8, u8) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pixel.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn normalized(&self) -> (u8, u8, u8, u8) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.38s [INFO] running `"docker" "inspect" "bd6a6e36937af7372a089e3206de59db3975cfab9c0856038a282c28a44f17f4"` [INFO] running `"docker" "rm" "-f" "bd6a6e36937af7372a089e3206de59db3975cfab9c0856038a282c28a44f17f4"` [INFO] [stdout] bd6a6e36937af7372a089e3206de59db3975cfab9c0856038a282c28a44f17f4