[INFO] updating cached repository rap2hpoutre/starfield [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rap2hpoutre/starfield [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rap2hpoutre/starfield" "work/ex/clippy-test-run/sources/stable/gh/rap2hpoutre/starfield"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rap2hpoutre/starfield'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rap2hpoutre/starfield" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rap2hpoutre/starfield"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rap2hpoutre/starfield'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3bc007c38cb73d13f933b88b8a4a783da8c8237f [INFO] sha for GitHub repo rap2hpoutre/starfield: 3bc007c38cb73d13f933b88b8a4a783da8c8237f [INFO] validating manifest of rap2hpoutre/starfield on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rap2hpoutre/starfield on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rap2hpoutre/starfield [INFO] finished frobbing rap2hpoutre/starfield [INFO] frobbed toml for rap2hpoutre/starfield written to work/ex/clippy-test-run/sources/stable/gh/rap2hpoutre/starfield/Cargo.toml [INFO] started frobbing rap2hpoutre/starfield [INFO] finished frobbing rap2hpoutre/starfield [INFO] frobbed toml for rap2hpoutre/starfield written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rap2hpoutre/starfield/Cargo.toml [INFO] crate rap2hpoutre/starfield has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rap2hpoutre/starfield against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rap2hpoutre/starfield:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c376d09067b73aaf7ca5d34729bc880e0da17801649b9fd54a2e5a687f13dace [INFO] running `"docker" "start" "-a" "c376d09067b73aaf7ca5d34729bc880e0da17801649b9fd54a2e5a687f13dace"` [INFO] [stderr] Checking lazy_static v0.2.5 [INFO] [stderr] Checking piston-float v0.2.0 [INFO] [stderr] Checking piston-shaders_graphics2d v0.2.1 [INFO] [stderr] Checking gfx_core v0.5.1 [INFO] [stderr] Checking arrayvec v0.3.22 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking x11-dl v2.12.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking piston-viewport v0.2.0 [INFO] [stderr] Checking vecmath v0.2.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking piston2d-graphics v0.19.0 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking gfx v0.13.0 [INFO] [stderr] Checking gfx_device_gl v0.12.0 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking starfield v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | z: rand::thread_rng().gen_range(1, MAX_DEPTH) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rand::thread_rng().gen_range(1, MAX_DEPTH))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | rand::thread_rng().gen_range(XY_RANGE * -1, XY_RANGE) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rand::thread_rng().gen_range(XY_RANGE * -1, XY_RANGE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | rand::thread_rng().gen_range(XY_RANGE * -1, XY_RANGE) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | star.z = MAX_DEPTH as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_DEPTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:44 [INFO] [stderr] | [INFO] [stderr] 57 | let px: f64 = star.x * k + half_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | let py: f64 = star.y * k + half_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:39 [INFO] [stderr] | [INFO] [stderr] 60 | if px >= 0.0 && px <= WIDTH as f64 && py >= 0.0 && py <= HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:74 [INFO] [stderr] | [INFO] [stderr] 60 | if px >= 0.0 && px <= WIDTH as f64 && py >= 0.0 && py <= HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | z: rand::thread_rng().gen_range(1, MAX_DEPTH) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rand::thread_rng().gen_range(1, MAX_DEPTH))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | rand::thread_rng().gen_range(XY_RANGE * -1, XY_RANGE) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rand::thread_rng().gen_range(XY_RANGE * -1, XY_RANGE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | rand::thread_rng().gen_range(XY_RANGE * -1, XY_RANGE) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | star.z = MAX_DEPTH as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(MAX_DEPTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:44 [INFO] [stderr] | [INFO] [stderr] 57 | let px: f64 = star.x * k + half_width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | let py: f64 = star.y * k + half_height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(half_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:39 [INFO] [stderr] | [INFO] [stderr] 60 | if px >= 0.0 && px <= WIDTH as f64 && py >= 0.0 && py <= HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:74 [INFO] [stderr] | [INFO] [stderr] 60 | if px >= 0.0 && px <= WIDTH as f64 && py >= 0.0 && py <= HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.82s [INFO] running `"docker" "inspect" "c376d09067b73aaf7ca5d34729bc880e0da17801649b9fd54a2e5a687f13dace"` [INFO] running `"docker" "rm" "-f" "c376d09067b73aaf7ca5d34729bc880e0da17801649b9fd54a2e5a687f13dace"` [INFO] [stdout] c376d09067b73aaf7ca5d34729bc880e0da17801649b9fd54a2e5a687f13dace