[INFO] updating cached repository ramsir3/OpenPlatformFighter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ramsir3/OpenPlatformFighter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ramsir3/OpenPlatformFighter" "work/ex/clippy-test-run/sources/stable/gh/ramsir3/OpenPlatformFighter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ramsir3/OpenPlatformFighter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ramsir3/OpenPlatformFighter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramsir3/OpenPlatformFighter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramsir3/OpenPlatformFighter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f9af02e5b7642e4f7ed542b3be92ddf358ef89a1 [INFO] sha for GitHub repo ramsir3/OpenPlatformFighter: f9af02e5b7642e4f7ed542b3be92ddf358ef89a1 [INFO] validating manifest of ramsir3/OpenPlatformFighter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ramsir3/OpenPlatformFighter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ramsir3/OpenPlatformFighter [INFO] finished frobbing ramsir3/OpenPlatformFighter [INFO] frobbed toml for ramsir3/OpenPlatformFighter written to work/ex/clippy-test-run/sources/stable/gh/ramsir3/OpenPlatformFighter/Cargo.toml [INFO] started frobbing ramsir3/OpenPlatformFighter [INFO] finished frobbing ramsir3/OpenPlatformFighter [INFO] frobbed toml for ramsir3/OpenPlatformFighter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramsir3/OpenPlatformFighter/Cargo.toml [INFO] crate ramsir3/OpenPlatformFighter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ramsir3/OpenPlatformFighter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ramsir3/OpenPlatformFighter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4079283c766c59c392e913e06f10d2dd4a2b6092a99628d080479747aa0b6ae [INFO] running `"docker" "start" "-a" "d4079283c766c59c392e913e06f10d2dd4a2b6092a99628d080479747aa0b6ae"` [INFO] [stderr] Compiling proc-macro2 v0.4.21 [INFO] [stderr] Checking piston-viewport v0.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling enum-display-derive v0.1.0 [INFO] [stderr] Checking rusttype v0.7.2 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking smithay-client-toolkit v0.4.1 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.54.0 [INFO] [stderr] Checking piston_window v0.85.0 [INFO] [stderr] Checking open_platform_fighter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:37:49 [INFO] [stderr] | [INFO] [stderr] 37 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `faf_frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:42:49 [INFO] [stderr] | [INFO] [stderr] 42 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `faf_frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/animation.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/animation.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | partials: partials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `partials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/animation.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | frametypes: frametypes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frametypes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/fighter.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | aa: aa, [INFO] [stderr] | ^^^^^^ help: replace it with: `aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/player.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | f: f, [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/player.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | c: c, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fighters/test/test.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | aa: aa, [INFO] [stderr] | ^^^^^^ help: replace it with: `aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:37:49 [INFO] [stderr] | [INFO] [stderr] 37 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `faf_frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/frame.rs:42:49 [INFO] [stderr] | [INFO] [stderr] 42 | cur_frame: 0, end_frame: end_frame, faf_frame: faf_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `faf_frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/animation.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/animation.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | partials: partials, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `partials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/animation.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | frametypes: frametypes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frametypes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/fighter.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | aa: aa, [INFO] [stderr] | ^^^^^^ help: replace it with: `aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/player.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | f: f, [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/player.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | c: c, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fighters/test/test.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | aa: aa, [INFO] [stderr] | ^^^^^^ help: replace it with: `aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/fighter.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/fighters/test/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod test; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/fighter.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/fighters/test/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod test; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: field is never used: `acc` [INFO] [stderr] --> src/driver/player.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | acc: Vec2d, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `controls2` [INFO] [stderr] --> src/driver/controls.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn controls2() -> Controls { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/common/state.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | self.0 = self.0 | o.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.0 |= o.into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/common/state.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | self.0 = self.0 & !o.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.0 &= !o.into()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/common/state.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | (!(self.0 & oo != 0)) && (self.1 & oo != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0 & oo == 0 && (self.1 & oo != 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.0` [INFO] [stderr] --> src/common/state.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | (self.0 & !0) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | / match i { [INFO] [stderr] 33 | | Input::Button(b) => { [INFO] [stderr] 34 | | p1.update_inputs(&b) [INFO] [stderr] 35 | | }, [INFO] [stderr] 36 | | _ => {} [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Input::Button(b) = i { [INFO] [stderr] 33 | p1.update_inputs(&b) [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `acc` [INFO] [stderr] --> src/driver/player.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | acc: Vec2d, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `controls2` [INFO] [stderr] --> src/driver/controls.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn controls2() -> Controls { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/common/state.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | self.0 = self.0 | o.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.0 |= o.into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/common/state.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | self.0 = self.0 & !o.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.0 &= !o.into()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/common/state.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | (!(self.0 & oo != 0)) && (self.1 & oo != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0 & oo == 0 && (self.1 & oo != 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.0` [INFO] [stderr] --> src/common/state.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | (self.0 & !0) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | / match i { [INFO] [stderr] 33 | | Input::Button(b) => { [INFO] [stderr] 34 | | p1.update_inputs(&b) [INFO] [stderr] 35 | | }, [INFO] [stderr] 36 | | _ => {} [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Input::Button(b) = i { [INFO] [stderr] 33 | p1.update_inputs(&b) [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 14s [INFO] running `"docker" "inspect" "d4079283c766c59c392e913e06f10d2dd4a2b6092a99628d080479747aa0b6ae"` [INFO] running `"docker" "rm" "-f" "d4079283c766c59c392e913e06f10d2dd4a2b6092a99628d080479747aa0b6ae"` [INFO] [stdout] d4079283c766c59c392e913e06f10d2dd4a2b6092a99628d080479747aa0b6ae