[INFO] updating cached repository ramn/advent-of-code-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ramn/advent-of-code-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ramn/advent-of-code-rs" "work/ex/clippy-test-run/sources/stable/gh/ramn/advent-of-code-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ramn/advent-of-code-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ramn/advent-of-code-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/advent-of-code-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/advent-of-code-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1c725e79652cf1346c107378a586032a0427de7d [INFO] sha for GitHub repo ramn/advent-of-code-rs: 1c725e79652cf1346c107378a586032a0427de7d [INFO] validating manifest of ramn/advent-of-code-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ramn/advent-of-code-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ramn/advent-of-code-rs [INFO] finished frobbing ramn/advent-of-code-rs [INFO] frobbed toml for ramn/advent-of-code-rs written to work/ex/clippy-test-run/sources/stable/gh/ramn/advent-of-code-rs/Cargo.toml [INFO] started frobbing ramn/advent-of-code-rs [INFO] finished frobbing ramn/advent-of-code-rs [INFO] frobbed toml for ramn/advent-of-code-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/advent-of-code-rs/Cargo.toml [INFO] crate ramn/advent-of-code-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ramn/advent-of-code-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ramn/advent-of-code-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 503d915b62179d13bbe133dbc1d0b130666bd1e82c524a9f54bce69a5123570c [INFO] running `"docker" "start" "-a" "503d915b62179d13bbe133dbc1d0b130666bd1e82c524a9f54bce69a5123570c"` [INFO] [stderr] Checking md5 v0.2.1 [INFO] [stderr] Checking advent-of-code-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_01.rs:105:47 [INFO] [stderr] | [INFO] [stderr] 105 | .map(|col| Coord { row: this.row, col: col }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_01.rs:109:32 [INFO] [stderr] | [INFO] [stderr] 109 | .map(|row| Coord { row: row, col: this.col }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_01.rs:105:47 [INFO] [stderr] | [INFO] [stderr] 105 | .map(|col| Coord { row: this.row, col: col }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_01.rs:109:32 [INFO] [stderr] | [INFO] [stderr] 109 | .map(|row| Coord { row: row, col: this.col }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_01.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = "R4, R5, L5, L5, L3, R2, R1, R1, L5, R5, R2, \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_01.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | manhattan_distance [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_01.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | (steps[0] - steps[2]).abs() + (steps[1] - steps[3]).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_02.rs:140:15 [INFO] [stderr] | [INFO] [stderr] 140 | const INPUT: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_03.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("resources/day_03_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_03.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | valid_triangle [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_03.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | let valid_triangle = numbers.iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 32 | | .zip(numbers.iter().cycle().skip(1)) [INFO] [stderr] 33 | | .zip(numbers.iter().cycle().skip(2)) [INFO] [stderr] 34 | | .all(|((a, b), &c)| { [INFO] [stderr] 35 | | a + b > c [INFO] [stderr] 36 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_04.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("resources/day_04_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_05.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | const INPUT: &'static str = "uqwqemis"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_05.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | const PAT: &'static str = "00000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_05.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_05.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | let out = (0_usize..) [INFO] [stderr] | _______________^ [INFO] [stderr] 11 | | .take(100000000) [INFO] [stderr] 12 | | .map(|i| hex(&compute(i)[0..3])) [INFO] [stderr] 13 | | .filter(|s| &s[0..5] == PAT) [INFO] [stderr] 14 | | .map(|s| s.chars().nth(5).unwrap()) [INFO] [stderr] 15 | | .take(8) [INFO] [stderr] 16 | | .collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_05.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | .take(100000000) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_05.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | .take(100000000) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_06.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("resources/day_06_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_07.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("resources/day_07_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_07.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_07.rs:99:15 [INFO] [stderr] | [INFO] [stderr] 99 | let out = INPUT.lines().map(|line| { [INFO] [stderr] | _______________^ [INFO] [stderr] 100 | | let parts = { [INFO] [stderr] 101 | | let (last_elem, mut memo) = [INFO] [stderr] 102 | | line.chars().fold((vec![], vec![]), |mut memo, elem| { [INFO] [stderr] ... | [INFO] [stderr] 126 | | }).1 [INFO] [stderr] 127 | | }).collect(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_08.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("resources/day_08_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_09.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("resources/day_09_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_12.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("resources/day_12_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_01.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = "R4, R5, L5, L5, L3, R2, R1, R1, L5, R5, R2, \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_01.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | manhattan_distance [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_01.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | (steps[0] - steps[2]).abs() + (steps[1] - steps[3]).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_02.rs:140:15 [INFO] [stderr] | [INFO] [stderr] 140 | const INPUT: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_03.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("resources/day_03_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_03.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | valid_triangle [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_03.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | let valid_triangle = numbers.iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 32 | | .zip(numbers.iter().cycle().skip(1)) [INFO] [stderr] 33 | | .zip(numbers.iter().cycle().skip(2)) [INFO] [stderr] 34 | | .all(|((a, b), &c)| { [INFO] [stderr] 35 | | a + b > c [INFO] [stderr] 36 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_04.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("resources/day_04_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_05.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | const INPUT: &'static str = "uqwqemis"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_05.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | const PAT: &'static str = "00000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_05.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_05.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | let out = (0_usize..) [INFO] [stderr] | _______________^ [INFO] [stderr] 11 | | .take(100000000) [INFO] [stderr] 12 | | .map(|i| hex(&compute(i)[0..3])) [INFO] [stderr] 13 | | .filter(|s| &s[0..5] == PAT) [INFO] [stderr] 14 | | .map(|s| s.chars().nth(5).unwrap()) [INFO] [stderr] 15 | | .take(8) [INFO] [stderr] 16 | | .collect(); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_05.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | .take(100000000) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_05.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | .take(100000000) [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_06.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("resources/day_06_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_07.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | const INPUT: &'static str = include_str!("resources/day_07_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_07.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_07.rs:99:15 [INFO] [stderr] | [INFO] [stderr] 99 | let out = INPUT.lines().map(|line| { [INFO] [stderr] | _______________^ [INFO] [stderr] 100 | | let parts = { [INFO] [stderr] 101 | | let (last_elem, mut memo) = [INFO] [stderr] 102 | | line.chars().fold((vec![], vec![]), |mut memo, elem| { [INFO] [stderr] ... | [INFO] [stderr] 126 | | }).1 [INFO] [stderr] 127 | | }).collect(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_08.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const INPUT: &'static str = include_str!("resources/day_08_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_09.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("resources/day_09_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/day_12.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | const INPUT: &'static str = include_str!("resources/day_12_input.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day_09.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let mut chars = &mut INPUT.chars(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_01.rs:15:30 [INFO] [stderr] | [INFO] [stderr] 15 | let folded = INPUT.split(",").map(|s| s.trim()) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_01.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | let goal_coord = INPUT.split(",").map(|s| s.trim()) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_01.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | (a..b+1).collect() [INFO] [stderr] | ^^^^^^^^ help: use: `(a..=b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_01.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | (b..a+1).rev().collect() [INFO] [stderr] | ^^^^^^^^ help: use: `(b..=a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `.extend(_.chars())` [INFO] [stderr] --> src/day_02.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | keys.extend(next_pad.get_data().chars()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `keys.push_str(next_pad.get_data())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_extend_chars)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_extend_chars [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/day_02.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_data<'a>(&'a self) -> &'a str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/day_02.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / fn get_data<'a>(&'a self) -> &'a str { [INFO] [stderr] 71 | | let ix = self.get_ix(); [INFO] [stderr] 72 | | let pad = "789456123"; [INFO] [stderr] 73 | | &pad[ix..ix+1] [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_02.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | &pad[ix..ix+1] [INFO] [stderr] | ^^^^^^^^ help: use: `ix..=ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/day_02.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / fn get_data<'a>(&'a self) -> &'a str { [INFO] [stderr] 107 | | let ix = self.get_ix(); [INFO] [stderr] 108 | | let pad = " D ABC 56789 234 1 "; [INFO] [stderr] 109 | | &pad[ix..ix + 1] [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_02.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | &pad[ix..ix + 1] [INFO] [stderr] | ^^^^^^^^^^ help: use: `ix..=ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/day_03.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | solve(transposed.chunks(3).map(|slice| Vec::from(slice)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Vec::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day_04.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let len: u32 = (b'z' - b'a' + 1) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(b'z' - b'a' + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day_04.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let normalized: u32 = (c - b'a') as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day_04.rs:21:57 [INFO] [stderr] | [INFO] [stderr] 21 | let next = ((entry.sector_id + normalized) % len) + b'a' as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/day_04.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | decrypted.into_iter().filter(|pair| pair.0.contains("pole")) [INFO] [stderr] | _____^ [INFO] [stderr] 28 | | .next().unwrap() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|pair| pair.0.contains("pole")).next()` with `find(|pair| pair.0.contains("pole"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_04.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | let tokens: Vec = line.split("-").map(|x|x.to_owned()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_04.rs:46:56 [INFO] [stderr] | [INFO] [stderr] 46 | let mut itr = tokens.last().unwrap().split("[") [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day_05.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / if memo.contains_key(&pos) { [INFO] [stderr] 35 | | Some(()) [INFO] [stderr] 36 | | } else { [INFO] [stderr] 37 | | memo.insert(pos, c); [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ help: consider using: `memo.entry(pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/day_05.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | fn compute<'a>(i: usize) -> [u8; 16] { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_06.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | &data[ix..ix+1] [INFO] [stderr] | ^^^^^^^^ help: use: `ix..=ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day_07.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | memo.entry(key).or_insert(HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day_07.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | .map(|chars| chars.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_08.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | let mut size = tokens[1].split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day_09.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let mut chars = &mut INPUT.chars(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_01.rs:15:30 [INFO] [stderr] | [INFO] [stderr] 15 | let folded = INPUT.split(",").map(|s| s.trim()) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_01.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | let goal_coord = INPUT.split(",").map(|s| s.trim()) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_01.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | (a..b+1).collect() [INFO] [stderr] | ^^^^^^^^ help: use: `(a..=b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_01.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | (b..a+1).rev().collect() [INFO] [stderr] | ^^^^^^^^ help: use: `(b..=a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `.extend(_.chars())` [INFO] [stderr] --> src/day_02.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | keys.extend(next_pad.get_data().chars()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `keys.push_str(next_pad.get_data())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_extend_chars)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_extend_chars [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/day_02.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_data<'a>(&'a self) -> &'a str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/day_02.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / fn get_data<'a>(&'a self) -> &'a str { [INFO] [stderr] 71 | | let ix = self.get_ix(); [INFO] [stderr] 72 | | let pad = "789456123"; [INFO] [stderr] 73 | | &pad[ix..ix+1] [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_02.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | &pad[ix..ix+1] [INFO] [stderr] | ^^^^^^^^ help: use: `ix..=ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/day_02.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / fn get_data<'a>(&'a self) -> &'a str { [INFO] [stderr] 107 | | let ix = self.get_ix(); [INFO] [stderr] 108 | | let pad = " D ABC 56789 234 1 "; [INFO] [stderr] 109 | | &pad[ix..ix + 1] [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_02.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | &pad[ix..ix + 1] [INFO] [stderr] | ^^^^^^^^^^ help: use: `ix..=ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/day_03.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | solve(transposed.chunks(3).map(|slice| Vec::from(slice)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Vec::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day_04.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let len: u32 = (b'z' - b'a' + 1) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(b'z' - b'a' + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day_04.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let normalized: u32 = (c - b'a') as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/day_04.rs:21:57 [INFO] [stderr] | [INFO] [stderr] 21 | let next = ((entry.sector_id + normalized) % len) + b'a' as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/day_04.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | decrypted.into_iter().filter(|pair| pair.0.contains("pole")) [INFO] [stderr] | _____^ [INFO] [stderr] 28 | | .next().unwrap() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|pair| pair.0.contains("pole")).next()` with `find(|pair| pair.0.contains("pole"))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_04.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | let tokens: Vec = line.split("-").map(|x|x.to_owned()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_04.rs:46:56 [INFO] [stderr] | [INFO] [stderr] 46 | let mut itr = tokens.last().unwrap().split("[") [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day_05.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / if memo.contains_key(&pos) { [INFO] [stderr] 35 | | Some(()) [INFO] [stderr] 36 | | } else { [INFO] [stderr] 37 | | memo.insert(pos, c); [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ help: consider using: `memo.entry(pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/day_05.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | fn compute<'a>(i: usize) -> [u8; 16] { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_06.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | &data[ix..ix+1] [INFO] [stderr] | ^^^^^^^^ help: use: `ix..=ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day_07.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | memo.entry(key).or_insert(HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day_07.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | .map(|chars| chars.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_08.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | let mut size = tokens[1].split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.06s [INFO] running `"docker" "inspect" "503d915b62179d13bbe133dbc1d0b130666bd1e82c524a9f54bce69a5123570c"` [INFO] running `"docker" "rm" "-f" "503d915b62179d13bbe133dbc1d0b130666bd1e82c524a9f54bce69a5123570c"` [INFO] [stdout] 503d915b62179d13bbe133dbc1d0b130666bd1e82c524a9f54bce69a5123570c