[INFO] updating cached repository rami999999999/Lang_detector_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rami999999999/Lang_detector_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rami999999999/Lang_detector_rust" "work/ex/clippy-test-run/sources/stable/gh/rami999999999/Lang_detector_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rami999999999/Lang_detector_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rami999999999/Lang_detector_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rami999999999/Lang_detector_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rami999999999/Lang_detector_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a118c99d2e1c957da17d2d3bddc4e4d351b76150 [INFO] sha for GitHub repo rami999999999/Lang_detector_rust: a118c99d2e1c957da17d2d3bddc4e4d351b76150 [INFO] validating manifest of rami999999999/Lang_detector_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rami999999999/Lang_detector_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rami999999999/Lang_detector_rust [INFO] finished frobbing rami999999999/Lang_detector_rust [INFO] frobbed toml for rami999999999/Lang_detector_rust written to work/ex/clippy-test-run/sources/stable/gh/rami999999999/Lang_detector_rust/Cargo.toml [INFO] started frobbing rami999999999/Lang_detector_rust [INFO] finished frobbing rami999999999/Lang_detector_rust [INFO] frobbed toml for rami999999999/Lang_detector_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rami999999999/Lang_detector_rust/Cargo.toml [INFO] crate rami999999999/Lang_detector_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rami999999999/Lang_detector_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rami999999999/Lang_detector_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cc902dc177e720a9d99c6aafa5bbab390c0b075be90a927dbc6e0ad12374feb [INFO] running `"docker" "start" "-a" "7cc902dc177e720a9d99c6aafa5bbab390c0b075be90a927dbc6e0ad12374feb"` [INFO] [stderr] Checking lang_detector_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/main.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for i in (0 .. capacity){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pt_total` is never read [INFO] [stderr] --> src/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | let mut pt_total=0.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `es_total` is never read [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | let mut es_total=0.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fr_total` is never read [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | let mut fr_total=0.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in linha.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | for letra in linha.chars() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | total=total+split_2.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += split_2.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | *values=*values/total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*values /= total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | fn calc_stat(input: &Vec, hash: &HashMap) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | total=hash[i]*total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `total *= hash[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | io::stdin().read_line(&mut program_input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if data.len()>0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/main.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for i in (0 .. capacity){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pt_total` is never read [INFO] [stderr] --> src/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | let mut pt_total=0.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `es_total` is never read [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | let mut es_total=0.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fr_total` is never read [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | let mut fr_total=0.0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in linha.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | for letra in linha.chars() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | total=total+split_2.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += split_2.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | *values=*values/total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*values /= total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | fn calc_stat(input: &Vec, hash: &HashMap) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | total=hash[i]*total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `total *= hash[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | io::stdin().read_line(&mut program_input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if data.len()>0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "7cc902dc177e720a9d99c6aafa5bbab390c0b075be90a927dbc6e0ad12374feb"` [INFO] running `"docker" "rm" "-f" "7cc902dc177e720a9d99c6aafa5bbab390c0b075be90a927dbc6e0ad12374feb"` [INFO] [stdout] 7cc902dc177e720a9d99c6aafa5bbab390c0b075be90a927dbc6e0ad12374feb