[INFO] updating cached repository ralexstokes/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ralexstokes/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ralexstokes/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/ralexstokes/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ralexstokes/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ralexstokes/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ralexstokes/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ralexstokes/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 848f96d222733573f97e7bdeb9cea7036f2c3e20 [INFO] sha for GitHub repo ralexstokes/advent-of-code-2018: 848f96d222733573f97e7bdeb9cea7036f2c3e20 [INFO] validating manifest of ralexstokes/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ralexstokes/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ralexstokes/advent-of-code-2018 [INFO] finished frobbing ralexstokes/advent-of-code-2018 [INFO] frobbed toml for ralexstokes/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/ralexstokes/advent-of-code-2018/Cargo.toml [INFO] started frobbing ralexstokes/advent-of-code-2018 [INFO] finished frobbing ralexstokes/advent-of-code-2018 [INFO] frobbed toml for ralexstokes/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ralexstokes/advent-of-code-2018/Cargo.toml [INFO] crate ralexstokes/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ralexstokes/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ralexstokes/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ebf50c0f87f44c776c22d8f1336f30aa7873ffcd30f3b19605c44ec148dab6e1 [INFO] running `"docker" "start" "-a" "ebf50c0f87f44c776c22d8f1336f30aa7873ffcd30f3b19605c44ec148dab6e1"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_3.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | assert_eq!(contentious_square_inches, 118539) [INFO] [stderr] | ^^^^^^ help: consider: `118_539` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sleeps` [INFO] [stderr] --> src/day_4.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | let sleeps = current_guard.minutes_asleep.len(); [INFO] [stderr] | ^^^^^^ help: consider using `_sleeps` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sleeps` [INFO] [stderr] --> src/day_4.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let sleeps = current_guard.minutes_asleep.len(); [INFO] [stderr] | ^^^^^^ help: consider using `_sleeps` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day_3.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | / match col.len() { [INFO] [stderr] 91 | | 1 => { [INFO] [stderr] 92 | | let claim = col[0]; [INFO] [stderr] 93 | | if self.has_no_conflicts(claim) && !claims.contains(&claim) { [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let 1 = col.len() { [INFO] [stderr] 91 | let claim = col[0]; [INFO] [stderr] 92 | if self.has_no_conflicts(claim) && !claims.contains(&claim) { [INFO] [stderr] 93 | claims.push(claim); [INFO] [stderr] 94 | // remove the next line if you want to find them all... [INFO] [stderr] 95 | break; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_4.rs:41:51 [INFO] [stderr] | [INFO] [stderr] 41 | fn add_sleep_record(&mut self, durations: &SleepRecord) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day_4.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if self.minutes_asleep.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.minutes_asleep.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day_4.rs:162:39 [INFO] [stderr] | [INFO] [stderr] 162 | EventType::WakesUp => match current_guard.as_mut() { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 163 | | Some(guard) => { [INFO] [stderr] 164 | | let span = (current_sleep.unwrap(), datetime); [INFO] [stderr] 165 | | guard.add_sleep(span) [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | None => {} [INFO] [stderr] 168 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | EventType::WakesUp => if let Some(guard) = current_guard.as_mut() { [INFO] [stderr] 163 | let span = (current_sleep.unwrap(), datetime); [INFO] [stderr] 164 | guard.add_sleep(span) [INFO] [stderr] 165 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.75s [INFO] running `"docker" "inspect" "ebf50c0f87f44c776c22d8f1336f30aa7873ffcd30f3b19605c44ec148dab6e1"` [INFO] running `"docker" "rm" "-f" "ebf50c0f87f44c776c22d8f1336f30aa7873ffcd30f3b19605c44ec148dab6e1"` [INFO] [stdout] ebf50c0f87f44c776c22d8f1336f30aa7873ffcd30f3b19605c44ec148dab6e1