[INFO] updating cached repository rainbowbismuth/git-descendants
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rainbowbismuth/git-descendants
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rainbowbismuth/git-descendants" "work/ex/clippy-test-run/sources/stable/gh/rainbowbismuth/git-descendants"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rainbowbismuth/git-descendants'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rainbowbismuth/git-descendants" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rainbowbismuth/git-descendants"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rainbowbismuth/git-descendants'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] db62dc11026d8b6b2bd650389682815c92d23faa
[INFO] sha for GitHub repo rainbowbismuth/git-descendants: db62dc11026d8b6b2bd650389682815c92d23faa
[INFO] validating manifest of rainbowbismuth/git-descendants on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rainbowbismuth/git-descendants on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rainbowbismuth/git-descendants
[INFO] finished frobbing rainbowbismuth/git-descendants
[INFO] frobbed toml for rainbowbismuth/git-descendants written to work/ex/clippy-test-run/sources/stable/gh/rainbowbismuth/git-descendants/Cargo.toml
[INFO] started frobbing rainbowbismuth/git-descendants
[INFO] finished frobbing rainbowbismuth/git-descendants
[INFO] frobbed toml for rainbowbismuth/git-descendants written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rainbowbismuth/git-descendants/Cargo.toml
[INFO] crate rainbowbismuth/git-descendants has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rainbowbismuth/git-descendants against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rainbowbismuth/git-descendants:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9e271eed3512ab0914264a84684d206b081282605186ef1b5309e09ebe48ddd4
[INFO] running `"docker" "start" "-a" "9e271eed3512ab0914264a84684d206b081282605186ef1b5309e09ebe48ddd4"`
[INFO] [stderr]    Compiling openssl-sys v0.9.26
[INFO] [stderr]     Checking clap v2.30.0
[INFO] [stderr]     Checking backtrace v0.3.5
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]    Compiling libssh2-sys v0.2.6
[INFO] [stderr]    Compiling curl-sys v0.4.1
[INFO] [stderr]    Compiling libgit2-sys v0.6.19
[INFO] [stderr]     Checking git2 v0.6.11
[INFO] [stderr]     Checking git-descendents v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/graph.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let ref mut node = self.graph.entry(node).or_insert(Node::new());
[INFO] [stderr]    |         ----^^^^^^^^^^^^------------------------------------------------- help: try: `let node = &mut self.graph.entry(node).or_insert(Node::new());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/graph.rs:89:51
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let ref mut node = self.graph.entry(node).or_insert(Node::new());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/graph.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 |         let ref mut node = self.graph.entry(parent).or_insert(Node::new());
[INFO] [stderr]    |         ----^^^^^^^^^^^^--------------------------------------------------- help: try: `let node = &mut self.graph.entry(parent).or_insert(Node::new());`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/graph.rs:94:53
[INFO] [stderr]    |
[INFO] [stderr] 94 |         let ref mut node = self.graph.entry(parent).or_insert(Node::new());
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:95:14
[INFO] [stderr]    |
[INFO] [stderr] 95 |             .ok_or(err_msg("REVISION not specified"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("REVISION not specified"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/graph.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let ref mut node = self.graph.entry(node).or_insert(Node::new());
[INFO] [stderr]    |         ----^^^^^^^^^^^^------------------------------------------------- help: try: `let node = &mut self.graph.entry(node).or_insert(Node::new());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/graph.rs:89:51
[INFO] [stderr]    |
[INFO] [stderr] 89 |         let ref mut node = self.graph.entry(node).or_insert(Node::new());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/graph.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 |         let ref mut node = self.graph.entry(parent).or_insert(Node::new());
[INFO] [stderr]    |         ----^^^^^^^^^^^^--------------------------------------------------- help: try: `let node = &mut self.graph.entry(parent).or_insert(Node::new());`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/graph.rs:94:53
[INFO] [stderr]    |
[INFO] [stderr] 94 |         let ref mut node = self.graph.entry(parent).or_insert(Node::new());
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:95:14
[INFO] [stderr]    |
[INFO] [stderr] 95 |             .ok_or(err_msg("REVISION not specified"))?;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("REVISION not specified"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 16s
[INFO] running `"docker" "inspect" "9e271eed3512ab0914264a84684d206b081282605186ef1b5309e09ebe48ddd4"`
[INFO] running `"docker" "rm" "-f" "9e271eed3512ab0914264a84684d206b081282605186ef1b5309e09ebe48ddd4"`
[INFO] [stdout] 9e271eed3512ab0914264a84684d206b081282605186ef1b5309e09ebe48ddd4