[INFO] updating cached repository rahulgurnani/git-pull-comments
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rahulgurnani/git-pull-comments
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rahulgurnani/git-pull-comments" "work/ex/clippy-test-run/sources/stable/gh/rahulgurnani/git-pull-comments"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rahulgurnani/git-pull-comments'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rahulgurnani/git-pull-comments" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rahulgurnani/git-pull-comments"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rahulgurnani/git-pull-comments'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 554e97f06b98e2891c350bb13db1c796529fb74a
[INFO] sha for GitHub repo rahulgurnani/git-pull-comments: 554e97f06b98e2891c350bb13db1c796529fb74a
[INFO] validating manifest of rahulgurnani/git-pull-comments on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rahulgurnani/git-pull-comments on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rahulgurnani/git-pull-comments
[INFO] finished frobbing rahulgurnani/git-pull-comments
[INFO] frobbed toml for rahulgurnani/git-pull-comments written to work/ex/clippy-test-run/sources/stable/gh/rahulgurnani/git-pull-comments/Cargo.toml
[INFO] started frobbing rahulgurnani/git-pull-comments
[INFO] finished frobbing rahulgurnani/git-pull-comments
[INFO] frobbed toml for rahulgurnani/git-pull-comments written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rahulgurnani/git-pull-comments/Cargo.toml
[INFO] crate rahulgurnani/git-pull-comments has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rahulgurnani/git-pull-comments against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rahulgurnani/git-pull-comments:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d6a3ac5f65e137571d87d3d00a44346fa712b5875d0fdb7ba021dc0ba0907239
[INFO] running `"docker" "start" "-a" "d6a3ac5f65e137571d87d3d00a44346fa712b5875d0fdb7ba021dc0ba0907239"`
[INFO] [stderr]    Compiling libz-sys v1.0.24
[INFO] [stderr]    Compiling libssh2-sys v0.2.11
[INFO] [stderr]    Compiling curl-sys v0.4.13
[INFO] [stderr]    Compiling libgit2-sys v0.7.10
[INFO] [stderr]     Checking git2 v0.7.5
[INFO] [stderr]     Checking git-pull-comments v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |         Ok(r) => return r.url().unwrap().to_string(),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r.url().unwrap().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |         Ok(r) => return r.url().unwrap().to_string(),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r.url().unwrap().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / fn get_remote<'a>(repo: &'a git2::Repository) -> String {
[INFO] [stderr] 10 | |     let res = repo.find_remote("origin");
[INFO] [stderr] 11 | |     match res {
[INFO] [stderr] 12 | |         Ok(r) => return r.url().unwrap().to_string(),
[INFO] [stderr] 13 | |         Err(_e) => panic!("Can't find remote"),
[INFO] [stderr] 14 | |     };
[INFO] [stderr] 15 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / fn get_remote<'a>(repo: &'a git2::Repository) -> String {
[INFO] [stderr] 10 | |     let res = repo.find_remote("origin");
[INFO] [stderr] 11 | |     match res {
[INFO] [stderr] 12 | |         Ok(r) => return r.url().unwrap().to_string(),
[INFO] [stderr] 13 | |         Err(_e) => panic!("Can't find remote"),
[INFO] [stderr] 14 | |     };
[INFO] [stderr] 15 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 52.33s
[INFO] running `"docker" "inspect" "d6a3ac5f65e137571d87d3d00a44346fa712b5875d0fdb7ba021dc0ba0907239"`
[INFO] running `"docker" "rm" "-f" "d6a3ac5f65e137571d87d3d00a44346fa712b5875d0fdb7ba021dc0ba0907239"`
[INFO] [stdout] d6a3ac5f65e137571d87d3d00a44346fa712b5875d0fdb7ba021dc0ba0907239