[INFO] updating cached repository radupopescu/session-traits [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/radupopescu/session-traits [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/radupopescu/session-traits" "work/ex/clippy-test-run/sources/stable/gh/radupopescu/session-traits"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/radupopescu/session-traits'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/radupopescu/session-traits" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/radupopescu/session-traits"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/radupopescu/session-traits'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 585f6cd0765382d29ee711a0820f8bfe471b64cd [INFO] sha for GitHub repo radupopescu/session-traits: 585f6cd0765382d29ee711a0820f8bfe471b64cd [INFO] validating manifest of radupopescu/session-traits on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of radupopescu/session-traits on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing radupopescu/session-traits [INFO] finished frobbing radupopescu/session-traits [INFO] frobbed toml for radupopescu/session-traits written to work/ex/clippy-test-run/sources/stable/gh/radupopescu/session-traits/Cargo.toml [INFO] started frobbing radupopescu/session-traits [INFO] finished frobbing radupopescu/session-traits [INFO] frobbed toml for radupopescu/session-traits written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/radupopescu/session-traits/Cargo.toml [INFO] crate radupopescu/session-traits has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting radupopescu/session-traits against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/radupopescu/session-traits:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50b620fae22e454c72857083001049429f16d102494c0a9c45a545fb1f6654fb [INFO] running `"docker" "start" "-a" "50b620fae22e454c72857083001049429f16d102494c0a9c45a545fb1f6654fb"` [INFO] [stderr] Checking session-traits v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | rep [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let rep = rx.recv().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | rep [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let rep = rx.recv().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "50b620fae22e454c72857083001049429f16d102494c0a9c45a545fb1f6654fb"` [INFO] running `"docker" "rm" "-f" "50b620fae22e454c72857083001049429f16d102494c0a9c45a545fb1f6654fb"` [INFO] [stdout] 50b620fae22e454c72857083001049429f16d102494c0a9c45a545fb1f6654fb