[INFO] updating cached repository radekcieciwa/SwiftToPlantUMLConverter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/radekcieciwa/SwiftToPlantUMLConverter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/radekcieciwa/SwiftToPlantUMLConverter" "work/ex/clippy-test-run/sources/stable/gh/radekcieciwa/SwiftToPlantUMLConverter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/radekcieciwa/SwiftToPlantUMLConverter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/radekcieciwa/SwiftToPlantUMLConverter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/radekcieciwa/SwiftToPlantUMLConverter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/radekcieciwa/SwiftToPlantUMLConverter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc3d2e821ee446a0736f6ac6afac0f677f5e4add [INFO] sha for GitHub repo radekcieciwa/SwiftToPlantUMLConverter: cc3d2e821ee446a0736f6ac6afac0f677f5e4add [INFO] validating manifest of radekcieciwa/SwiftToPlantUMLConverter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of radekcieciwa/SwiftToPlantUMLConverter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing radekcieciwa/SwiftToPlantUMLConverter [INFO] finished frobbing radekcieciwa/SwiftToPlantUMLConverter [INFO] frobbed toml for radekcieciwa/SwiftToPlantUMLConverter written to work/ex/clippy-test-run/sources/stable/gh/radekcieciwa/SwiftToPlantUMLConverter/Cargo.toml [INFO] started frobbing radekcieciwa/SwiftToPlantUMLConverter [INFO] finished frobbing radekcieciwa/SwiftToPlantUMLConverter [INFO] frobbed toml for radekcieciwa/SwiftToPlantUMLConverter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/radekcieciwa/SwiftToPlantUMLConverter/Cargo.toml [INFO] crate radekcieciwa/SwiftToPlantUMLConverter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting radekcieciwa/SwiftToPlantUMLConverter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/radekcieciwa/SwiftToPlantUMLConverter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e42abaeb86c209bc0ccea4f03e448b8f5e77202cf06448334711eb60df3e529 [INFO] running `"docker" "start" "-a" "5e42abaeb86c209bc0ccea4f03e448b8f5e77202cf06448334711eb60df3e529"` [INFO] [stderr] Checking swift_to_plant_uml_converter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> main.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> main.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> main.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> main.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return String::from_utf8(output.stdout).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(output.stdout).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return String::from_utf8(output.stdout).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(output.stdout).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> main.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if inherited_types_unwrapped.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inherited_types_unwrapped.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / match kind { [INFO] [stderr] 75 | | &CLASS_KEY => Some(Token::Type(Kind::Class, name, inherited_items, Vec::new())), [INFO] [stderr] 76 | | &PROTOCOL_KEY => Some(Token::Type(Kind::Protocol, name, inherited_items, Vec::new())), [INFO] [stderr] 77 | | &VARIABLE_KEY => Some(Token::Object(Kind::Variable, name)), [INFO] [stderr] 78 | | &FUNCTION_KEY => Some(Token::Object(Kind::Function, name)), [INFO] [stderr] 79 | | _ => None, [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *kind { [INFO] [stderr] 75 | CLASS_KEY => Some(Token::Type(Kind::Class, name, inherited_items, Vec::new())), [INFO] [stderr] 76 | PROTOCOL_KEY => Some(Token::Type(Kind::Protocol, name, inherited_items, Vec::new())), [INFO] [stderr] 77 | VARIABLE_KEY => Some(Token::Object(Kind::Variable, name)), [INFO] [stderr] 78 | FUNCTION_KEY => Some(Token::Object(Kind::Function, name)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> main.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if inner_json_array_unwrapped.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inner_json_array_unwrapped.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match token { [INFO] [stderr] 127 | | Token::Type(kind, name, inherited_types, objects) => { [INFO] [stderr] 128 | | match kind { [INFO] [stderr] 129 | | Kind::Protocol => { print!("interface {}", name); }, [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => { }, [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | if let Token::Type(kind, name, inherited_types, objects) = token { [INFO] [stderr] 127 | match kind { [INFO] [stderr] 128 | Kind::Protocol => { print!("interface {}", name); }, [INFO] [stderr] 129 | Kind::Class => { print!("class {}", name); }, [INFO] [stderr] 130 | _ => {} [INFO] [stderr] 131 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> main.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | if objects.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!objects.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> main.rs:175:57 [INFO] [stderr] | [INFO] [stderr] 175 | let files_list: Vec<&str> = files_list_output.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> main.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if inherited_types_unwrapped.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inherited_types_unwrapped.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / match kind { [INFO] [stderr] 75 | | &CLASS_KEY => Some(Token::Type(Kind::Class, name, inherited_items, Vec::new())), [INFO] [stderr] 76 | | &PROTOCOL_KEY => Some(Token::Type(Kind::Protocol, name, inherited_items, Vec::new())), [INFO] [stderr] 77 | | &VARIABLE_KEY => Some(Token::Object(Kind::Variable, name)), [INFO] [stderr] 78 | | &FUNCTION_KEY => Some(Token::Object(Kind::Function, name)), [INFO] [stderr] 79 | | _ => None, [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *kind { [INFO] [stderr] 75 | CLASS_KEY => Some(Token::Type(Kind::Class, name, inherited_items, Vec::new())), [INFO] [stderr] 76 | PROTOCOL_KEY => Some(Token::Type(Kind::Protocol, name, inherited_items, Vec::new())), [INFO] [stderr] 77 | VARIABLE_KEY => Some(Token::Object(Kind::Variable, name)), [INFO] [stderr] 78 | FUNCTION_KEY => Some(Token::Object(Kind::Function, name)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> main.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if inner_json_array_unwrapped.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inner_json_array_unwrapped.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match token { [INFO] [stderr] 127 | | Token::Type(kind, name, inherited_types, objects) => { [INFO] [stderr] 128 | | match kind { [INFO] [stderr] 129 | | Kind::Protocol => { print!("interface {}", name); }, [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => { }, [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | if let Token::Type(kind, name, inherited_types, objects) = token { [INFO] [stderr] 127 | match kind { [INFO] [stderr] 128 | Kind::Protocol => { print!("interface {}", name); }, [INFO] [stderr] 129 | Kind::Class => { print!("class {}", name); }, [INFO] [stderr] 130 | _ => {} [INFO] [stderr] 131 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> main.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | if objects.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!objects.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> main.rs:175:57 [INFO] [stderr] | [INFO] [stderr] 175 | let files_list: Vec<&str> = files_list_output.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "5e42abaeb86c209bc0ccea4f03e448b8f5e77202cf06448334711eb60df3e529"` [INFO] running `"docker" "rm" "-f" "5e42abaeb86c209bc0ccea4f03e448b8f5e77202cf06448334711eb60df3e529"` [INFO] [stdout] 5e42abaeb86c209bc0ccea4f03e448b8f5e77202cf06448334711eb60df3e529