[INFO] updating cached repository r2p2/snake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/r2p2/snake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/r2p2/snake" "work/ex/clippy-test-run/sources/stable/gh/r2p2/snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/r2p2/snake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/r2p2/snake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/snake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e2ed895fe515402c4ebef9c34784fa9d5e95b938 [INFO] sha for GitHub repo r2p2/snake: e2ed895fe515402c4ebef9c34784fa9d5e95b938 [INFO] validating manifest of r2p2/snake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of r2p2/snake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing r2p2/snake [INFO] finished frobbing r2p2/snake [INFO] frobbed toml for r2p2/snake written to work/ex/clippy-test-run/sources/stable/gh/r2p2/snake/Cargo.toml [INFO] started frobbing r2p2/snake [INFO] finished frobbing r2p2/snake [INFO] frobbed toml for r2p2/snake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/snake/Cargo.toml [INFO] crate r2p2/snake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting r2p2/snake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/r2p2/snake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08f7b62cdeb8a7da3c0d308a3be6278810eb0e497fe0fbcf5b40b63616795a35 [INFO] running `"docker" "start" "-a" "08f7b62cdeb8a7da3c0d308a3be6278810eb0e497fe0fbcf5b40b63616795a35"` [INFO] [stderr] Checking gag v0.1.9 [INFO] [stderr] Checking rustty v0.1.12 [INFO] [stderr] Checking snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/game.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/game.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/snake.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/snake.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake_tui/ui.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake_tui/ui.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | canvas: canvas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/game.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/game.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/snake.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake/snake.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake_tui/ui.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake_tui/ui.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | canvas: canvas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/snake/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod snake; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/snake/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod snake; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake/game.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match strawberry { [INFO] [stderr] 64 | | Some(index) => { [INFO] [stderr] 65 | | strawberries.remove(index); [INFO] [stderr] 66 | | *points += 1; [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(index) = strawberry { [INFO] [stderr] 64 | strawberries.remove(index); [INFO] [stderr] 65 | *points += 1; [INFO] [stderr] 66 | snake.grow(3); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/snake/game.rs:72:15 [INFO] [stderr] | [INFO] [stderr] 72 | while strawberries.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `strawberries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake/game.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match strawberry { [INFO] [stderr] 64 | | Some(index) => { [INFO] [stderr] 65 | | strawberries.remove(index); [INFO] [stderr] 66 | | *points += 1; [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(index) = strawberry { [INFO] [stderr] 64 | strawberries.remove(index); [INFO] [stderr] 65 | *points += 1; [INFO] [stderr] 66 | snake.grow(3); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/snake/game.rs:72:15 [INFO] [stderr] | [INFO] [stderr] 72 | while strawberries.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `strawberries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.22s [INFO] running `"docker" "inspect" "08f7b62cdeb8a7da3c0d308a3be6278810eb0e497fe0fbcf5b40b63616795a35"` [INFO] running `"docker" "rm" "-f" "08f7b62cdeb8a7da3c0d308a3be6278810eb0e497fe0fbcf5b40b63616795a35"` [INFO] [stdout] 08f7b62cdeb8a7da3c0d308a3be6278810eb0e497fe0fbcf5b40b63616795a35