[INFO] updating cached repository r2p2/rusty-eca
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/r2p2/rusty-eca
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/r2p2/rusty-eca" "work/ex/clippy-test-run/sources/stable/gh/r2p2/rusty-eca"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/r2p2/rusty-eca'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/r2p2/rusty-eca" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/rusty-eca"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/rusty-eca'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ad4f7c6e0fd78235e03a96e3c5d0a4b28dd18f83
[INFO] sha for GitHub repo r2p2/rusty-eca: ad4f7c6e0fd78235e03a96e3c5d0a4b28dd18f83
[INFO] validating manifest of r2p2/rusty-eca on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of r2p2/rusty-eca on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing r2p2/rusty-eca
[INFO] finished frobbing r2p2/rusty-eca
[INFO] frobbed toml for r2p2/rusty-eca written to work/ex/clippy-test-run/sources/stable/gh/r2p2/rusty-eca/Cargo.toml
[INFO] started frobbing r2p2/rusty-eca
[INFO] finished frobbing r2p2/rusty-eca
[INFO] frobbed toml for r2p2/rusty-eca written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/rusty-eca/Cargo.toml
[INFO] crate r2p2/rusty-eca has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting r2p2/rusty-eca against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/r2p2/rusty-eca:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 90c094389685a69854d8dffd8e56ef1f74c6f7399f031c64e5da7eda5270a10d
[INFO] running `"docker" "start" "-a" "90c094389685a69854d8dffd8e56ef1f74c6f7399f031c64e5da7eda5270a10d"`
[INFO] [stderr]    Compiling libc v0.2.30
[INFO] [stderr]    Compiling itoa v0.3.3
[INFO] [stderr]     Checking serde v1.0.12
[INFO] [stderr]     Checking shared_library v0.1.7
[INFO] [stderr]     Checking deflate v0.7.16
[INFO] [stderr]    Compiling wayland-scanner v0.9.9
[INFO] [stderr]     Checking tempfile v2.1.6
[INFO] [stderr]     Checking fps_counter v0.2.0
[INFO] [stderr]     Checking num-bigint v0.1.40
[INFO] [stderr]     Checking x11-dl v2.15.0
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]    Compiling serde_derive v1.0.12
[INFO] [stderr]    Compiling serde_json v0.9.10
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]    Compiling rand v0.3.16
[INFO] [stderr]    Compiling wayland-client v0.9.9
[INFO] [stderr]    Compiling wayland-protocols v0.9.9
[INFO] [stderr]     Checking num-rational v0.1.39
[INFO] [stderr]     Checking num v0.1.40
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]    Compiling phf_generator v0.7.21
[INFO] [stderr]    Compiling phf_codegen v0.7.21
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]    Compiling palette v0.2.1
[INFO] [stderr]     Checking pistoncore-input v0.19.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.46.0
[INFO] [stderr]     Checking pistoncore-window v0.28.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.33.0
[INFO] [stderr]     Checking piston v0.33.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.9.9
[INFO] [stderr]     Checking wayland-kbd v0.9.1
[INFO] [stderr]     Checking wayland-window v0.7.0
[INFO] [stderr]     Checking winit v0.7.6
[INFO] [stderr]     Checking glutin v0.9.2
[INFO] [stderr]     Checking pistoncore-glutin_window v0.39.0
[INFO] [stderr]     Checking rusty-eca v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ca.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             rule: rule,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `rule`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ca.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             rule: rule,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `rule`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:35:36
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn key_pressed(&mut self, key: &Key) {
[INFO] [stderr]    |                                    ^^^^ help: consider passing by value instead: `Key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:67:49
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let pixel = rectangle::square(0.0, 0.0, self.cell_size as f64);
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.cell_size)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:91:33
[INFO] [stderr]    |
[INFO] [stderr] 91 |     fn update(&mut self, _args: &UpdateArgs) {
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 | /             match k {
[INFO] [stderr] 152 | |                 Keyboard(key) => app.key_pressed(&key),
[INFO] [stderr] 153 | |                 _ => {}
[INFO] [stderr] 154 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Keyboard(key) = k { app.key_pressed(&key) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:35:36
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn key_pressed(&mut self, key: &Key) {
[INFO] [stderr]    |                                    ^^^^ help: consider passing by value instead: `Key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:67:49
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let pixel = rectangle::square(0.0, 0.0, self.cell_size as f64);
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.cell_size)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:91:33
[INFO] [stderr]    |
[INFO] [stderr] 91 |     fn update(&mut self, _args: &UpdateArgs) {
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 | /             match k {
[INFO] [stderr] 152 | |                 Keyboard(key) => app.key_pressed(&key),
[INFO] [stderr] 153 | |                 _ => {}
[INFO] [stderr] 154 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Keyboard(key) = k { app.key_pressed(&key) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 58.51s
[INFO] running `"docker" "inspect" "90c094389685a69854d8dffd8e56ef1f74c6f7399f031c64e5da7eda5270a10d"`
[INFO] running `"docker" "rm" "-f" "90c094389685a69854d8dffd8e56ef1f74c6f7399f031c64e5da7eda5270a10d"`
[INFO] [stdout] 90c094389685a69854d8dffd8e56ef1f74c6f7399f031c64e5da7eda5270a10d