[INFO] updating cached repository r2p2/rust-mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/r2p2/rust-mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/r2p2/rust-mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/r2p2/rust-mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/r2p2/rust-mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/r2p2/rust-mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/rust-mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/rust-mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5cf2334de4e9a5a853089ee114ac8ff7d1677041 [INFO] sha for GitHub repo r2p2/rust-mandelbrot: 5cf2334de4e9a5a853089ee114ac8ff7d1677041 [INFO] validating manifest of r2p2/rust-mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of r2p2/rust-mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing r2p2/rust-mandelbrot [INFO] finished frobbing r2p2/rust-mandelbrot [INFO] frobbed toml for r2p2/rust-mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/r2p2/rust-mandelbrot/Cargo.toml [INFO] started frobbing r2p2/rust-mandelbrot [INFO] finished frobbing r2p2/rust-mandelbrot [INFO] frobbed toml for r2p2/rust-mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r2p2/rust-mandelbrot/Cargo.toml [INFO] crate r2p2/rust-mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting r2p2/rust-mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/r2p2/rust-mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 439e54295ff161a8c1204239042d8c19f901b96068bc6604e6fb76e040d50642 [INFO] running `"docker" "start" "-a" "439e54295ff161a8c1204239042d8c19f901b96068bc6604e6fb76e040d50642"` [INFO] [stderr] Checking deflate v0.7.16 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | center_x: center_x, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `center_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | center_y: center_y, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `center_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | zoom: zoom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zoom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | center_x: center_x, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `center_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | center_y: center_y, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `center_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | zoom: zoom, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `zoom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let mut z = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | let ref mut fout = File::create(&Path::new("fractal.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("fractal.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let mut z = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | let ref mut fout = File::create(&Path::new("fractal.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("fractal.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.61s [INFO] running `"docker" "inspect" "439e54295ff161a8c1204239042d8c19f901b96068bc6604e6fb76e040d50642"` [INFO] running `"docker" "rm" "-f" "439e54295ff161a8c1204239042d8c19f901b96068bc6604e6fb76e040d50642"` [INFO] [stdout] 439e54295ff161a8c1204239042d8c19f901b96068bc6604e6fb76e040d50642