[INFO] updating cached repository r-darwish/war [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/r-darwish/war [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/r-darwish/war" "work/ex/clippy-test-run/sources/stable/gh/r-darwish/war"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/r-darwish/war'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/r-darwish/war" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r-darwish/war"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r-darwish/war'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 414e91d2889c4fa2cc6c9bf4814e704d89356d5b [INFO] sha for GitHub repo r-darwish/war: 414e91d2889c4fa2cc6c9bf4814e704d89356d5b [INFO] validating manifest of r-darwish/war on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of r-darwish/war on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing r-darwish/war [INFO] finished frobbing r-darwish/war [INFO] frobbed toml for r-darwish/war written to work/ex/clippy-test-run/sources/stable/gh/r-darwish/war/Cargo.toml [INFO] started frobbing r-darwish/war [INFO] finished frobbing r-darwish/war [INFO] frobbed toml for r-darwish/war written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/r-darwish/war/Cargo.toml [INFO] crate r-darwish/war has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting r-darwish/war against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/r-darwish/war:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32bf1c1ddf6137c212b0627afd6837889a6a577d868f9ce5181832aa8dfcd18f [INFO] running `"docker" "start" "-a" "32bf1c1ddf6137c212b0627afd6837889a6a577d868f9ce5181832aa8dfcd18f"` [INFO] [stderr] Checking reexport-proc-macro v1.0.2 [INFO] [stderr] Checking array-macro v1.0.2 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling enum-map-derive v0.2.5 [INFO] [stderr] Checking enum-map v0.2.29 [INFO] [stderr] Checking war v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | winner: winner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `winner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | winner: winner, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `winner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cards.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match suit_rank { [INFO] [stderr] 50 | | &SuitRank::Two => Rank::Two, [INFO] [stderr] 51 | | &SuitRank::Three => Rank::Three, [INFO] [stderr] 52 | | &SuitRank::Four => Rank::Four, [INFO] [stderr] ... | [INFO] [stderr] 62 | | &SuitRank::Ace => Rank::Ace, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *suit_rank { [INFO] [stderr] 50 | SuitRank::Two => Rank::Two, [INFO] [stderr] 51 | SuitRank::Three => Rank::Three, [INFO] [stderr] 52 | SuitRank::Four => Rank::Four, [INFO] [stderr] 53 | SuitRank::Five => Rank::Five, [INFO] [stderr] 54 | SuitRank::Six => Rank::Six, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cards.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &Card::Joker(_) => Rank::Joker, [INFO] [stderr] 83 | | &Card::SuitCard(_, ref rank) => Rank::from(rank), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | Card::Joker(_) => Rank::Joker, [INFO] [stderr] 83 | Card::SuitCard(_, ref rank) => Rank::from(rank), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/game.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | / f.write( [INFO] [stderr] 105 | | format!( [INFO] [stderr] 106 | | "{},{},{}\n", [INFO] [stderr] 107 | | self.players[Players::Red].number_of_cards(), [INFO] [stderr] ... | [INFO] [stderr] 110 | | ).as_bytes(), [INFO] [stderr] 111 | | ).unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/game.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | / f.write("red_player_cards,blue_player_cards,war\n".as_bytes()) [INFO] [stderr] 128 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `war`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cards.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match suit_rank { [INFO] [stderr] 50 | | &SuitRank::Two => Rank::Two, [INFO] [stderr] 51 | | &SuitRank::Three => Rank::Three, [INFO] [stderr] 52 | | &SuitRank::Four => Rank::Four, [INFO] [stderr] ... | [INFO] [stderr] 62 | | &SuitRank::Ace => Rank::Ace, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *suit_rank { [INFO] [stderr] 50 | SuitRank::Two => Rank::Two, [INFO] [stderr] 51 | SuitRank::Three => Rank::Three, [INFO] [stderr] 52 | SuitRank::Four => Rank::Four, [INFO] [stderr] 53 | SuitRank::Five => Rank::Five, [INFO] [stderr] 54 | SuitRank::Six => Rank::Six, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cards.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &Card::Joker(_) => Rank::Joker, [INFO] [stderr] 83 | | &Card::SuitCard(_, ref rank) => Rank::from(rank), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | Card::Joker(_) => Rank::Joker, [INFO] [stderr] 83 | Card::SuitCard(_, ref rank) => Rank::from(rank), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/game.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | / f.write( [INFO] [stderr] 105 | | format!( [INFO] [stderr] 106 | | "{},{},{}\n", [INFO] [stderr] 107 | | self.players[Players::Red].number_of_cards(), [INFO] [stderr] ... | [INFO] [stderr] 110 | | ).as_bytes(), [INFO] [stderr] 111 | | ).unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/game.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | / f.write("red_player_cards,blue_player_cards,war\n".as_bytes()) [INFO] [stderr] 128 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `war`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "32bf1c1ddf6137c212b0627afd6837889a6a577d868f9ce5181832aa8dfcd18f"` [INFO] running `"docker" "rm" "-f" "32bf1c1ddf6137c212b0627afd6837889a6a577d868f9ce5181832aa8dfcd18f"` [INFO] [stdout] 32bf1c1ddf6137c212b0627afd6837889a6a577d868f9ce5181832aa8dfcd18f