[INFO] updating cached repository quadfault/rt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/quadfault/rt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/quadfault/rt" "work/ex/clippy-test-run/sources/stable/gh/quadfault/rt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/quadfault/rt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/quadfault/rt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadfault/rt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadfault/rt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e02ce526af0cd34464eb2571c79c5473453756c8 [INFO] sha for GitHub repo quadfault/rt: e02ce526af0cd34464eb2571c79c5473453756c8 [INFO] validating manifest of quadfault/rt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quadfault/rt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quadfault/rt [INFO] finished frobbing quadfault/rt [INFO] frobbed toml for quadfault/rt written to work/ex/clippy-test-run/sources/stable/gh/quadfault/rt/Cargo.toml [INFO] started frobbing quadfault/rt [INFO] finished frobbing quadfault/rt [INFO] frobbed toml for quadfault/rt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadfault/rt/Cargo.toml [INFO] crate quadfault/rt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quadfault/rt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/quadfault/rt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 040491ca54f4e0d8e217226f174eaf84aa574a159d6bcc23fcca6e265f0c21cc [INFO] running `"docker" "start" "-a" "040491ca54f4e0d8e217226f174eaf84aa574a159d6bcc23fcca6e265f0c21cc"` [INFO] [stderr] Checking rt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `Dielectric` [INFO] [stderr] --> src/materials/dielectric.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct Dielectric { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/materials/dielectric.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(refractive_index: f64) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `origin` [INFO] [stderr] --> src/math/point.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn origin() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/math/vector.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn cross(self, rhs: Self) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Plane` [INFO] [stderr] --> src/models/plane.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct Plane { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/models/plane.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new(point_on_plane: Point, [INFO] [stderr] 18 | | normal: Vector, [INFO] [stderr] 19 | | material: Box) [INFO] [stderr] 20 | | -> Self [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/materials/dielectric.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / let cosine; [INFO] [stderr] 28 | | [INFO] [stderr] 29 | | if ray.direction.dot(hr.normal) > 0.0 { [INFO] [stderr] 30 | | outward_normal = -hr.normal; [INFO] [stderr] ... | [INFO] [stderr] 38 | | cosine = -ray.direction.dot(hr.normal) / ray.direction.norm(); [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 27 | let cosine = if ray.direction.dot(hr.normal) > 0.0 { ..; self.refractive_index [INFO] [stderr] 28 | * ray.direction.dot(hr.normal) [INFO] [stderr] 29 | / ray.direction.norm() } else { ..; -ray.direction.dot(hr.normal) / ray.direction.norm() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / match model.hit(ray, tmin, closest_so_far) { [INFO] [stderr] 119 | | Some(hr) => { [INFO] [stderr] 120 | | closest_so_far = hr.t; [INFO] [stderr] 121 | | rc = Some(hr); [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | None => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Some(hr) = model.hit(ray, tmin, closest_so_far) { [INFO] [stderr] 119 | closest_so_far = hr.t; [INFO] [stderr] 120 | rc = Some(hr); [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Dielectric` [INFO] [stderr] --> src/materials/dielectric.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct Dielectric { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/materials/dielectric.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(refractive_index: f64) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `origin` [INFO] [stderr] --> src/math/point.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn origin() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/math/vector.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn cross(self, rhs: Self) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Plane` [INFO] [stderr] --> src/models/plane.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct Plane { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/models/plane.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new(point_on_plane: Point, [INFO] [stderr] 18 | | normal: Vector, [INFO] [stderr] 19 | | material: Box) [INFO] [stderr] 20 | | -> Self [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/materials/dielectric.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / let cosine; [INFO] [stderr] 28 | | [INFO] [stderr] 29 | | if ray.direction.dot(hr.normal) > 0.0 { [INFO] [stderr] 30 | | outward_normal = -hr.normal; [INFO] [stderr] ... | [INFO] [stderr] 38 | | cosine = -ray.direction.dot(hr.normal) / ray.direction.norm(); [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 27 | let cosine = if ray.direction.dot(hr.normal) > 0.0 { ..; self.refractive_index [INFO] [stderr] 28 | * ray.direction.dot(hr.normal) [INFO] [stderr] 29 | / ray.direction.norm() } else { ..; -ray.direction.dot(hr.normal) / ray.direction.norm() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/color.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(c.r, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/color.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(c.r, 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/color.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(c.g, 0.25); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/color.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(c.g, 0.25); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/color.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(c.b, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/color.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(c.b, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/vector.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(v.x, 6.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/vector.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(v.x, 6.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/vector.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(v.y, -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/vector.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(v.y, -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/vector.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(v.z, 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/vector.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(v.z, 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / match model.hit(ray, tmin, closest_so_far) { [INFO] [stderr] 119 | | Some(hr) => { [INFO] [stderr] 120 | | closest_so_far = hr.t; [INFO] [stderr] 121 | | rc = Some(hr); [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | None => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Some(hr) = model.hit(ray, tmin, closest_so_far) { [INFO] [stderr] 119 | closest_so_far = hr.t; [INFO] [stderr] 120 | rc = Some(hr); [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "040491ca54f4e0d8e217226f174eaf84aa574a159d6bcc23fcca6e265f0c21cc"` [INFO] running `"docker" "rm" "-f" "040491ca54f4e0d8e217226f174eaf84aa574a159d6bcc23fcca6e265f0c21cc"` [INFO] [stdout] 040491ca54f4e0d8e217226f174eaf84aa574a159d6bcc23fcca6e265f0c21cc