[INFO] updating cached repository qoh/ca
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/qoh/ca
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/qoh/ca" "work/ex/clippy-test-run/sources/stable/gh/qoh/ca"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/qoh/ca'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/qoh/ca" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qoh/ca"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qoh/ca'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] edc195d432c72d9e7cc5156e51c96a9cc13de38e
[INFO] sha for GitHub repo qoh/ca: edc195d432c72d9e7cc5156e51c96a9cc13de38e
[INFO] validating manifest of qoh/ca on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of qoh/ca on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing qoh/ca
[INFO] finished frobbing qoh/ca
[INFO] frobbed toml for qoh/ca written to work/ex/clippy-test-run/sources/stable/gh/qoh/ca/Cargo.toml
[INFO] started frobbing qoh/ca
[INFO] finished frobbing qoh/ca
[INFO] frobbed toml for qoh/ca written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qoh/ca/Cargo.toml
[INFO] crate qoh/ca has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting qoh/ca against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/qoh/ca:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7a5d7b50d0a3778218fee9f15fdc4c7f0939e5a53901d11ebb38fdbebbabd852
[INFO] running `"docker" "start" "-a" "7a5d7b50d0a3778218fee9f15fdc4c7f0939e5a53901d11ebb38fdbebbabd852"`
[INFO] [stderr]     Checking num-complex v0.1.38
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking num-bigint v0.1.39
[INFO] [stderr]     Checking num-rational v0.1.38
[INFO] [stderr]     Checking num v0.1.39
[INFO] [stderr]     Checking rustyline v1.0.0
[INFO] [stderr]     Checking ca v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:69:5
[INFO] [stderr]     |
[INFO] [stderr] 69  | /     match e {
[INFO] [stderr] 70  | |         &Expr::Number(ref i) => {
[INFO] [stderr] 71  | |             if f.alternate() {
[INFO] [stderr] 72  | |                 i.fmt(f)
[INFO] [stderr] ...   |
[INFO] [stderr] 119 | |         }
[INFO] [stderr] 120 | |     }?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 69  |     match *e {
[INFO] [stderr] 70  |         Expr::Number(ref i) => {
[INFO] [stderr] 71  |             if f.alternate() {
[INFO] [stderr] 72  |                 i.fmt(f)
[INFO] [stderr] 73  |             } else {
[INFO] [stderr] 74  |                 fmt_ratio_decimal(i, f)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:166:3
[INFO] [stderr]     |
[INFO] [stderr] 166 |           match self {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 167 | |             &Op::Add => write!(f, "+"),
[INFO] [stderr] 168 | |             &Op::Subtract => write!(f, "−"),
[INFO] [stderr] 169 | |             &Op::Multiply => write!(f, "∙"),
[INFO] [stderr] ...   |
[INFO] [stderr] 174 | |             &Op::Equals => write!(f, "="),
[INFO] [stderr] 175 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 166 |         match *self {
[INFO] [stderr] 167 |             Op::Add => write!(f, "+"),
[INFO] [stderr] 168 |             Op::Subtract => write!(f, "−"),
[INFO] [stderr] 169 |             Op::Multiply => write!(f, "∙"),
[INFO] [stderr] 170 |             Op::Adjacent => write!(f, "∙"),
[INFO] [stderr] 171 |             Op::Divide => write!(f, "÷"),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:182:2
[INFO] [stderr]     |
[INFO] [stderr] 182 |       match token {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 183 | |         &Token::Equals => Some((3, 3)),
[INFO] [stderr] 184 | |         &Token::Add | &Token::Subtract => Some((6, 6)),
[INFO] [stderr] 185 | |         &Token::Multiply | &Token::Divide | &Token::Modulus => Some((7, 7)),
[INFO] [stderr] 186 | |         &Token::Exponent => Some((10, 9)),
[INFO] [stderr] 187 | |         _ => None
[INFO] [stderr] 188 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 182 |     match *token {
[INFO] [stderr] 183 |         Token::Equals => Some((3, 3)),
[INFO] [stderr] 184 |         Token::Add | Token::Subtract => Some((6, 6)),
[INFO] [stderr] 185 |         Token::Multiply | Token::Divide | Token::Modulus => Some((7, 7)),
[INFO] [stderr] 186 |         Token::Exponent => Some((10, 9)),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:202:3
[INFO] [stderr]     |
[INFO] [stderr] 202 |           if let &Token::Assign = t {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 203 | |             let rhs = parse_expr(&mut it, 0)?;
[INFO] [stderr] 204 | |             Ok(Expr::Assign(Box::new(lhs), Box::new(rhs)))
[INFO] [stderr] 205 | |         } else {
[INFO] [stderr] 206 | |             Err(format!("Unexpected token: {:?}", t))
[INFO] [stderr] 207 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 202 |         if let Token::Assign = *t {
[INFO] [stderr]     |                ^^^^^^^^^^^^^   ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:219:3
[INFO] [stderr]     |
[INFO] [stderr] 219 |           match next_token {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 220 | |             &Token::RightParen => break,
[INFO] [stderr] 221 | |             &Token::Name(_) | &Token::Number(_) | &Token::LeftParen => {
[INFO] [stderr] 222 | |                 expr = Expr::BinaryExpr(
[INFO] [stderr] ...   |
[INFO] [stderr] 229 | |             _ => {}
[INFO] [stderr] 230 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 219 |         match *next_token {
[INFO] [stderr] 220 |             Token::RightParen => break,
[INFO] [stderr] 221 |             Token::Name(_) | Token::Number(_) | Token::LeftParen => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:251:14
[INFO] [stderr]     |
[INFO] [stderr] 251 |           Some(t) => match t {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 252 | |             &Token::Number(ref n) => {
[INFO] [stderr] 253 | |                 Ok(Expr::Number(n.clone()))
[INFO] [stderr] 254 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 288 | |             _ => Err(format!("Unexpected token: {:?}", t))
[INFO] [stderr] 289 | |         },
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 251 |         Some(t) => match *t {
[INFO] [stderr] 252 |             Token::Number(ref n) => {
[INFO] [stderr] 253 |                 Ok(Expr::Number(n.clone()))
[INFO] [stderr] 254 |             },
[INFO] [stderr] 255 |             Token::Name(ref n) => {
[INFO] [stderr] 256 |                 Ok(Expr::Name(n.clone()))
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:299:13
[INFO] [stderr]     |
[INFO] [stderr] 299 |               let op = match t {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 300 | |                 &Token::Add => Op::Add,
[INFO] [stderr] 301 | |                 &Token::Subtract => Op::Subtract,
[INFO] [stderr] 302 | |                 &Token::Multiply => Op::Multiply,
[INFO] [stderr] ...   |
[INFO] [stderr] 307 | |                 _ => return Err(format!("Unexpected token: {:?}", t))
[INFO] [stderr] 308 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 299 |             let op = match *t {
[INFO] [stderr] 300 |                 Token::Add => Op::Add,
[INFO] [stderr] 301 |                 Token::Subtract => Op::Subtract,
[INFO] [stderr] 302 |                 Token::Multiply => Op::Multiply,
[INFO] [stderr] 303 |                 Token::Divide => Op::Divide,
[INFO] [stderr] 304 |                 Token::Modulus => Op::Modulus,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/tokenizer.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn tokenize(src: &String) -> Result<Vec<Token>, String> {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/tokenizer.rs:28:2
[INFO] [stderr]    |
[INFO] [stderr] 28 |       loop {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 29 | |         match it.peek() {
[INFO] [stderr] 30 | |             Some(&ch) => match ch {
[INFO] [stderr] 31 | |                 '0' ... '9' | '.' => {
[INFO] [stderr] ...  |
[INFO] [stderr] 93 | |         }
[INFO] [stderr] 94 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(&ch) = it.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:69:5
[INFO] [stderr]     |
[INFO] [stderr] 69  | /     match e {
[INFO] [stderr] 70  | |         &Expr::Number(ref i) => {
[INFO] [stderr] 71  | |             if f.alternate() {
[INFO] [stderr] 72  | |                 i.fmt(f)
[INFO] [stderr] ...   |
[INFO] [stderr] 119 | |         }
[INFO] [stderr] 120 | |     }?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 69  |     match *e {
[INFO] [stderr] 70  |         Expr::Number(ref i) => {
[INFO] [stderr] 71  |             if f.alternate() {
[INFO] [stderr] 72  |                 i.fmt(f)
[INFO] [stderr] 73  |             } else {
[INFO] [stderr] 74  |                 fmt_ratio_decimal(i, f)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator.rs:86:19
[INFO] [stderr]    |
[INFO] [stderr] 86 | fn apply_fn(name: &String, operand: &Expr) -> Option<Expr> {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator.rs:88:3
[INFO] [stderr]    |
[INFO] [stderr] 88 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 89 | |             return Some(Expr::Number(n.floor()));
[INFO] [stderr] 90 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 88 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator.rs:93:3
[INFO] [stderr]    |
[INFO] [stderr] 93 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 94 | |             return Some(Expr::Number(n.ceil()));
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 93 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:98:3
[INFO] [stderr]     |
[INFO] [stderr] 98  |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 99  | |             return Some(Expr::Number(n.round()));
[INFO] [stderr] 100 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 98  |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:103:3
[INFO] [stderr]     |
[INFO] [stderr] 103 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 104 | |             return Some(Expr::Number(n.trunc()));
[INFO] [stderr] 105 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 103 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:108:3
[INFO] [stderr]     |
[INFO] [stderr] 108 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 109 | |             return Some(Expr::Number(n.fract()));
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:113:3
[INFO] [stderr]     |
[INFO] [stderr] 113 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 114 | |             return Some(Expr::Number(n.abs()));
[INFO] [stderr] 115 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 113 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/context.rs:32:26
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn get(&self, name: &String) -> Option<Expr> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/context.rs:42:2
[INFO] [stderr]    |
[INFO] [stderr] 42 |       pub fn evaluate<'b>(&'b mut self, name: String) -> Context<'b> {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 43 | |         let mut evaluating = self.evaluating.clone();
[INFO] [stderr] 44 | |         evaluating.insert(name);
[INFO] [stderr] 45 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 49 | |         }
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:166:3
[INFO] [stderr]     |
[INFO] [stderr] 166 |           match self {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 167 | |             &Op::Add => write!(f, "+"),
[INFO] [stderr] 168 | |             &Op::Subtract => write!(f, "−"),
[INFO] [stderr] 169 | |             &Op::Multiply => write!(f, "∙"),
[INFO] [stderr] ...   |
[INFO] [stderr] 174 | |             &Op::Equals => write!(f, "="),
[INFO] [stderr] 175 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 166 |         match *self {
[INFO] [stderr] 167 |             Op::Add => write!(f, "+"),
[INFO] [stderr] 168 |             Op::Subtract => write!(f, "−"),
[INFO] [stderr] 169 |             Op::Multiply => write!(f, "∙"),
[INFO] [stderr] 170 |             Op::Adjacent => write!(f, "∙"),
[INFO] [stderr] 171 |             Op::Divide => write!(f, "÷"),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:182:2
[INFO] [stderr]     |
[INFO] [stderr] 182 |       match token {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 183 | |         &Token::Equals => Some((3, 3)),
[INFO] [stderr] 184 | |         &Token::Add | &Token::Subtract => Some((6, 6)),
[INFO] [stderr] 185 | |         &Token::Multiply | &Token::Divide | &Token::Modulus => Some((7, 7)),
[INFO] [stderr] 186 | |         &Token::Exponent => Some((10, 9)),
[INFO] [stderr] 187 | |         _ => None
[INFO] [stderr] 188 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 182 |     match *token {
[INFO] [stderr] 183 |         Token::Equals => Some((3, 3)),
[INFO] [stderr] 184 |         Token::Add | Token::Subtract => Some((6, 6)),
[INFO] [stderr] 185 |         Token::Multiply | Token::Divide | Token::Modulus => Some((7, 7)),
[INFO] [stderr] 186 |         Token::Exponent => Some((10, 9)),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:202:3
[INFO] [stderr]     |
[INFO] [stderr] 202 |           if let &Token::Assign = t {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 203 | |             let rhs = parse_expr(&mut it, 0)?;
[INFO] [stderr] 204 | |             Ok(Expr::Assign(Box::new(lhs), Box::new(rhs)))
[INFO] [stderr] 205 | |         } else {
[INFO] [stderr] 206 | |             Err(format!("Unexpected token: {:?}", t))
[INFO] [stderr] 207 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 202 |         if let Token::Assign = *t {
[INFO] [stderr]     |                ^^^^^^^^^^^^^   ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:219:3
[INFO] [stderr]     |
[INFO] [stderr] 219 |           match next_token {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 220 | |             &Token::RightParen => break,
[INFO] [stderr] 221 | |             &Token::Name(_) | &Token::Number(_) | &Token::LeftParen => {
[INFO] [stderr] 222 | |                 expr = Expr::BinaryExpr(
[INFO] [stderr] ...   |
[INFO] [stderr] 229 | |             _ => {}
[INFO] [stderr] 230 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 219 |         match *next_token {
[INFO] [stderr] 220 |             Token::RightParen => break,
[INFO] [stderr] 221 |             Token::Name(_) | Token::Number(_) | Token::LeftParen => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:251:14
[INFO] [stderr]     |
[INFO] [stderr] 251 |           Some(t) => match t {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 252 | |             &Token::Number(ref n) => {
[INFO] [stderr] 253 | |                 Ok(Expr::Number(n.clone()))
[INFO] [stderr] 254 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 288 | |             _ => Err(format!("Unexpected token: {:?}", t))
[INFO] [stderr] 289 | |         },
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 251 |         Some(t) => match *t {
[INFO] [stderr] 252 |             Token::Number(ref n) => {
[INFO] [stderr] 253 |                 Ok(Expr::Number(n.clone()))
[INFO] [stderr] 254 |             },
[INFO] [stderr] 255 |             Token::Name(ref n) => {
[INFO] [stderr] 256 |                 Ok(Expr::Name(n.clone()))
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:299:13
[INFO] [stderr]     |
[INFO] [stderr] 299 |               let op = match t {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 300 | |                 &Token::Add => Op::Add,
[INFO] [stderr] 301 | |                 &Token::Subtract => Op::Subtract,
[INFO] [stderr] 302 | |                 &Token::Multiply => Op::Multiply,
[INFO] [stderr] ...   |
[INFO] [stderr] 307 | |                 _ => return Err(format!("Unexpected token: {:?}", t))
[INFO] [stderr] 308 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 299 |             let op = match *t {
[INFO] [stderr] 300 |                 Token::Add => Op::Add,
[INFO] [stderr] 301 |                 Token::Subtract => Op::Subtract,
[INFO] [stderr] 302 |                 Token::Multiply => Op::Multiply,
[INFO] [stderr] 303 |                 Token::Divide => Op::Divide,
[INFO] [stderr] 304 |                 Token::Modulus => Op::Modulus,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/tokenizer.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn tokenize(src: &String) -> Result<Vec<Token>, String> {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:20:10
[INFO] [stderr]    |
[INFO] [stderr] 20 |         input(&String::from(line), &mut scope, false);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:44:16
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn input(line: &String, scope: &mut context::Scope, align: bool) {
[INFO] [stderr]    |                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/tokenizer.rs:28:2
[INFO] [stderr]    |
[INFO] [stderr] 28 |       loop {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 29 | |         match it.peek() {
[INFO] [stderr] 30 | |             Some(&ch) => match ch {
[INFO] [stderr] 31 | |                 '0' ... '9' | '.' => {
[INFO] [stderr] ...  |
[INFO] [stderr] 93 | |         }
[INFO] [stderr] 94 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(&ch) = it.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/evaluator.rs:86:19
[INFO] [stderr]    |
[INFO] [stderr] 86 | fn apply_fn(name: &String, operand: &Expr) -> Option<Expr> {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator.rs:88:3
[INFO] [stderr]    |
[INFO] [stderr] 88 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 89 | |             return Some(Expr::Number(n.floor()));
[INFO] [stderr] 90 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 88 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator.rs:93:3
[INFO] [stderr]    |
[INFO] [stderr] 93 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 94 | |             return Some(Expr::Number(n.ceil()));
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 93 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:98:3
[INFO] [stderr]     |
[INFO] [stderr] 98  |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 99  | |             return Some(Expr::Number(n.round()));
[INFO] [stderr] 100 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 98  |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:103:3
[INFO] [stderr]     |
[INFO] [stderr] 103 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 104 | |             return Some(Expr::Number(n.trunc()));
[INFO] [stderr] 105 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 103 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:108:3
[INFO] [stderr]     |
[INFO] [stderr] 108 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 109 | |             return Some(Expr::Number(n.fract()));
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/evaluator.rs:113:3
[INFO] [stderr]     |
[INFO] [stderr] 113 |           if let &Expr::Number(ref n) = operand {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 114 | |             return Some(Expr::Number(n.abs()));
[INFO] [stderr] 115 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 113 |         if let Expr::Number(ref n) = *operand {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/context.rs:32:26
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn get(&self, name: &String) -> Option<Expr> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/context.rs:42:2
[INFO] [stderr]    |
[INFO] [stderr] 42 |       pub fn evaluate<'b>(&'b mut self, name: String) -> Context<'b> {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 43 | |         let mut evaluating = self.evaluating.clone();
[INFO] [stderr] 44 | |         evaluating.insert(name);
[INFO] [stderr] 45 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 49 | |         }
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:20:10
[INFO] [stderr]    |
[INFO] [stderr] 20 |         input(&String::from(line), &mut scope, false);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:44:16
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn input(line: &String, scope: &mut context::Scope, align: bool) {
[INFO] [stderr]    |                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.54s
[INFO] running `"docker" "inspect" "7a5d7b50d0a3778218fee9f15fdc4c7f0939e5a53901d11ebb38fdbebbabd852"`
[INFO] running `"docker" "rm" "-f" "7a5d7b50d0a3778218fee9f15fdc4c7f0939e5a53901d11ebb38fdbebbabd852"`
[INFO] [stdout] 7a5d7b50d0a3778218fee9f15fdc4c7f0939e5a53901d11ebb38fdbebbabd852