[INFO] updating cached repository qnnguyen17/rust-chip8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/qnnguyen17/rust-chip8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/qnnguyen17/rust-chip8" "work/ex/clippy-test-run/sources/stable/gh/qnnguyen17/rust-chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/qnnguyen17/rust-chip8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/qnnguyen17/rust-chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qnnguyen17/rust-chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qnnguyen17/rust-chip8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 13239c634484f27de8cf6fc0ac7677b1955408f8 [INFO] sha for GitHub repo qnnguyen17/rust-chip8: 13239c634484f27de8cf6fc0ac7677b1955408f8 [INFO] validating manifest of qnnguyen17/rust-chip8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qnnguyen17/rust-chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qnnguyen17/rust-chip8 [INFO] finished frobbing qnnguyen17/rust-chip8 [INFO] frobbed toml for qnnguyen17/rust-chip8 written to work/ex/clippy-test-run/sources/stable/gh/qnnguyen17/rust-chip8/Cargo.toml [INFO] started frobbing qnnguyen17/rust-chip8 [INFO] finished frobbing qnnguyen17/rust-chip8 [INFO] frobbed toml for qnnguyen17/rust-chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qnnguyen17/rust-chip8/Cargo.toml [INFO] crate qnnguyen17/rust-chip8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qnnguyen17/rust-chip8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/qnnguyen17/rust-chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12c34ac939ad89c7d96cdc1eea75ef09c74e6c58a9e4e0b3cac1c52c88b673ba [INFO] running `"docker" "start" "-a" "12c34ac939ad89c7d96cdc1eea75ef09c74e6c58a9e4e0b3cac1c52c88b673ba"` [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking smallvec v0.6.6 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.81.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/tests.rs:291:21 [INFO] [stderr] | [INFO] [stderr] 291 | cpu.memory[0] = 0b01110111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/tests.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | fb[1] = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/tests.rs:320:21 [INFO] [stderr] | [INFO] [stderr] 320 | cpu.memory[0] = 0b01110111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/tests.rs:367:20 [INFO] [stderr] | [INFO] [stderr] 367 | assert_eq!(0b01110000, fb[0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/tests.rs:535:16 [INFO] [stderr] | [INFO] [stderr] 535 | cpu.v[0] = 0b10000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sound_timer` [INFO] [stderr] --> src/cpu.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | sound_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/cpu.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / fn execute(&mut self, op: OpCode) { [INFO] [stderr] 243 | | let mut new_pc = self.pc + 2; [INFO] [stderr] 244 | | match op { [INFO] [stderr] 245 | | AddIReg { reg } => { [INFO] [stderr] ... | [INFO] [stderr] 490 | | self.pc = new_pc; [INFO] [stderr] 491 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: field is never used: `sound_timer` [INFO] [stderr] --> src/cpu.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | sound_timer: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/cpu.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / fn execute(&mut self, op: OpCode) { [INFO] [stderr] 243 | | let mut new_pc = self.pc + 2; [INFO] [stderr] 244 | | match op { [INFO] [stderr] 245 | | AddIReg { reg } => { [INFO] [stderr] ... | [INFO] [stderr] 490 | | self.pc = new_pc; [INFO] [stderr] 491 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 33s [INFO] running `"docker" "inspect" "12c34ac939ad89c7d96cdc1eea75ef09c74e6c58a9e4e0b3cac1c52c88b673ba"` [INFO] running `"docker" "rm" "-f" "12c34ac939ad89c7d96cdc1eea75ef09c74e6c58a9e4e0b3cac1c52c88b673ba"` [INFO] [stdout] 12c34ac939ad89c7d96cdc1eea75ef09c74e6c58a9e4e0b3cac1c52c88b673ba