[INFO] updating cached repository qingxiang-jia/learn-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/qingxiang-jia/learn-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/qingxiang-jia/learn-rust" "work/ex/clippy-test-run/sources/stable/gh/qingxiang-jia/learn-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/qingxiang-jia/learn-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/qingxiang-jia/learn-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qingxiang-jia/learn-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qingxiang-jia/learn-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a5d82ab7d8a21c1f2d7f96fda45dd273c842694 [INFO] sha for GitHub repo qingxiang-jia/learn-rust: 7a5d82ab7d8a21c1f2d7f96fda45dd273c842694 [INFO] validating manifest of qingxiang-jia/learn-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qingxiang-jia/learn-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qingxiang-jia/learn-rust [INFO] finished frobbing qingxiang-jia/learn-rust [INFO] frobbed toml for qingxiang-jia/learn-rust written to work/ex/clippy-test-run/sources/stable/gh/qingxiang-jia/learn-rust/Cargo.toml [INFO] started frobbing qingxiang-jia/learn-rust [INFO] finished frobbing qingxiang-jia/learn-rust [INFO] frobbed toml for qingxiang-jia/learn-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qingxiang-jia/learn-rust/Cargo.toml [INFO] crate qingxiang-jia/learn-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qingxiang-jia/learn-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/qingxiang-jia/learn-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1c7a162f55d300d8ba76de53cf21354960dce955b7845acb8d067eff9a48f8d [INFO] running `"docker" "start" "-a" "a1c7a162f55d300d8ba76de53cf21354960dce955b7845acb8d067eff9a48f8d"` [INFO] [stderr] Checking learn_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/udp_lib.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / return match send_result { [INFO] [stderr] 12 | | Ok(v) => v, [INFO] [stderr] 13 | | Err(_e) => 0, [INFO] [stderr] 14 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | match send_result { [INFO] [stderr] 12 | Ok(v) => v, [INFO] [stderr] 13 | Err(_e) => 0, [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/udp_lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / return match recv_result { [INFO] [stderr] 26 | | Ok(_v) => { [INFO] [stderr] 27 | | let str_recv = match str::from_utf8(&buf[..]) { [INFO] [stderr] 28 | | Ok(_vv) => String::from(_vv), [INFO] [stderr] ... | [INFO] [stderr] 33 | | Err(_e) => String::from(""), [INFO] [stderr] 34 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | match recv_result { [INFO] [stderr] 26 | Ok(_v) => { [INFO] [stderr] 27 | let str_recv = match str::from_utf8(&buf[..]) { [INFO] [stderr] 28 | Ok(_vv) => String::from(_vv), [INFO] [stderr] 29 | Err(_ee) => String::from(""), [INFO] [stderr] 30 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/udp_lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | String::from(str_recv) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `str_recv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/udp_lib.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / return match send_result { [INFO] [stderr] 12 | | Ok(v) => v, [INFO] [stderr] 13 | | Err(_e) => 0, [INFO] [stderr] 14 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | match send_result { [INFO] [stderr] 12 | Ok(v) => v, [INFO] [stderr] 13 | Err(_e) => 0, [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/udp_lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / return match recv_result { [INFO] [stderr] 26 | | Ok(_v) => { [INFO] [stderr] 27 | | let str_recv = match str::from_utf8(&buf[..]) { [INFO] [stderr] 28 | | Ok(_vv) => String::from(_vv), [INFO] [stderr] ... | [INFO] [stderr] 33 | | Err(_e) => String::from(""), [INFO] [stderr] 34 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | match recv_result { [INFO] [stderr] 26 | Ok(_v) => { [INFO] [stderr] 27 | let str_recv = match str::from_utf8(&buf[..]) { [INFO] [stderr] 28 | Ok(_vv) => String::from(_vv), [INFO] [stderr] 29 | Err(_ee) => String::from(""), [INFO] [stderr] 30 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/udp_lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | String::from(str_recv) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `str_recv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "a1c7a162f55d300d8ba76de53cf21354960dce955b7845acb8d067eff9a48f8d"` [INFO] running `"docker" "rm" "-f" "a1c7a162f55d300d8ba76de53cf21354960dce955b7845acb8d067eff9a48f8d"` [INFO] [stdout] a1c7a162f55d300d8ba76de53cf21354960dce955b7845acb8d067eff9a48f8d