[INFO] updating cached repository qfeys/LD41 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/qfeys/LD41 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/qfeys/LD41" "work/ex/clippy-test-run/sources/stable/gh/qfeys/LD41"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/qfeys/LD41'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/qfeys/LD41" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qfeys/LD41"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qfeys/LD41'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0aa8cb7d48a6fb0fb8f91e58004fe94d373586f7 [INFO] sha for GitHub repo qfeys/LD41: 0aa8cb7d48a6fb0fb8f91e58004fe94d373586f7 [INFO] validating manifest of qfeys/LD41 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qfeys/LD41 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qfeys/LD41 [INFO] finished frobbing qfeys/LD41 [INFO] frobbed toml for qfeys/LD41 written to work/ex/clippy-test-run/sources/stable/gh/qfeys/LD41/Cargo.toml [INFO] started frobbing qfeys/LD41 [INFO] finished frobbing qfeys/LD41 [INFO] frobbed toml for qfeys/LD41 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qfeys/LD41/Cargo.toml [INFO] crate qfeys/LD41 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qfeys/LD41 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/qfeys/LD41:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 739c6b4e60b53211bf2b5f3fcc975ef2ec88def2e4e48ddd9361971da09639a1 [INFO] running `"docker" "start" "-a" "739c6b4e60b53211bf2b5f3fcc975ef2ec88def2e4e48ddd9361971da09639a1"` [INFO] [stderr] Checking serde v1.0.41 [INFO] [stderr] Checking clock_ticks v0.1.1 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Checking tempfile v3.0.1 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking parking_lot v0.5.4 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Checking hprof v0.1.3 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Compiling serde_derive v1.0.41 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.1 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking LD41 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::f64::*` [INFO] [stderr] --> src/drone/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::f64::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/drone/steering.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | steering [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/drone/steering.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | let steering = desired_velocity - drone.vel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/drone/steering.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | steering [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/drone/steering.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | let steering = drone.vel + rot_acc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/drone/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | unit_type::Worker { cargo: _ } => Drone { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/drone/mod.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | unit_type::Worker { cargo: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/drone/mod.rs:184:29 [INFO] [stderr] | [INFO] [stderr] 184 | unit_type::Worker { cargo: _ } => panic!("Workers do not persue"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/map.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | ::drone::unit_type::Worker { cargo: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/map.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | unit_type::Worker { cargo: _ } => worker_count += 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/cui.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | unit_type::Worker { cargo: _ } => s.push_str(" W"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/aicontr.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | unit_type::Worker { cargo: _ } => self.workers.push(d.id), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::f64::*` [INFO] [stderr] --> src/drone/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::f64::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/drone/steering.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | steering [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/drone/steering.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | let steering = desired_velocity - drone.vel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/drone/steering.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | steering [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/drone/steering.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | let steering = drone.vel + rot_acc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/drone/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | unit_type::Worker { cargo: _ } => Drone { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/drone/mod.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | unit_type::Worker { cargo: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/drone/mod.rs:184:29 [INFO] [stderr] | [INFO] [stderr] 184 | unit_type::Worker { cargo: _ } => panic!("Workers do not persue"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/map.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | ::drone::unit_type::Worker { cargo: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/map.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | unit_type::Worker { cargo: _ } => worker_count += 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/cui.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | unit_type::Worker { cargo: _ } => s.push_str(" W"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/aicontr.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | unit_type::Worker { cargo: _ } => self.workers.push(d.id), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Worker { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Evade` [INFO] [stderr] --> src/drone/mod.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | Evade(usize, Pos, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `LD41` should have a snake case name such as `ld41` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `drone::Drone` [INFO] [stderr] --> src/drone/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Drone { [INFO] [stderr] 30 | | Drone { [INFO] [stderr] 31 | | id: OBJECT_COUNTER.fetch_add(1, atomic::Ordering::SeqCst), [INFO] [stderr] 32 | | pos: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for drone::Drone { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/drone/mod.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | drone_list: &Vec<(usize, Pos, u8)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, Pos, u8)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/drone/mod.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | if ens.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/drone/mod.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | if enemies.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!enemies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/drone/mod.rs:208:56 [INFO] [stderr] | [INFO] [stderr] 208 | fn get_data_from_drone_list(id: usize, drone_list: &Vec<(usize, Pos, u8)>) -> (usize, Pos, u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, Pos, u8)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/drone/mod.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | drone_list: &Vec<(usize, Pos, u8)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, Pos, u8)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/drone/mod.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / pub fn draw( [INFO] [stderr] 230 | | &self, [INFO] [stderr] 231 | | gl: &mut GlGraphics, [INFO] [stderr] 232 | | c: &Context, [INFO] [stderr] ... | [INFO] [stderr] 251 | | rectangle(::color::team(self.team), square, transform, gl); [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: type `unit_type` should have a camel case name such as `UnitType` [INFO] [stderr] --> src/drone/mod.rs:256:1 [INFO] [stderr] | [INFO] [stderr] 256 | / pub enum unit_type { [INFO] [stderr] 257 | | Worker { cargo: f64 }, [INFO] [stderr] 258 | | Soldier, [INFO] [stderr] 259 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `base::Base` [INFO] [stderr] --> src/base.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Base { [INFO] [stderr] 21 | | Base { [INFO] [stderr] 22 | | pos: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] 23 | | prod_queue: Vec::new(), [INFO] [stderr] 24 | | team: 1, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for base::Base { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/base.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn draw( [INFO] [stderr] 47 | | &self, [INFO] [stderr] 48 | | gl: &mut GlGraphics, [INFO] [stderr] 49 | | c: &Context, [INFO] [stderr] ... | [INFO] [stderr] 64 | | ); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/base.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if self.prod_queue.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.prod_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/base.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(_) = unit { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 83 | | self.prod_queue.remove(0); [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________- help: try this: `if unit.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gui::Gui` [INFO] [stderr] --> src/gui.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Gui { [INFO] [stderr] 15 | | Gui { [INFO] [stderr] 16 | | draw_selection_box: false, [INFO] [stderr] 17 | | selection_box_first_corner: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] 18 | | selection_box_second_corner: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for gui::Gui { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/gui.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if self.draw_selection_box == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.draw_selection_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/gui.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | if self.draw_selection_box == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.draw_selection_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | ) - x_center) / scale + args.width as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:56:41 [INFO] [stderr] | [INFO] [stderr] 56 | ) - y_center) / scale + args.height as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::Map` [INFO] [stderr] --> src/map.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Map { [INFO] [stderr] 42 | | Map { [INFO] [stderr] 43 | | data: HashMap::new(), [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:47:43 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn sort_drones(&mut self, drones: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Drone]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/map.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | if chunk_found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!chunk_found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `dir` is used to index `BORDER_DIRS` [INFO] [stderr] --> src/map.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | for dir in 0..BORDER_DIRS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for (dir, ) in BORDER_DIRS.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/map.rs:72:49 [INFO] [stderr] | [INFO] [stderr] 72 | let ch_dat = self.data.entry(chunk).or_insert(ChunkData::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(ChunkData::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:84:58 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn update_growth(&mut self, dt: f64, drone_list: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Drone]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | f64::atan(worker_count as f64 / 6.0) * 2.0 / PI * (1.0 - ch_d.growth_progress) * dt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(worker_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:117:44 [INFO] [stderr] | [INFO] [stderr] 117 | ch_d.growth_progress -= 0.01 * soldeier_count as f64 * dt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(soldeier_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | ((ch.x as f64 - 0.5) * CHUNK_WIDTH - x_center) / scale + args.width as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(ch.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:172:74 [INFO] [stderr] | [INFO] [stderr] 172 | ((ch.x as f64 - 0.5) * CHUNK_WIDTH - x_center) / scale + args.width as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | ((ch.y as f64 - 0.5) * CHUNK_WIDTH - y_center) / scale + args.height as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(ch.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:173:74 [INFO] [stderr] | [INFO] [stderr] 173 | ((ch.y as f64 - 0.5) * CHUNK_WIDTH - y_center) / scale + args.height as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cui.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn print(resources: f64, prod_queue: &Vec, debug_line: &str) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Order]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/aicontr.rs:21:61 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn step(&mut self, gsd: &mut GameStateData, drones: &Vec, bases: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Drone]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | x: (mouse_s_pos.0 - WIDTH as f64 / 2.0) / scale + x_center, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | y: (mouse_s_pos.1 - HEIGHT as f64 / 2.0) / scale + y_center, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:188:32 [INFO] [stderr] | [INFO] [stderr] 188 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:20 [INFO] [stderr] | [INFO] [stderr] 280 | .trans(s_width as f64 / 2.0, s_height as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(s_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:42 [INFO] [stderr] | [INFO] [stderr] 280 | .trans(s_width as f64 / 2.0, s_height as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(s_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Evade` [INFO] [stderr] --> src/drone/mod.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | Evade(usize, Pos, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `LD41` should have a snake case name such as `ld41` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `drone::Drone` [INFO] [stderr] --> src/drone/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Drone { [INFO] [stderr] 30 | | Drone { [INFO] [stderr] 31 | | id: OBJECT_COUNTER.fetch_add(1, atomic::Ordering::SeqCst), [INFO] [stderr] 32 | | pos: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for drone::Drone { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/drone/mod.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | drone_list: &Vec<(usize, Pos, u8)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, Pos, u8)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/drone/mod.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | if ens.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/drone/mod.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | if enemies.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!enemies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/drone/mod.rs:208:56 [INFO] [stderr] | [INFO] [stderr] 208 | fn get_data_from_drone_list(id: usize, drone_list: &Vec<(usize, Pos, u8)>) -> (usize, Pos, u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, Pos, u8)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/drone/mod.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | drone_list: &Vec<(usize, Pos, u8)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, Pos, u8)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/drone/mod.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / pub fn draw( [INFO] [stderr] 230 | | &self, [INFO] [stderr] 231 | | gl: &mut GlGraphics, [INFO] [stderr] 232 | | c: &Context, [INFO] [stderr] ... | [INFO] [stderr] 251 | | rectangle(::color::team(self.team), square, transform, gl); [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: type `unit_type` should have a camel case name such as `UnitType` [INFO] [stderr] --> src/drone/mod.rs:256:1 [INFO] [stderr] | [INFO] [stderr] 256 | / pub enum unit_type { [INFO] [stderr] 257 | | Worker { cargo: f64 }, [INFO] [stderr] 258 | | Soldier, [INFO] [stderr] 259 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `base::Base` [INFO] [stderr] --> src/base.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Base { [INFO] [stderr] 21 | | Base { [INFO] [stderr] 22 | | pos: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] 23 | | prod_queue: Vec::new(), [INFO] [stderr] 24 | | team: 1, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for base::Base { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/base.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn draw( [INFO] [stderr] 47 | | &self, [INFO] [stderr] 48 | | gl: &mut GlGraphics, [INFO] [stderr] 49 | | c: &Context, [INFO] [stderr] ... | [INFO] [stderr] 64 | | ); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/base.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if self.prod_queue.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.prod_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/base.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(_) = unit { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 83 | | self.prod_queue.remove(0); [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________- help: try this: `if unit.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gui::Gui` [INFO] [stderr] --> src/gui.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Gui { [INFO] [stderr] 15 | | Gui { [INFO] [stderr] 16 | | draw_selection_box: false, [INFO] [stderr] 17 | | selection_box_first_corner: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] 18 | | selection_box_second_corner: Pos { x: 0.0, y: 0.0 }, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for gui::Gui { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/gui.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if self.draw_selection_box == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.draw_selection_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/gui.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | if self.draw_selection_box == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.draw_selection_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | ) - x_center) / scale + args.width as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gui.rs:56:41 [INFO] [stderr] | [INFO] [stderr] 56 | ) - y_center) / scale + args.height as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::Map` [INFO] [stderr] --> src/map.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Map { [INFO] [stderr] 42 | | Map { [INFO] [stderr] 43 | | data: HashMap::new(), [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:47:43 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn sort_drones(&mut self, drones: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Drone]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/map.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | if chunk_found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!chunk_found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `dir` is used to index `BORDER_DIRS` [INFO] [stderr] --> src/map.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | for dir in 0..BORDER_DIRS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for (dir, ) in BORDER_DIRS.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/map.rs:72:49 [INFO] [stderr] | [INFO] [stderr] 72 | let ch_dat = self.data.entry(chunk).or_insert(ChunkData::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(ChunkData::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/map.rs:84:58 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn update_growth(&mut self, dt: f64, drone_list: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Drone]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | f64::atan(worker_count as f64 / 6.0) * 2.0 / PI * (1.0 - ch_d.growth_progress) * dt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(worker_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:117:44 [INFO] [stderr] | [INFO] [stderr] 117 | ch_d.growth_progress -= 0.01 * soldeier_count as f64 * dt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(soldeier_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | ((ch.x as f64 - 0.5) * CHUNK_WIDTH - x_center) / scale + args.width as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(ch.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:172:74 [INFO] [stderr] | [INFO] [stderr] 172 | ((ch.x as f64 - 0.5) * CHUNK_WIDTH - x_center) / scale + args.width as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | ((ch.y as f64 - 0.5) * CHUNK_WIDTH - y_center) / scale + args.height as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(ch.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/map.rs:173:74 [INFO] [stderr] | [INFO] [stderr] 173 | ((ch.y as f64 - 0.5) * CHUNK_WIDTH - y_center) / scale + args.height as f64 / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cui.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn print(resources: f64, prod_queue: &Vec, debug_line: &str) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Order]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/aicontr.rs:21:61 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn step(&mut self, gsd: &mut GameStateData, drones: &Vec, bases: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Drone]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | x: (mouse_s_pos.0 - WIDTH as f64 / 2.0) / scale + x_center, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | y: (mouse_s_pos.1 - HEIGHT as f64 / 2.0) / scale + y_center, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:188:32 [INFO] [stderr] | [INFO] [stderr] 188 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:20 [INFO] [stderr] | [INFO] [stderr] 280 | .trans(s_width as f64 / 2.0, s_height as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(s_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:280:42 [INFO] [stderr] | [INFO] [stderr] 280 | .trans(s_width as f64 / 2.0, s_height as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(s_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 04s [INFO] running `"docker" "inspect" "739c6b4e60b53211bf2b5f3fcc975ef2ec88def2e4e48ddd9361971da09639a1"` [INFO] running `"docker" "rm" "-f" "739c6b4e60b53211bf2b5f3fcc975ef2ec88def2e4e48ddd9361971da09639a1"` [INFO] [stdout] 739c6b4e60b53211bf2b5f3fcc975ef2ec88def2e4e48ddd9361971da09639a1