[INFO] updating cached repository pzmarzly/ffserver-daemon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pzmarzly/ffserver-daemon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pzmarzly/ffserver-daemon" "work/ex/clippy-test-run/sources/stable/gh/pzmarzly/ffserver-daemon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pzmarzly/ffserver-daemon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pzmarzly/ffserver-daemon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pzmarzly/ffserver-daemon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pzmarzly/ffserver-daemon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca4db92313f96b91df82b4dbde2ff9b293fe5852 [INFO] sha for GitHub repo pzmarzly/ffserver-daemon: ca4db92313f96b91df82b4dbde2ff9b293fe5852 [INFO] validating manifest of pzmarzly/ffserver-daemon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pzmarzly/ffserver-daemon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pzmarzly/ffserver-daemon [INFO] finished frobbing pzmarzly/ffserver-daemon [INFO] frobbed toml for pzmarzly/ffserver-daemon written to work/ex/clippy-test-run/sources/stable/gh/pzmarzly/ffserver-daemon/Cargo.toml [INFO] started frobbing pzmarzly/ffserver-daemon [INFO] finished frobbing pzmarzly/ffserver-daemon [INFO] frobbed toml for pzmarzly/ffserver-daemon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pzmarzly/ffserver-daemon/Cargo.toml [INFO] crate pzmarzly/ffserver-daemon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pzmarzly/ffserver-daemon against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pzmarzly/ffserver-daemon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6613e68d3cb45e29e64d5ec15febeba365c2f9d4076ad74ba3682db31e5df15 [INFO] running `"docker" "start" "-a" "f6613e68d3cb45e29e64d5ec15febeba365c2f9d4076ad74ba3682db31e5df15"` [INFO] [stderr] Checking ffserver-daemon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | if n % 180000 == 0 { // 15 minutes [INFO] [stderr] | ^^^^^^ help: consider: `180_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | if n % 180000 == 0 { // 15 minutes [INFO] [stderr] | ^^^^^^ help: consider: `180_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | .filter(|c| *c == ('\n' as u8)) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if let None = self.server { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 27 | | self.server = Some(Command::new("/usr/local/bin/ffserver") [INFO] [stderr] 28 | | .arg("-f").arg("/home/pi/ffserver.conf") [INFO] [stderr] 29 | | .arg("-loglevel").arg("quiet") [INFO] [stderr] ... | [INFO] [stderr] 34 | | thread::sleep(Duration::new(0, 50_000_000)); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________- help: try this: `if self.server.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(_) = self.server { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 43 | | self.server = None; [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________- help: try this: `if self.server.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(_) = self.server { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 48 | | let mut should_run = false; [INFO] [stderr] 49 | | match self.feed { [INFO] [stderr] 50 | | None => should_run = true, [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________- help: try this: `if self.server.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | if let Err(_) = remote.shutdown(Shutdown::Both) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 86 | | //println!("Error disconnecting client"); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________________- help: try this: `if remote.shutdown(Shutdown::Both).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | .filter(|c| *c == ('\n' as u8)) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if let None = self.server { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 27 | | self.server = Some(Command::new("/usr/local/bin/ffserver") [INFO] [stderr] 28 | | .arg("-f").arg("/home/pi/ffserver.conf") [INFO] [stderr] 29 | | .arg("-loglevel").arg("quiet") [INFO] [stderr] ... | [INFO] [stderr] 34 | | thread::sleep(Duration::new(0, 50_000_000)); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________- help: try this: `if self.server.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(_) = self.server { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 43 | | self.server = None; [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________- help: try this: `if self.server.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(_) = self.server { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 48 | | let mut should_run = false; [INFO] [stderr] 49 | | match self.feed { [INFO] [stderr] 50 | | None => should_run = true, [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________- help: try this: `if self.server.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | if let Err(_) = remote.shutdown(Shutdown::Both) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 86 | | //println!("Error disconnecting client"); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________________- help: try this: `if remote.shutdown(Shutdown::Both).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "f6613e68d3cb45e29e64d5ec15febeba365c2f9d4076ad74ba3682db31e5df15"` [INFO] running `"docker" "rm" "-f" "f6613e68d3cb45e29e64d5ec15febeba365c2f9d4076ad74ba3682db31e5df15"` [INFO] [stdout] f6613e68d3cb45e29e64d5ec15febeba365c2f9d4076ad74ba3682db31e5df15