[INFO] updating cached repository pyfisch/boguin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pyfisch/boguin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pyfisch/boguin" "work/ex/clippy-test-run/sources/stable/gh/pyfisch/boguin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pyfisch/boguin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pyfisch/boguin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pyfisch/boguin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pyfisch/boguin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52a0139b1121fd9dd0f9a8932f8b1a196b7a0243 [INFO] sha for GitHub repo pyfisch/boguin: 52a0139b1121fd9dd0f9a8932f8b1a196b7a0243 [INFO] validating manifest of pyfisch/boguin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pyfisch/boguin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pyfisch/boguin [INFO] finished frobbing pyfisch/boguin [INFO] frobbed toml for pyfisch/boguin written to work/ex/clippy-test-run/sources/stable/gh/pyfisch/boguin/Cargo.toml [INFO] started frobbing pyfisch/boguin [INFO] finished frobbing pyfisch/boguin [INFO] frobbed toml for pyfisch/boguin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pyfisch/boguin/Cargo.toml [INFO] crate pyfisch/boguin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pyfisch/boguin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pyfisch/boguin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10f2328d5ac6f77d2903b09a1418dd026437de0ae7f8755440348d56060c60e7 [INFO] running `"docker" "start" "-a" "10f2328d5ac6f77d2903b09a1418dd026437de0ae7f8755440348d56060c60e7"` [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking http-with-url v0.2.0 [INFO] [stderr] Checking boguin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/body.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / return Ok(Body { [INFO] [stderr] 87 | | kind: BodyKind::CloseDelimited, [INFO] [stderr] 88 | | reader, [INFO] [stderr] 89 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 86 | Ok(Body { [INFO] [stderr] 87 | kind: BodyKind::CloseDelimited, [INFO] [stderr] 88 | reader, [INFO] [stderr] 89 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | return self.fetch_redirect(request, counter + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fetch_redirect(request, counter + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | return self.fetch_redirect(request, counter + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fetch_redirect(request, counter + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / return Err(io::Error::new( [INFO] [stderr] 117 | | io::ErrorKind::InvalidInput, [INFO] [stderr] 118 | | Error::WrongScheme, [INFO] [stderr] 119 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 116 | Err(io::Error::new( [INFO] [stderr] 117 | io::ErrorKind::InvalidInput, [INFO] [stderr] 118 | Error::WrongScheme, [INFO] [stderr] 119 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/body.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / return Ok(Body { [INFO] [stderr] 87 | | kind: BodyKind::CloseDelimited, [INFO] [stderr] 88 | | reader, [INFO] [stderr] 89 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 86 | Ok(Body { [INFO] [stderr] 87 | kind: BodyKind::CloseDelimited, [INFO] [stderr] 88 | reader, [INFO] [stderr] 89 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | return self.fetch_redirect(request, counter + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fetch_redirect(request, counter + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | return self.fetch_redirect(request, counter + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fetch_redirect(request, counter + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / return Err(io::Error::new( [INFO] [stderr] 117 | | io::ErrorKind::InvalidInput, [INFO] [stderr] 118 | | Error::WrongScheme, [INFO] [stderr] 119 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 116 | Err(io::Error::new( [INFO] [stderr] 117 | io::ErrorKind::InvalidInput, [INFO] [stderr] 118 | Error::WrongScheme, [INFO] [stderr] 119 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:56:43 [INFO] [stderr] | [INFO] [stderr] 56 | if response.headers.contains_key(&header::TRANSFER_ENCODING) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::borrow_interior_mutable_const)] on by default [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:56:43 [INFO] [stderr] | [INFO] [stderr] 56 | if response.headers.contains_key(&header::TRANSFER_ENCODING) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::borrow_interior_mutable_const)] on by default [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:57:53 [INFO] [stderr] | [INFO] [stderr] 57 | if is_chunked(response.headers.get_all(&header::TRANSFER_ENCODING)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:70:43 [INFO] [stderr] | [INFO] [stderr] 70 | if response.headers.contains_key(&header::CONTENT_LENGTH) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:71:77 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(len) = get_content_length(response.headers.get_all(&header::CONTENT_LENGTH)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:57:53 [INFO] [stderr] | [INFO] [stderr] 57 | if is_chunked(response.headers.get_all(&header::TRANSFER_ENCODING)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:70:43 [INFO] [stderr] | [INFO] [stderr] 70 | if response.headers.contains_key(&header::CONTENT_LENGTH) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/body.rs:71:77 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(len) = get_content_length(response.headers.get_all(&header::CONTENT_LENGTH)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/http1.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | write!(writer, "\r\n{}: {}", header::HOST.as_str(), authority)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/http1.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | writer.write(value.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `boguin`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/http1.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | write!(writer, "\r\n{}: {}", header::HOST.as_str(), authority)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/http1.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | writer.write(value.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `boguin`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "10f2328d5ac6f77d2903b09a1418dd026437de0ae7f8755440348d56060c60e7"` [INFO] running `"docker" "rm" "-f" "10f2328d5ac6f77d2903b09a1418dd026437de0ae7f8755440348d56060c60e7"` [INFO] [stdout] 10f2328d5ac6f77d2903b09a1418dd026437de0ae7f8755440348d56060c60e7