[INFO] updating cached repository pusher-community/pusher-http-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pusher-community/pusher-http-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pusher-community/pusher-http-rust" "work/ex/clippy-test-run/sources/stable/gh/pusher-community/pusher-http-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pusher-community/pusher-http-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pusher-community/pusher-http-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pusher-community/pusher-http-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pusher-community/pusher-http-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2bd448d509eaa3786d0843155a0e2b3c341735f2 [INFO] sha for GitHub repo pusher-community/pusher-http-rust: 2bd448d509eaa3786d0843155a0e2b3c341735f2 [INFO] validating manifest of pusher-community/pusher-http-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pusher-community/pusher-http-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pusher-community/pusher-http-rust [INFO] finished frobbing pusher-community/pusher-http-rust [INFO] frobbed toml for pusher-community/pusher-http-rust written to work/ex/clippy-test-run/sources/stable/gh/pusher-community/pusher-http-rust/Cargo.toml [INFO] started frobbing pusher-community/pusher-http-rust [INFO] finished frobbing pusher-community/pusher-http-rust [INFO] frobbed toml for pusher-community/pusher-http-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pusher-community/pusher-http-rust/Cargo.toml [INFO] crate pusher-community/pusher-http-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pusher-community/pusher-http-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pusher-community/pusher-http-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6a34781e5bd9de6f862f3178478193c2c33a7dcb8f94abafb6817bb5558b98d [INFO] running `"docker" "start" "-a" "a6a34781e5bd9de6f862f3178478193c2c33a7dcb8f94abafb6817bb5558b98d"` [INFO] [stderr] Compiling gcc v0.3.42 [INFO] [stderr] Compiling hyper v0.10.3 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking yup-hyper-mock v2.0.0 [INFO] [stderr] Checking pusher v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:113:7 [INFO] [stderr] | [INFO] [stderr] 113 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:151:7 [INFO] [stderr] | [INFO] [stderr] 151 | secure: secure, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:152:7 [INFO] [stderr] | [INFO] [stderr] 152 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:282:7 [INFO] [stderr] | [INFO] [stderr] 282 | channels: channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:284:7 [INFO] [stderr] | [INFO] [stderr] 284 | socket_id: socket_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `socket_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:113:7 [INFO] [stderr] | [INFO] [stderr] 113 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:151:7 [INFO] [stderr] | [INFO] [stderr] 151 | secure: secure, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:152:7 [INFO] [stderr] | [INFO] [stderr] 152 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:282:7 [INFO] [stderr] | [INFO] [stderr] 282 | channels: channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:284:7 [INFO] [stderr] | [INFO] [stderr] 284 | socket_id: socket_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `socket_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return Err(response.unwrap_err()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(response.unwrap_err())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | StatusCode::Ok => return Ok(body), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Err(format!("Error: {}. {}", res.status, body)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Error: {}. {}", res.status, body))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/request_url.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | const AUTH_VERSION : &'static str = "1.0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_url.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | return query_serializer.finish(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_serializer.finish()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:579:31 [INFO] [stderr] | [INFO] [stderr] 579 | assert_eq!(webhook.time_ms, 1327078148132); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_327_078_148_132` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return Err(response.unwrap_err()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(response.unwrap_err())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | StatusCode::Ok => return Ok(body), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Err(format!("Error: {}. {}", res.status, body)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Error: {}. {}", res.status, body))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/request_url.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | const AUTH_VERSION : &'static str = "1.0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_url.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | return query_serializer.finish(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `query_serializer.finish()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client.rs:104:3 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn new(app_id: &str, key: &str, secret: &str) -> PusherBuilder { [INFO] [stderr] 105 | | let http_client = Client::new(); [INFO] [stderr] 106 | | [INFO] [stderr] 107 | | PusherBuilder { [INFO] [stderr] ... | [INFO] [stderr] 115 | | [INFO] [stderr] 116 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / let mut secure = false; [INFO] [stderr] 139 | | [INFO] [stderr] 140 | | if pusher_url.scheme() == "https" { [INFO] [stderr] 141 | | secure = true; [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let secure = if pusher_url.scheme() == "https" { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/client.rs:243:83 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn trigger_multi(&mut self, channels: &Vec<&str>, event: &str, payload: Payload)-> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/client.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | let channel_strings = channels.into_iter().map(|c| c.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/client.rs:260:93 [INFO] [stderr] | [INFO] [stderr] 260 | pub fn trigger_multi_exclusive(&mut self, channels: &Vec<&str>, event: &str, payload: Payload, socket_id: &str)-> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/client.rs:261:36 [INFO] [stderr] | [INFO] [stderr] 261 | let channel_strings = channels.into_iter().map(|c| c.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client.rs:531:30 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn webhook(&self, key: &String, signature: &String, body: &str) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client.rs:531:50 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn webhook(&self, key: &String, signature: &String, body: &str) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn validate_channels(channels: &Vec)-> Result{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client.rs:104:3 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn new(app_id: &str, key: &str, secret: &str) -> PusherBuilder { [INFO] [stderr] 105 | | let http_client = Client::new(); [INFO] [stderr] 106 | | [INFO] [stderr] 107 | | PusherBuilder { [INFO] [stderr] ... | [INFO] [stderr] 115 | | [INFO] [stderr] 116 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / let mut secure = false; [INFO] [stderr] 139 | | [INFO] [stderr] 140 | | if pusher_url.scheme() == "https" { [INFO] [stderr] 141 | | secure = true; [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let secure = if pusher_url.scheme() == "https" { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/client.rs:243:83 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn trigger_multi(&mut self, channels: &Vec<&str>, event: &str, payload: Payload)-> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/client.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | let channel_strings = channels.into_iter().map(|c| c.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/client.rs:260:93 [INFO] [stderr] | [INFO] [stderr] 260 | pub fn trigger_multi_exclusive(&mut self, channels: &Vec<&str>, event: &str, payload: Payload, socket_id: &str)-> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/client.rs:261:36 [INFO] [stderr] | [INFO] [stderr] 261 | let channel_strings = channels.into_iter().map(|c| c.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client.rs:531:30 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn webhook(&self, key: &String, signature: &String, body: &str) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client.rs:531:50 [INFO] [stderr] | [INFO] [stderr] 531 | pub fn webhook(&self, key: &String, signature: &String, body: &str) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/client.rs:623:5 [INFO] [stderr] | [INFO] [stderr] 623 | channel = channel + "a" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel += "a"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/client.rs:636:5 [INFO] [stderr] | [INFO] [stderr] 636 | data = data + "a" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `data += "a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/client.rs:649:5 [INFO] [stderr] | [INFO] [stderr] 649 | event = event + "a" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `event += "a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn validate_channels(channels: &Vec)-> Result{ [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] extern crate log; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/lib.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | assert_eq!(event_id.get("test_channel").unwrap(), "eudhq1809scss2") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&event_id["test_channel"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/lib.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | let item = channels.channels.get("presence-session-d41a439c438a100756f5-4bf35003e819bb138249-5cbTiUiPNGI").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&channels.channels["presence-session-d41a439c438a100756f5-4bf35003e819bb138249-5cbTiUiPNGI"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.72s [INFO] running `"docker" "inspect" "a6a34781e5bd9de6f862f3178478193c2c33a7dcb8f94abafb6817bb5558b98d"` [INFO] running `"docker" "rm" "-f" "a6a34781e5bd9de6f862f3178478193c2c33a7dcb8f94abafb6817bb5558b98d"` [INFO] [stdout] a6a34781e5bd9de6f862f3178478193c2c33a7dcb8f94abafb6817bb5558b98d