[INFO] updating cached repository ptrckd/AdventOfRust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ptrckd/AdventOfRust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ptrckd/AdventOfRust" "work/ex/clippy-test-run/sources/stable/gh/ptrckd/AdventOfRust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ptrckd/AdventOfRust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ptrckd/AdventOfRust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ptrckd/AdventOfRust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ptrckd/AdventOfRust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f749018aaf31e8b502a8378144f6d90530f5da6b [INFO] sha for GitHub repo ptrckd/AdventOfRust: f749018aaf31e8b502a8378144f6d90530f5da6b [INFO] validating manifest of ptrckd/AdventOfRust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ptrckd/AdventOfRust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ptrckd/AdventOfRust [INFO] finished frobbing ptrckd/AdventOfRust [INFO] frobbed toml for ptrckd/AdventOfRust written to work/ex/clippy-test-run/sources/stable/gh/ptrckd/AdventOfRust/Cargo.toml [INFO] started frobbing ptrckd/AdventOfRust [INFO] finished frobbing ptrckd/AdventOfRust [INFO] frobbed toml for ptrckd/AdventOfRust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ptrckd/AdventOfRust/Cargo.toml [INFO] crate ptrckd/AdventOfRust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ptrckd/AdventOfRust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ptrckd/AdventOfRust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed66b12cbe05fc568d929a3dcb7a39c2e22a10756d26c0fbf47de22d84b83526 [INFO] running `"docker" "start" "-a" "ed66b12cbe05fc568d929a3dcb7a39c2e22a10756d26c0fbf47de22d84b83526"` [INFO] [stderr] Checking AoC v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/bin/day2.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/bin/day2.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: crate `AoC` should have a snake case name such as `ao_c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/day2.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 68 | | if print { [INFO] [stderr] 69 | | print!("{}", x); [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | } else if print { [INFO] [stderr] 68 | print!("{}", x); [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `north_edge` [INFO] [stderr] --> src/bin/day3.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | north_edge: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `east_edge` [INFO] [stderr] --> src/bin/day3.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | east_edge: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width` [INFO] [stderr] --> src/bin/day3.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | width: u32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/bin/day3.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | height: u32, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/day2.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 68 | | if print { [INFO] [stderr] 69 | | print!("{}", x); [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | } else if print { [INFO] [stderr] 68 | print!("{}", x); [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/bin/day2.rs:20:50 [INFO] [stderr] | [INFO] [stderr] 20 | let matches = line.matches(character).collect::>().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day2.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if similar_line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!similar_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/bin/day2.rs:20:50 [INFO] [stderr] | [INFO] [stderr] 20 | let matches = line.matches(character).collect::>().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day2.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if similar_line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!similar_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: crate `AoC` should have a snake case name such as `ao_c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::Duration` [INFO] [stderr] --> src/bin/day4.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::Duration` [INFO] [stderr] --> src/bin/day4.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use chrono::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day4.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | fn is_digit(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day4.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | let minutes_asleep = guard_sleep_times.get(&sleepy_guard).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&guard_sleep_times[&sleepy_guard]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day4.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | fn guard_sleep_time(events: &Vec) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[GuardEvent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day4.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | let mut previous_event = events.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&events[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day4.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | fn is_digit(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day4.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | let minutes_asleep = guard_sleep_times.get(&sleepy_guard).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&guard_sleep_times[&sleepy_guard]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day4.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | fn guard_sleep_time(events: &Vec) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[GuardEvent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day4.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | let mut previous_event = events.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&events[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: field is never used: `north_edge` [INFO] [stderr] --> src/bin/day3.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | north_edge: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `east_edge` [INFO] [stderr] --> src/bin/day3.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | east_edge: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width` [INFO] [stderr] --> src/bin/day3.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | width: u32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/bin/day3.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | height: u32, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.96s [INFO] running `"docker" "inspect" "ed66b12cbe05fc568d929a3dcb7a39c2e22a10756d26c0fbf47de22d84b83526"` [INFO] running `"docker" "rm" "-f" "ed66b12cbe05fc568d929a3dcb7a39c2e22a10756d26c0fbf47de22d84b83526"` [INFO] [stdout] ed66b12cbe05fc568d929a3dcb7a39c2e22a10756d26c0fbf47de22d84b83526