[INFO] updating cached repository psincf/Snake-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/psincf/Snake-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/psincf/Snake-Rust" "work/ex/clippy-test-run/sources/stable/gh/psincf/Snake-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/psincf/Snake-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/psincf/Snake-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Snake-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Snake-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ed6b11af1b1709a4bb3866ec7fad8533e113681f [INFO] sha for GitHub repo psincf/Snake-Rust: ed6b11af1b1709a4bb3866ec7fad8533e113681f [INFO] validating manifest of psincf/Snake-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of psincf/Snake-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing psincf/Snake-Rust [INFO] finished frobbing psincf/Snake-Rust [INFO] frobbed toml for psincf/Snake-Rust written to work/ex/clippy-test-run/sources/stable/gh/psincf/Snake-Rust/Cargo.toml [INFO] started frobbing psincf/Snake-Rust [INFO] finished frobbing psincf/Snake-Rust [INFO] frobbed toml for psincf/Snake-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Snake-Rust/Cargo.toml [INFO] crate psincf/Snake-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting psincf/Snake-Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/psincf/Snake-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35064110ae8d60a494422ae21299a57e1fef16f0789bc366894818673336b873 [INFO] running `"docker" "start" "-a" "35064110ae8d60a494422ae21299a57e1fef16f0789bc366894818673336b873"` [INFO] [stderr] Compiling proc-macro2 v0.4.14 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking stb_truetype v0.2.3 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.54.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.82.0 [INFO] [stderr] Checking snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return App{window, gl}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `App{window, gl}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return Snake{body, direction:Direction::Right, new_direction:Direction::Right}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Snake{body, direction:Direction::Right, new_direction:Direction::Right}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | fn initialize_matrix(ref snake : &Snake) -> Matrix { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | fn new_food(ref mut matrix: &mut Matrix) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / match *state { [INFO] [stderr] 91 | | State::Void => { void_location.push((x, y)); }, [INFO] [stderr] 92 | | _ => { }, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ help: try this: `if let State::Void = *state { void_location.push((x, y)); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | y = y + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:99:8 [INFO] [stderr] | [INFO] [stderr] 99 | if void_location.len() == 0 {return} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `void_location.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | y = y + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | x = x +1; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:158:11 [INFO] [stderr] | [INFO] [stderr] 158 | fn update(ref mut snake: &mut Snake, ref mut matrix: &mut Matrix, ref mut now: &mut std::time::Instant) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:158:38 [INFO] [stderr] | [INFO] [stderr] 158 | fn update(ref mut snake: &mut Snake, ref mut matrix: &mut Matrix, ref mut now: &mut std::time::Instant) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:158:67 [INFO] [stderr] | [INFO] [stderr] 158 | fn update(ref mut snake: &mut Snake, ref mut matrix: &mut Matrix, ref mut now: &mut std::time::Instant) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:172:15 [INFO] [stderr] | [INFO] [stderr] 172 | fn move_snake(ref mut snake:&mut Snake, ref mut matrix:&mut Matrix) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:172:41 [INFO] [stderr] | [INFO] [stderr] 172 | fn move_snake(ref mut snake:&mut Snake, ref mut matrix:&mut Matrix) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:175:26 [INFO] [stderr] | [INFO] [stderr] 175 | Direction::Up => snake_head.1 = snake_head.1 - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.1 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | Direction::Down => snake_head.1 = snake_head.1 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.1 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | Direction::Left => snake_head.0 = snake_head.0 - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.0 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | Direction::Right => snake_head.0 = snake_head.0 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.0 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return App{window, gl}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `App{window, gl}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return Snake{body, direction:Direction::Right, new_direction:Direction::Right}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Snake{body, direction:Direction::Right, new_direction:Direction::Right}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | fn initialize_matrix(ref snake : &Snake) -> Matrix { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | fn new_food(ref mut matrix: &mut Matrix) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / match *state { [INFO] [stderr] 91 | | State::Void => { void_location.push((x, y)); }, [INFO] [stderr] 92 | | _ => { }, [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ help: try this: `if let State::Void = *state { void_location.push((x, y)); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | y = y + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:99:8 [INFO] [stderr] | [INFO] [stderr] 99 | if void_location.len() == 0 {return} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `void_location.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | y = y + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | x = x +1; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:158:11 [INFO] [stderr] | [INFO] [stderr] 158 | fn update(ref mut snake: &mut Snake, ref mut matrix: &mut Matrix, ref mut now: &mut std::time::Instant) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:158:38 [INFO] [stderr] | [INFO] [stderr] 158 | fn update(ref mut snake: &mut Snake, ref mut matrix: &mut Matrix, ref mut now: &mut std::time::Instant) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:158:67 [INFO] [stderr] | [INFO] [stderr] 158 | fn update(ref mut snake: &mut Snake, ref mut matrix: &mut Matrix, ref mut now: &mut std::time::Instant) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:172:15 [INFO] [stderr] | [INFO] [stderr] 172 | fn move_snake(ref mut snake:&mut Snake, ref mut matrix:&mut Matrix) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:172:41 [INFO] [stderr] | [INFO] [stderr] 172 | fn move_snake(ref mut snake:&mut Snake, ref mut matrix:&mut Matrix) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:175:26 [INFO] [stderr] | [INFO] [stderr] 175 | Direction::Up => snake_head.1 = snake_head.1 - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.1 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | Direction::Down => snake_head.1 = snake_head.1 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.1 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | Direction::Left => snake_head.0 = snake_head.0 - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.0 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | Direction::Right => snake_head.0 = snake_head.0 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_head.0 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 42s [INFO] running `"docker" "inspect" "35064110ae8d60a494422ae21299a57e1fef16f0789bc366894818673336b873"` [INFO] running `"docker" "rm" "-f" "35064110ae8d60a494422ae21299a57e1fef16f0789bc366894818673336b873"` [INFO] [stdout] 35064110ae8d60a494422ae21299a57e1fef16f0789bc366894818673336b873