[INFO] updating cached repository psincf/Pathfinding-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/psincf/Pathfinding-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/psincf/Pathfinding-Rust" "work/ex/clippy-test-run/sources/stable/gh/psincf/Pathfinding-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/psincf/Pathfinding-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/psincf/Pathfinding-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Pathfinding-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Pathfinding-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5790fc11eaf361504c1e21a406b1946c92c1073 [INFO] sha for GitHub repo psincf/Pathfinding-Rust: b5790fc11eaf361504c1e21a406b1946c92c1073 [INFO] validating manifest of psincf/Pathfinding-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of psincf/Pathfinding-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing psincf/Pathfinding-Rust [INFO] finished frobbing psincf/Pathfinding-Rust [INFO] frobbed toml for psincf/Pathfinding-Rust written to work/ex/clippy-test-run/sources/stable/gh/psincf/Pathfinding-Rust/Cargo.toml [INFO] started frobbing psincf/Pathfinding-Rust [INFO] finished frobbing psincf/Pathfinding-Rust [INFO] frobbed toml for psincf/Pathfinding-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Pathfinding-Rust/Cargo.toml [INFO] crate psincf/Pathfinding-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting psincf/Pathfinding-Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/psincf/Pathfinding-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ec3bc608c1940005f9e7faf49b14717efb25b99c8e2931b1caafbc0c14836c3 [INFO] running `"docker" "start" "-a" "8ec3bc608c1940005f9e7faf49b14717efb25b99c8e2931b1caafbc0c14836c3"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.76 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking piston2d-opengl_graphics v0.54.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.82.0 [INFO] [stderr] Checking path_finding v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:217:119 [INFO] [stderr] | [INFO] [stderr] 217 | matrix_point[new_point.x as usize][new_point.y as usize] = MatrixPoint{previous_point: point.clone(), length: length, total_length: total_length }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:217:135 [INFO] [stderr] | [INFO] [stderr] 217 | matrix_point[new_point.x as usize][new_point.y as usize] = MatrixPoint{previous_point: point.clone(), length: length, total_length: total_length }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:217:119 [INFO] [stderr] | [INFO] [stderr] 217 | matrix_point[new_point.x as usize][new_point.y as usize] = MatrixPoint{previous_point: point.clone(), length: length, total_length: total_length }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:217:135 [INFO] [stderr] | [INFO] [stderr] 217 | matrix_point[new_point.x as usize][new_point.y as usize] = MatrixPoint{previous_point: point.clone(), length: length, total_length: total_length }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return App{window, gl}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `App{window, gl}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | return length; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | [DENSITY * index_x as f64, DENSITY * index_y as f64, DENSITY , DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:70 [INFO] [stderr] | [INFO] [stderr] 86 | [DENSITY * index_x as f64, DENSITY * index_y as f64, DENSITY , DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:88:33 [INFO] [stderr] | [INFO] [stderr] 88 | index_y = index_y + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_y += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | index_x = index_x + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | [unit.location.x as f64 * DENSITY, unit.location.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.location.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:64 [INFO] [stderr] | [INFO] [stderr] 93 | [unit.location.x as f64 * DENSITY, unit.location.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.location.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:30 [INFO] [stderr] | [INFO] [stderr] 96 | [unit.direction.x as f64 * DENSITY, unit.direction.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.direction.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:65 [INFO] [stderr] | [INFO] [stderr] 96 | [unit.direction.x as f64 * DENSITY, unit.direction.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.direction.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | if true_or_false == true { alpha = 0.3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `true_or_false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | if drawing == false { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!drawing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | mouse_scroll = mouse_scroll + e[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mouse_scroll += e[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / match e { [INFO] [stderr] 158 | | Button::Mouse(MouseButton::Left) => { [INFO] [stderr] 159 | | drawing = false; [INFO] [stderr] 160 | | }, [INFO] [stderr] 161 | | _ => (), [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Button::Mouse(MouseButton::Left) = e { [INFO] [stderr] 158 | drawing = false; [INFO] [stderr] 159 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:19 [INFO] [stderr] | [INFO] [stderr] 166 | fn update(matrix: &Vec>, unit: &mut Unit) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:169:8 [INFO] [stderr] | [INFO] [stderr] 169 | if unit.path.len()!=0 { unit.location = unit.path[0].clone(); unit.path.remove(0); return; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!unit.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if possibilities.len() == 0 { return; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possibilities.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | / let mut length:f64; [INFO] [stderr] 207 | | if x == 0 || y == 0 { length = 1.0f64; } [INFO] [stderr] 208 | | else { length = 2.0f64.sqrt(); } [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let length = if x == 0 || y == 0 { 1.0f64 } else { 2.0f64.sqrt() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | if matrix[new_point.x as usize][new_point.y as usize] == false { continue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!matrix[new_point.x as usize][new_point.y as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | length = matrix_point[point.x as usize][point.y as usize].length + length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += matrix_point[point.x as usize][point.y as usize].length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | if possibilities.len() == 0 { possibilities.push(new_point.clone()); continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possibilities.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:241:19 [INFO] [stderr] | [INFO] [stderr] 241 | fn length_between(ref point1: &Point, ref point2: &Point) -> f64 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:241:39 [INFO] [stderr] | [INFO] [stderr] 241 | fn length_between(ref point1: &Point, ref point2: &Point) -> f64 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:242:23 [INFO] [stderr] | [INFO] [stderr] 242 | let delta_x:f64 = point1.x as f64 - point2.x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point1.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | let delta_x:f64 = point1.x as f64 - point2.x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point2.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:243:23 [INFO] [stderr] | [INFO] [stderr] 243 | let delta_y:f64 = point1.y as f64 - point2.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point1.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:243:41 [INFO] [stderr] | [INFO] [stderr] 243 | let delta_y:f64 = point1.y as f64 - point2.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point2.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | return App{window, gl}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `App{window, gl}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | return length; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | [DENSITY * index_x as f64, DENSITY * index_y as f64, DENSITY , DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:70 [INFO] [stderr] | [INFO] [stderr] 86 | [DENSITY * index_x as f64, DENSITY * index_y as f64, DENSITY , DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:88:33 [INFO] [stderr] | [INFO] [stderr] 88 | index_y = index_y + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_y += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | index_x = index_x + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | [unit.location.x as f64 * DENSITY, unit.location.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.location.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:64 [INFO] [stderr] | [INFO] [stderr] 93 | [unit.location.x as f64 * DENSITY, unit.location.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.location.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:30 [INFO] [stderr] | [INFO] [stderr] 96 | [unit.direction.x as f64 * DENSITY, unit.direction.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.direction.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:65 [INFO] [stderr] | [INFO] [stderr] 96 | [unit.direction.x as f64 * DENSITY, unit.direction.y as f64 * DENSITY, DENSITY, DENSITY], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.direction.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | if true_or_false == true { alpha = 0.3} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `true_or_false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | if drawing == false { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!drawing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | mouse_scroll = mouse_scroll + e[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mouse_scroll += e[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / match e { [INFO] [stderr] 158 | | Button::Mouse(MouseButton::Left) => { [INFO] [stderr] 159 | | drawing = false; [INFO] [stderr] 160 | | }, [INFO] [stderr] 161 | | _ => (), [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let Button::Mouse(MouseButton::Left) = e { [INFO] [stderr] 158 | drawing = false; [INFO] [stderr] 159 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:19 [INFO] [stderr] | [INFO] [stderr] 166 | fn update(matrix: &Vec>, unit: &mut Unit) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:169:8 [INFO] [stderr] | [INFO] [stderr] 169 | if unit.path.len()!=0 { unit.location = unit.path[0].clone(); unit.path.remove(0); return; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!unit.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if possibilities.len() == 0 { return; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possibilities.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | / let mut length:f64; [INFO] [stderr] 207 | | if x == 0 || y == 0 { length = 1.0f64; } [INFO] [stderr] 208 | | else { length = 2.0f64.sqrt(); } [INFO] [stderr] | |________________________________________________^ help: it is more idiomatic to write: `let length = if x == 0 || y == 0 { 1.0f64 } else { 2.0f64.sqrt() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | if matrix[new_point.x as usize][new_point.y as usize] == false { continue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!matrix[new_point.x as usize][new_point.y as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | length = matrix_point[point.x as usize][point.y as usize].length + length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += matrix_point[point.x as usize][point.y as usize].length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | if possibilities.len() == 0 { possibilities.push(new_point.clone()); continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possibilities.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:241:19 [INFO] [stderr] | [INFO] [stderr] 241 | fn length_between(ref point1: &Point, ref point2: &Point) -> f64 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:241:39 [INFO] [stderr] | [INFO] [stderr] 241 | fn length_between(ref point1: &Point, ref point2: &Point) -> f64 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:242:23 [INFO] [stderr] | [INFO] [stderr] 242 | let delta_x:f64 = point1.x as f64 - point2.x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point1.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | let delta_x:f64 = point1.x as f64 - point2.x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point2.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:243:23 [INFO] [stderr] | [INFO] [stderr] 243 | let delta_y:f64 = point1.y as f64 - point2.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point1.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:243:41 [INFO] [stderr] | [INFO] [stderr] 243 | let delta_y:f64 = point1.y as f64 - point2.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(point2.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 37s [INFO] running `"docker" "inspect" "8ec3bc608c1940005f9e7faf49b14717efb25b99c8e2931b1caafbc0c14836c3"` [INFO] running `"docker" "rm" "-f" "8ec3bc608c1940005f9e7faf49b14717efb25b99c8e2931b1caafbc0c14836c3"` [INFO] [stdout] 8ec3bc608c1940005f9e7faf49b14717efb25b99c8e2931b1caafbc0c14836c3