[INFO] updating cached repository psincf/Multithreaded-Game-of-Life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/psincf/Multithreaded-Game-of-Life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/psincf/Multithreaded-Game-of-Life" "work/ex/clippy-test-run/sources/stable/gh/psincf/Multithreaded-Game-of-Life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/psincf/Multithreaded-Game-of-Life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/psincf/Multithreaded-Game-of-Life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Multithreaded-Game-of-Life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Multithreaded-Game-of-Life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6dc0062fe5ea5f1f252a3863e3bbb0eeda413b85 [INFO] sha for GitHub repo psincf/Multithreaded-Game-of-Life: 6dc0062fe5ea5f1f252a3863e3bbb0eeda413b85 [INFO] validating manifest of psincf/Multithreaded-Game-of-Life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of psincf/Multithreaded-Game-of-Life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing psincf/Multithreaded-Game-of-Life [INFO] finished frobbing psincf/Multithreaded-Game-of-Life [INFO] frobbed toml for psincf/Multithreaded-Game-of-Life written to work/ex/clippy-test-run/sources/stable/gh/psincf/Multithreaded-Game-of-Life/Cargo.toml [INFO] started frobbing psincf/Multithreaded-Game-of-Life [INFO] finished frobbing psincf/Multithreaded-Game-of-Life [INFO] frobbed toml for psincf/Multithreaded-Game-of-Life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/psincf/Multithreaded-Game-of-Life/Cargo.toml [INFO] crate psincf/Multithreaded-Game-of-Life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting psincf/Multithreaded-Game-of-Life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/psincf/Multithreaded-Game-of-Life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50648780cc3eba681899da4035bb1c863c1d02bbec8ebea09f4e7147d07bd00b [INFO] running `"docker" "start" "-a" "50648780cc3eba681899da4035bb1c863c1d02bbec8ebea09f4e7147d07bd00b"` [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if max_x == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `max_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if max_y == true { return vec_block; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `thread_id` is only used to index `vec_txbis`. [INFO] [stderr] --> src/main.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | for thread_id in 0..THREAD_NUMBER as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for in vec_txbis.iter().take(THREAD_NUMBER as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:146:38 [INFO] [stderr] | [INFO] [stderr] 146 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `thread_id` is only used to index `vec_txbis`. [INFO] [stderr] --> src/main.rs:160:30 [INFO] [stderr] | [INFO] [stderr] 160 | for thread_id in 0..THREAD_NUMBER as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 160 | for in vec_txbis.iter().take(THREAD_NUMBER as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:169:38 [INFO] [stderr] | [INFO] [stderr] 169 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | tick = tick + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `tick += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:41 [INFO] [stderr] | [INFO] [stderr] 184 | let tick_per_second: u32 = (tick as f64 / (duration.as_secs() as f64 + duration.subsec_millis() as f64 / 1000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(tick)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:84 [INFO] [stderr] | [INFO] [stderr] 184 | let tick_per_second: u32 = (tick as f64 / (duration.as_secs() as f64 + duration.subsec_millis() as f64 / 1000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `arc_vec_renderer` [INFO] [stderr] --> src/main.rs:203:18 [INFO] [stderr] | [INFO] [stderr] 203 | for x in 0..arc_vec_renderer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 203 | for (x, ) in arc_vec_renderer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:205:20 [INFO] [stderr] | [INFO] [stderr] 205 | if arc_vec_renderer[x][y].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec_renderer[x][y].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:254:24 [INFO] [stderr] | [INFO] [stderr] 254 | if arc_vec[x_minus][y_minus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_minus][y_minus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:257:24 [INFO] [stderr] | [INFO] [stderr] 257 | if arc_vec[x_minus][y].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_minus][y].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:258:25 [INFO] [stderr] | [INFO] [stderr] 258 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | if arc_vec[x_minus][y_plus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_minus][y_plus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:261:25 [INFO] [stderr] | [INFO] [stderr] 261 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:263:24 [INFO] [stderr] | [INFO] [stderr] 263 | if arc_vec[x][y_plus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x][y_plus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:264:25 [INFO] [stderr] | [INFO] [stderr] 264 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:266:24 [INFO] [stderr] | [INFO] [stderr] 266 | if arc_vec[x_plus][y_plus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_plus][y_plus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:267:25 [INFO] [stderr] | [INFO] [stderr] 267 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | if arc_vec[x_plus][y].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_plus][y].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:272:24 [INFO] [stderr] | [INFO] [stderr] 272 | if arc_vec[x_plus][y_minus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_plus][y_minus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:273:25 [INFO] [stderr] | [INFO] [stderr] 273 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:275:24 [INFO] [stderr] | [INFO] [stderr] 275 | if arc_vec[x][y_minus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x][y_minus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:276:25 [INFO] [stderr] | [INFO] [stderr] 276 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `arc_vec` [INFO] [stderr] --> src/main.rs:294:22 [INFO] [stderr] | [INFO] [stderr] 294 | for x in x_min..x_max { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 294 | for (x, ) in arc_vec.iter().enumerate().take(x_max).skip(x_min) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if max_x == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `max_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if max_y == true { return vec_block; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `thread_id` is only used to index `vec_txbis`. [INFO] [stderr] --> src/main.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | for thread_id in 0..THREAD_NUMBER as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for in vec_txbis.iter().take(THREAD_NUMBER as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:146:38 [INFO] [stderr] | [INFO] [stderr] 146 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `thread_id` is only used to index `vec_txbis`. [INFO] [stderr] --> src/main.rs:160:30 [INFO] [stderr] | [INFO] [stderr] 160 | for thread_id in 0..THREAD_NUMBER as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 160 | for in vec_txbis.iter().take(THREAD_NUMBER as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:169:38 [INFO] [stderr] | [INFO] [stderr] 169 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | block_count = block_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | if received.1 >= 0 { block_received_count = block_received_count + 1 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_received_count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | tick = tick + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `tick += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:41 [INFO] [stderr] | [INFO] [stderr] 184 | let tick_per_second: u32 = (tick as f64 / (duration.as_secs() as f64 + duration.subsec_millis() as f64 / 1000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(tick)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:84 [INFO] [stderr] | [INFO] [stderr] 184 | let tick_per_second: u32 = (tick as f64 / (duration.as_secs() as f64 + duration.subsec_millis() as f64 / 1000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `arc_vec_renderer` [INFO] [stderr] --> src/main.rs:203:18 [INFO] [stderr] | [INFO] [stderr] 203 | for x in 0..arc_vec_renderer.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 203 | for (x, ) in arc_vec_renderer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:205:20 [INFO] [stderr] | [INFO] [stderr] 205 | if arc_vec_renderer[x][y].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec_renderer[x][y].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:254:24 [INFO] [stderr] | [INFO] [stderr] 254 | if arc_vec[x_minus][y_minus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_minus][y_minus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:257:24 [INFO] [stderr] | [INFO] [stderr] 257 | if arc_vec[x_minus][y].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_minus][y].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:258:25 [INFO] [stderr] | [INFO] [stderr] 258 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | if arc_vec[x_minus][y_plus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_minus][y_plus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:261:25 [INFO] [stderr] | [INFO] [stderr] 261 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:263:24 [INFO] [stderr] | [INFO] [stderr] 263 | if arc_vec[x][y_plus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x][y_plus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:264:25 [INFO] [stderr] | [INFO] [stderr] 264 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:266:24 [INFO] [stderr] | [INFO] [stderr] 266 | if arc_vec[x_plus][y_plus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_plus][y_plus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:267:25 [INFO] [stderr] | [INFO] [stderr] 267 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | if arc_vec[x_plus][y].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_plus][y].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:272:24 [INFO] [stderr] | [INFO] [stderr] 272 | if arc_vec[x_plus][y_minus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x_plus][y_minus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:273:25 [INFO] [stderr] | [INFO] [stderr] 273 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:275:24 [INFO] [stderr] | [INFO] [stderr] 275 | if arc_vec[x][y_minus].live.load(Ordering::Relaxed) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `arc_vec[x][y_minus].live.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:276:25 [INFO] [stderr] | [INFO] [stderr] 276 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `arc_vec` [INFO] [stderr] --> src/main.rs:294:22 [INFO] [stderr] | [INFO] [stderr] 294 | for x in x_min..x_max { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 294 | for (x, ) in arc_vec.iter().enumerate().take(x_max).skip(x_min) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.74s [INFO] running `"docker" "inspect" "50648780cc3eba681899da4035bb1c863c1d02bbec8ebea09f4e7147d07bd00b"` [INFO] running `"docker" "rm" "-f" "50648780cc3eba681899da4035bb1c863c1d02bbec8ebea09f4e7147d07bd00b"` [INFO] [stdout] 50648780cc3eba681899da4035bb1c863c1d02bbec8ebea09f4e7147d07bd00b