[INFO] updating cached repository pshc/cantide [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pshc/cantide [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pshc/cantide" "work/ex/clippy-test-run/sources/stable/gh/pshc/cantide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pshc/cantide'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pshc/cantide" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pshc/cantide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pshc/cantide'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7b9c0c12732a37e2416f4b2a57fbdb14cd9af96 [INFO] sha for GitHub repo pshc/cantide: d7b9c0c12732a37e2416f4b2a57fbdb14cd9af96 [INFO] validating manifest of pshc/cantide on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pshc/cantide on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pshc/cantide [INFO] finished frobbing pshc/cantide [INFO] frobbed toml for pshc/cantide written to work/ex/clippy-test-run/sources/stable/gh/pshc/cantide/Cargo.toml [INFO] started frobbing pshc/cantide [INFO] finished frobbing pshc/cantide [INFO] frobbed toml for pshc/cantide written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pshc/cantide/Cargo.toml [INFO] crate pshc/cantide has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pshc/cantide against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pshc/cantide:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69fe564c5de2b35171a691c0a8fb970414659f4333f8e52f5d6b2b502c1cd808 [INFO] running `"docker" "start" "-a" "69fe564c5de2b35171a691c0a8fb970414659f4333f8e52f5d6b2b502c1cd808"` [INFO] [stderr] Compiling typenum v1.5.2 [INFO] [stderr] Compiling openssl v0.9.14 [INFO] [stderr] Checking constant_time_eq v0.1.2 [INFO] [stderr] Checking cfg-if v0.1.1 [INFO] [stderr] Checking md5 v0.3.5 [INFO] [stderr] Checking num-traits v0.1.39 [INFO] [stderr] Compiling openssl-sys v0.9.14 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking stringprep v0.1.0 [INFO] [stderr] Checking backtrace-sys v0.1.11 [INFO] [stderr] Checking bytes v0.4.4 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking generic-array v0.7.2 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking digest-buffer v0.3.1 [INFO] [stderr] Checking crypto-mac v0.3.0 [INFO] [stderr] Checking digest v0.5.2 [INFO] [stderr] Checking sha2 v0.5.3 [INFO] [stderr] Checking hmac v0.1.1 [INFO] [stderr] Checking postgres-protocol v0.3.0 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking postgres-shared v0.3.0 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking irc v0.12.2 [INFO] [stderr] Checking postgres v0.14.2 [INFO] [stderr] Checking cantide v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | / if let &Some(ref bye) = part_msg { [INFO] [stderr] 55 | | println!("* {} left {} ({})", nick, chan, bye); [INFO] [stderr] 56 | | } else { [INFO] [stderr] 57 | | println!("* {} left {}", nick, chan); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(ref bye) = *part_msg { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | / if let &Some(ref bye) = quit_msg { [INFO] [stderr] 70 | | println!("* {} quit ({})", nick, bye); [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | println!("* {} quit", nick); [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(ref bye) = *quit_msg { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:102:30 [INFO] [stderr] | [INFO] [stderr] 102 | if !text.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / error_chain! { [INFO] [stderr] 121 | | errors { NoIdea NoResult } [INFO] [stderr] 122 | | foreign_links { [INFO] [stderr] 123 | | Irc(irc::error::Error); [INFO] [stderr] 124 | | Postgres(postgres::error::Error); [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn have_a_cow<'a>(e: Error) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | / if let &Some(ref bye) = part_msg { [INFO] [stderr] 55 | | println!("* {} left {} ({})", nick, chan, bye); [INFO] [stderr] 56 | | } else { [INFO] [stderr] 57 | | println!("* {} left {}", nick, chan); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:181:19 [INFO] [stderr] | [INFO] [stderr] 181 | let url = env::var("DATABASE_URL").ok().expect("Missing DATABASE_URL"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | let a = words.get(1).map(|&word| word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `words.get(1).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(ref bye) = *part_msg { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | / if let &Some(ref bye) = quit_msg { [INFO] [stderr] 70 | | println!("* {} quit ({})", nick, bye); [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | println!("* {} quit", nick); [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(ref bye) = *quit_msg { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:215:19 [INFO] [stderr] | [INFO] [stderr] 215 | let channel = env::var("IRC_CHANNEL").ok().expect("Missing IRC_CHANNEL"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:102:30 [INFO] [stderr] | [INFO] [stderr] 102 | if !text.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / error_chain! { [INFO] [stderr] 121 | | errors { NoIdea NoResult } [INFO] [stderr] 122 | | foreign_links { [INFO] [stderr] 123 | | Irc(irc::error::Error); [INFO] [stderr] 124 | | Postgres(postgres::error::Error); [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | let ref mut cantide = Cantide { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 233 | let cantide = &mut Cantide { [INFO] [stderr] 234 | brain: Mutex::new(brain), [INFO] [stderr] 235 | channel, [INFO] [stderr] 236 | irc: server, [INFO] [stderr] 237 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn have_a_cow<'a>(e: Error) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:181:19 [INFO] [stderr] | [INFO] [stderr] 181 | let url = env::var("DATABASE_URL").ok().expect("Missing DATABASE_URL"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | let a = words.get(1).map(|&word| word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `words.get(1).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:215:19 [INFO] [stderr] | [INFO] [stderr] 215 | let channel = env::var("IRC_CHANNEL").ok().expect("Missing IRC_CHANNEL"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | let ref mut cantide = Cantide { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 233 | let cantide = &mut Cantide { [INFO] [stderr] 234 | brain: Mutex::new(brain), [INFO] [stderr] 235 | channel, [INFO] [stderr] 236 | irc: server, [INFO] [stderr] 237 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.52s [INFO] running `"docker" "inspect" "69fe564c5de2b35171a691c0a8fb970414659f4333f8e52f5d6b2b502c1cd808"` [INFO] running `"docker" "rm" "-f" "69fe564c5de2b35171a691c0a8fb970414659f4333f8e52f5d6b2b502c1cd808"` [INFO] [stdout] 69fe564c5de2b35171a691c0a8fb970414659f4333f8e52f5d6b2b502c1cd808