[INFO] updating cached repository prmejc/AdventOfCode2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/prmejc/AdventOfCode2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/prmejc/AdventOfCode2016" "work/ex/clippy-test-run/sources/stable/gh/prmejc/AdventOfCode2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/prmejc/AdventOfCode2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/prmejc/AdventOfCode2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prmejc/AdventOfCode2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prmejc/AdventOfCode2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5d2e234183a18b10b1e47e2ab22f4ae6cfc6253f [INFO] sha for GitHub repo prmejc/AdventOfCode2016: 5d2e234183a18b10b1e47e2ab22f4ae6cfc6253f [INFO] validating manifest of prmejc/AdventOfCode2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prmejc/AdventOfCode2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prmejc/AdventOfCode2016 [INFO] finished frobbing prmejc/AdventOfCode2016 [INFO] frobbed toml for prmejc/AdventOfCode2016 written to work/ex/clippy-test-run/sources/stable/gh/prmejc/AdventOfCode2016/Cargo.toml [INFO] started frobbing prmejc/AdventOfCode2016 [INFO] finished frobbing prmejc/AdventOfCode2016 [INFO] frobbed toml for prmejc/AdventOfCode2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prmejc/AdventOfCode2016/Cargo.toml [INFO] crate prmejc/AdventOfCode2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prmejc/AdventOfCode2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/prmejc/AdventOfCode2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 146ef607f07ea6544cfdca038af3564cae3b64e5622dd3024d3b418e584a5fae [INFO] running `"docker" "start" "-a" "146ef607f07ea6544cfdca038af3564cae3b64e5622dd3024d3b418e584a5fae"` [INFO] [stderr] Checking advent2016 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return (test,id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(test,id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | return (false, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/mod.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return (test,id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(test,id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | return (false, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(false, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/mod.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `checksum` [INFO] [stderr] --> src/day4.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | let checksum = room.split("[").last().unwrap().replace("]",""); [INFO] [stderr] | ^^^^^^^^ help: consider using `_checksum` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `part1` [INFO] [stderr] --> src/day4.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn part1(){ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_a_room` [INFO] [stderr] --> src/day4.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn is_a_room(room: &str) -> (bool, i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | .split("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | let name = room.split("[").next().unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | let checksum = room.split("[").last().unwrap().replace("]",""); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | .split("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let name = room.split("[").next().unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | let checksum = room.split("[").last().unwrap().replace("]",""); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util/mod.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / match file.read_to_string(&mut s) { [INFO] [stderr] 21 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 22 | | why.description()), [INFO] [stderr] 23 | | Ok(_) => (), [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 21 | why.description()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `checksum` [INFO] [stderr] --> src/day4.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | let checksum = room.split("[").last().unwrap().replace("]",""); [INFO] [stderr] | ^^^^^^^^ help: consider using `_checksum` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `part1` [INFO] [stderr] --> src/day4.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn part1(){ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_a_room` [INFO] [stderr] --> src/day4.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn is_a_room(room: &str) -> (bool, i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | .split("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | let name = room.split("[").next().unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | let checksum = room.split("[").last().unwrap().replace("]",""); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | .split("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let name = room.split("[").next().unwrap() [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | let id = room.split("[").next().unwrap().split("-").last().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | let checksum = room.split("[").last().unwrap().replace("]",""); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util/mod.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / match file.read_to_string(&mut s) { [INFO] [stderr] 21 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 22 | | why.description()), [INFO] [stderr] 23 | | Ok(_) => (), [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 21 | why.description()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "146ef607f07ea6544cfdca038af3564cae3b64e5622dd3024d3b418e584a5fae"` [INFO] running `"docker" "rm" "-f" "146ef607f07ea6544cfdca038af3564cae3b64e5622dd3024d3b418e584a5fae"` [INFO] [stdout] 146ef607f07ea6544cfdca038af3564cae3b64e5622dd3024d3b418e584a5fae