[INFO] updating cached repository prakhar1989/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/prakhar1989/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/prakhar1989/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/prakhar1989/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/prakhar1989/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/prakhar1989/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prakhar1989/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prakhar1989/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 801634031ea2197439c5778b6239b30f73406fc0 [INFO] sha for GitHub repo prakhar1989/advent-of-code-2018: 801634031ea2197439c5778b6239b30f73406fc0 [INFO] validating manifest of prakhar1989/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prakhar1989/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prakhar1989/advent-of-code-2018 [INFO] finished frobbing prakhar1989/advent-of-code-2018 [INFO] frobbed toml for prakhar1989/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/prakhar1989/advent-of-code-2018/Cargo.toml [INFO] started frobbing prakhar1989/advent-of-code-2018 [INFO] finished frobbing prakhar1989/advent-of-code-2018 [INFO] frobbed toml for prakhar1989/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prakhar1989/advent-of-code-2018/Cargo.toml [INFO] crate prakhar1989/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prakhar1989/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/prakhar1989/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d93aeffc3b9d20255976f0a6947aa301a5daea170927b033a8ae929f41e3e8ab [INFO] running `"docker" "start" "-a" "d93aeffc3b9d20255976f0a6947aa301a5daea170927b033a8ae929f41e3e8ab"` [INFO] [stderr] Checking md5 v0.6.0 [INFO] [stderr] Checking toml v0.4.9 [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | let b = if (j as isize) - 1 >= 0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/day11.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let c = if (i as isize) - 1 >= 0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/scaffold.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | let day = env::args() [INFO] [stderr] | _______________^ [INFO] [stderr] 25 | | .skip(1) [INFO] [stderr] 26 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/day11.rs:90:16 [INFO] [stderr] | [INFO] [stderr] 90 | let a = if (i as isize) - 1 >= 0 && (j as isize) - 1 >= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 90 | let a = if (i as isize) > 0 && (j as isize) - 1 >= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/day11.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | let a = if (i as isize) - 1 >= 0 && (j as isize) - 1 >= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 90 | let a = if (i as isize) - 1 >= 0 && (j as isize) > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/day11.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | let b = if (j as isize) - 1 >= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 96 | let b = if (j as isize) > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/day11.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | let c = if (i as isize) - 1 >= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 102 | let c = if (i as isize) > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:35:34 [INFO] [stderr] | [INFO] [stderr] 35 | fn closest_to(&self, points: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | fn total_distance(&self, points: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | fn grid_size(points: &Vec) -> (usize, usize, usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | fn part1(points: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | fn part2(points: &Vec, within_area: i32) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:35:34 [INFO] [stderr] | [INFO] [stderr] 35 | fn closest_to(&self, points: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | fn total_distance(&self, points: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | fn grid_size(points: &Vec) -> (usize, usize, usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | fn part1(points: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day06.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | fn part2(points: &Vec, within_area: i32) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day07.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | fn part1(deps: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Dep]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day07.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | fn get_sorted_steps(deps: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Dep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day07.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | fn unvisited_steps(steps: &Vec, deps: &Vec, visited: &HashSet) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Step]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day07.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | fn unvisited_steps(steps: &Vec, deps: &Vec, visited: &HashSet) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Dep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/scaffold.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | let day = env::args() [INFO] [stderr] | _______________^ [INFO] [stderr] 25 | | .skip(1) [INFO] [stderr] 26 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/day07.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / steps [INFO] [stderr] 67 | | .into_iter() [INFO] [stderr] 68 | | .filter(|id| !visited.contains(id)) // not yet visited [INFO] [stderr] 69 | | .filter(|id| { [INFO] [stderr] ... | [INFO] [stderr] 74 | | }) [INFO] [stderr] 75 | | .map(|c| *c) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 66 | steps [INFO] [stderr] 67 | .into_iter() [INFO] [stderr] 68 | .filter(|id| !visited.contains(id)) // not yet visited [INFO] [stderr] 69 | .filter(|id| { [INFO] [stderr] 70 | // all deps have been visited [INFO] [stderr] 71 | deps.iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day07.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(m[(1, 1)], 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(m[(1, 1)], 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(m[(0, 0)], 33.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(m[(0, 0)], 33.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(m[(1, 0)], 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(m[(1, 0)], 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(m[(1, 2)], 11.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(m[(1, 2)], 11.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/matrix.rs:111:41 [INFO] [stderr] | [INFO] [stderr] 111 | .flat_map(|r| r.into_iter()) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 112 | | .fold(0, |acc, val| acc + val); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(m[(1, 1)], 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(m[(1, 1)], 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(m[(0, 0)], 33.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(m[(0, 0)], 33.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(m[(1, 0)], 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(m[(1, 0)], 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(m[(1, 2)], 11.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(m[(1, 2)], 11.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/day03.rs:32:51 [INFO] [stderr] | [INFO] [stderr] 32 | None => return Err(Box::::from(format!("invalid format for claim"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"invalid format for claim".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/matrix.rs:111:41 [INFO] [stderr] | [INFO] [stderr] 111 | .flat_map(|r| r.into_iter()) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 112 | | .fold(0, |acc, val| acc + val); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day03.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | fn build_grid(claims: &Vec) -> matrix::Matrix { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day03.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | fn part1(claims: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day03.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | fn part2(claims: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent-of-code-2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent-of-code-2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day14.rs:2:34 [INFO] [stderr] | [INFO] [stderr] 2 | println!("Part 1: {}", part1(290431)); [INFO] [stderr] | ^^^^^^ help: consider: `290_431` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/day14.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / if recipies.len() - offset >= target.len() { [INFO] [stderr] 35 | | if &recipies[recipies.len() - target.len() - offset..recipies.len() - offset] [INFO] [stderr] 36 | | == target [INFO] [stderr] 37 | | { [INFO] [stderr] 38 | | return recipies.len() - target.len() - offset; [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if recipies.len() - offset >= target.len() && &recipies[recipies.len() - target.len() - offset..recipies.len() - offset] [INFO] [stderr] 35 | == target { [INFO] [stderr] 36 | return recipies.len() - target.len() - offset; [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day14.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(part1(290431), "1776718175".to_string()); [INFO] [stderr] | ^^^^^^ help: consider: `290_431` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day05.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 15 | | if let Some(v) = stack.pop() { [INFO] [stderr] 16 | | if !(v != c && c.to_ascii_uppercase() == v.to_ascii_uppercase()) { [INFO] [stderr] 17 | | stack.push(v); [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | } else if let Some(v) = stack.pop() { [INFO] [stderr] 15 | if !(v != c && c.to_ascii_uppercase() == v.to_ascii_uppercase()) { [INFO] [stderr] 16 | stack.push(v); [INFO] [stderr] 17 | stack.push(c); [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day14.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day14.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | number = number / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day14.rs:2:34 [INFO] [stderr] | [INFO] [stderr] 2 | println!("Part 1: {}", part1(290431)); [INFO] [stderr] | ^^^^^^ help: consider: `290_431` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/day14.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / if recipies.len() - offset >= target.len() { [INFO] [stderr] 35 | | if &recipies[recipies.len() - target.len() - offset..recipies.len() - offset] [INFO] [stderr] 36 | | == target [INFO] [stderr] 37 | | { [INFO] [stderr] 38 | | return recipies.len() - target.len() - offset; [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if recipies.len() - offset >= target.len() && &recipies[recipies.len() - target.len() - offset..recipies.len() - offset] [INFO] [stderr] 35 | == target { [INFO] [stderr] 36 | return recipies.len() - target.len() - offset; [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/day14.rs:76:26 [INFO] [stderr] | [INFO] [stderr] 76 | assert_eq!(part2(&vec![5, 1, 5, 8, 9]), 9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[5, 1, 5, 8, 9]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/day14.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(part2(&vec![0, 1, 2, 4, 5]), 5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 2, 4, 5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/day14.rs:78:26 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(part2(&vec![9, 2, 5, 1, 0]), 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[9, 2, 5, 1, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/day14.rs:79:26 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(part2(&vec![5, 9, 4, 1, 4]), 2018); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[5, 9, 4, 1, 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day14.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day14.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | number = number / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day02.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | fn part1(words: &Vec<&str>) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day02.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | fn part2(words: &Vec<&str>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | fn tick_points(points: &Vec, time: i32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | fn area_of_grid(points: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/day10.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | (ymax - ymin) as i64 * (xmax - xmin) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(ymax - ymin)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/day10.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | (ymax - ymin) as i64 * (xmax - xmin) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(xmax - xmin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | fn draw_grid(points: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | fn grid_size(points: &Vec) -> (Vector, Vector) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(m[(1, 1)], 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(m[(1, 1)], 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(m[(0, 0)], 33.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(m[(0, 0)], 33.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(m[(1, 0)], 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(m[(1, 0)], 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrix.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(m[(1, 2)], 11.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrix.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(m[(1, 2)], 11.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/matrix.rs:111:41 [INFO] [stderr] | [INFO] [stderr] 111 | .flat_map(|r| r.into_iter()) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 112 | | .fold(0, |acc, val| acc + val); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | fn tick_points(points: &Vec, time: i32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | fn area_of_grid(points: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/day10.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | (ymax - ymin) as i64 * (xmax - xmin) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(ymax - ymin)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/day10.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | (ymax - ymin) as i64 * (xmax - xmin) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(xmax - xmin)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | fn draw_grid(points: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | fn grid_size(points: &Vec) -> (Vector, Vector) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent-of-code-2018`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d93aeffc3b9d20255976f0a6947aa301a5daea170927b033a8ae929f41e3e8ab"` [INFO] running `"docker" "rm" "-f" "d93aeffc3b9d20255976f0a6947aa301a5daea170927b033a8ae929f41e3e8ab"` [INFO] [stdout] d93aeffc3b9d20255976f0a6947aa301a5daea170927b033a8ae929f41e3e8ab