[INFO] updating cached repository portaloffreedom/rustline [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/portaloffreedom/rustline [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/portaloffreedom/rustline" "work/ex/clippy-test-run/sources/stable/gh/portaloffreedom/rustline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/portaloffreedom/rustline'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/portaloffreedom/rustline" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/portaloffreedom/rustline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/portaloffreedom/rustline'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 69b9cd53d43f01be4332a1fe3aa79dfb3ff809f9 [INFO] sha for GitHub repo portaloffreedom/rustline: 69b9cd53d43f01be4332a1fe3aa79dfb3ff809f9 [INFO] validating manifest of portaloffreedom/rustline on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of portaloffreedom/rustline on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing portaloffreedom/rustline [INFO] finished frobbing portaloffreedom/rustline [INFO] frobbed toml for portaloffreedom/rustline written to work/ex/clippy-test-run/sources/stable/gh/portaloffreedom/rustline/Cargo.toml [INFO] started frobbing portaloffreedom/rustline [INFO] finished frobbing portaloffreedom/rustline [INFO] frobbed toml for portaloffreedom/rustline written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/portaloffreedom/rustline/Cargo.toml [INFO] crate portaloffreedom/rustline has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting portaloffreedom/rustline against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/portaloffreedom/rustline:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 979eb2cbda3e206002da2ccb1c8ef9878acde25137cc1a230a67fa7560e2353f [INFO] running `"docker" "start" "-a" "979eb2cbda3e206002da2ccb1c8ef9878acde25137cc1a230a67fa7560e2353f"` [INFO] [stderr] Checking libc v0.2.19 [INFO] [stderr] Compiling cmake v0.1.20 [INFO] [stderr] Compiling libz-sys v1.0.10 [INFO] [stderr] Compiling curl-sys v0.3.6 [INFO] [stderr] Checking url v1.2.4 [INFO] [stderr] Compiling libssh2-sys v0.2.5 [INFO] [stderr] Compiling libgit2-sys v0.6.11 [INFO] [stderr] Checking openssl-sys v0.9.6 [INFO] [stderr] Checking termion v1.3.0 [INFO] [stderr] Checking git2 v0.6.5 [INFO] [stderr] Checking rustline v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | write!(cout, "Error unsupported option: \"{}\"\n", argument_command).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | write!(cout, "Error unsupported option: \"{}\"\n", argument_command).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / match Repository::discover(dir) { [INFO] [stderr] 106 | | Ok(repo) => { [INFO] [stderr] 107 | | match repo.head() { [INFO] [stderr] 108 | | Ok(reference) => { [INFO] [stderr] ... | [INFO] [stderr] 157 | | Err(_) => {}, [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Ok(repo) = Repository::discover(dir) { [INFO] [stderr] 106 | match repo.head() { [INFO] [stderr] 107 | Ok(reference) => { [INFO] [stderr] 108 | let reference = reference; [INFO] [stderr] 109 | let reference = match reference.shorthand() { [INFO] [stderr] 110 | Some(name) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match repo.head() { [INFO] [stderr] 108 | | Ok(reference) => { [INFO] [stderr] 109 | | let reference = reference; [INFO] [stderr] 110 | | let reference = match reference.shorthand() { [INFO] [stderr] ... | [INFO] [stderr] 154 | | Err(_) => {}, [INFO] [stderr] 155 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let Ok(reference) = repo.head() { [INFO] [stderr] 108 | let reference = reference; [INFO] [stderr] 109 | let reference = match reference.shorthand() { [INFO] [stderr] 110 | Some(name) => { [INFO] [stderr] 111 | name [INFO] [stderr] 112 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / match Repository::discover(dir) { [INFO] [stderr] 106 | | Ok(repo) => { [INFO] [stderr] 107 | | match repo.head() { [INFO] [stderr] 108 | | Ok(reference) => { [INFO] [stderr] ... | [INFO] [stderr] 157 | | Err(_) => {}, [INFO] [stderr] 158 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Ok(repo) = Repository::discover(dir) { [INFO] [stderr] 106 | match repo.head() { [INFO] [stderr] 107 | Ok(reference) => { [INFO] [stderr] 108 | let reference = reference; [INFO] [stderr] 109 | let reference = match reference.shorthand() { [INFO] [stderr] 110 | Some(name) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match repo.head() { [INFO] [stderr] 108 | | Ok(reference) => { [INFO] [stderr] 109 | | let reference = reference; [INFO] [stderr] 110 | | let reference = match reference.shorthand() { [INFO] [stderr] ... | [INFO] [stderr] 154 | | Err(_) => {}, [INFO] [stderr] 155 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let Ok(reference) = repo.head() { [INFO] [stderr] 108 | let reference = reference; [INFO] [stderr] 109 | let reference = match reference.shorthand() { [INFO] [stderr] 110 | Some(name) => { [INFO] [stderr] 111 | name [INFO] [stderr] 112 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 53s [INFO] running `"docker" "inspect" "979eb2cbda3e206002da2ccb1c8ef9878acde25137cc1a230a67fa7560e2353f"` [INFO] running `"docker" "rm" "-f" "979eb2cbda3e206002da2ccb1c8ef9878acde25137cc1a230a67fa7560e2353f"` [INFO] [stdout] 979eb2cbda3e206002da2ccb1c8ef9878acde25137cc1a230a67fa7560e2353f