[INFO] updating cached repository porglezomp/celestial-echo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/porglezomp/celestial-echo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/porglezomp/celestial-echo" "work/ex/clippy-test-run/sources/stable/gh/porglezomp/celestial-echo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/porglezomp/celestial-echo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/porglezomp/celestial-echo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/porglezomp/celestial-echo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/porglezomp/celestial-echo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d43577462ce66678d2145bafc4e6d57780cf5135 [INFO] sha for GitHub repo porglezomp/celestial-echo: d43577462ce66678d2145bafc4e6d57780cf5135 [INFO] validating manifest of porglezomp/celestial-echo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of porglezomp/celestial-echo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing porglezomp/celestial-echo [INFO] finished frobbing porglezomp/celestial-echo [INFO] frobbed toml for porglezomp/celestial-echo written to work/ex/clippy-test-run/sources/stable/gh/porglezomp/celestial-echo/Cargo.toml [INFO] started frobbing porglezomp/celestial-echo [INFO] finished frobbing porglezomp/celestial-echo [INFO] frobbed toml for porglezomp/celestial-echo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/porglezomp/celestial-echo/Cargo.toml [INFO] crate porglezomp/celestial-echo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting porglezomp/celestial-echo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/porglezomp/celestial-echo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05e4f9b65b01a40ea05655d4c2e4d0359c2f6596ce96475ccc169c41cdb2c771 [INFO] running `"docker" "start" "-a" "05e4f9b65b01a40ea05655d4c2e4d0359c2f6596ce96475ccc169c41cdb2c771"` [INFO] [stderr] Compiling libsqlite3-sys v0.9.1 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Compiling diesel_derives v1.1.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking sha-1 v0.4.1 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking mio v0.6.12 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking diesel v1.1.1 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.14 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking egg-mode v0.12.0 [INFO] [stderr] Checking celestial-echo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | / return Ok(Response::RecordForm(EventForm { [INFO] [stderr] 170 | | tweet_id: tweet.id as i64, [INFO] [stderr] 171 | | celestial_body: body, [INFO] [stderr] 172 | | replied: false, [INFO] [stderr] 173 | | deadline: deadline.naive_utc(), [INFO] [stderr] 174 | | round_trip: travel_secs, [INFO] [stderr] 175 | | })); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 169 | Ok(Response::RecordForm(EventForm { [INFO] [stderr] 170 | tweet_id: tweet.id as i64, [INFO] [stderr] 171 | celestial_body: body, [INFO] [stderr] 172 | replied: false, [INFO] [stderr] 173 | deadline: deadline.naive_utc(), [INFO] [stderr] 174 | round_trip: travel_secs, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / return Ok(Response::Reply(DraftTweet::new( [INFO] [stderr] 179 | | r#"Sorry, I don't recognize that location. [INFO] [stderr] 180 | | [INFO] [stderr] 181 | | Consult JPL HORIZONS for valid options: https://ssd.jpl.nasa.gov/?horizons [INFO] [stderr] 182 | | "#, [INFO] [stderr] 183 | | ))); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | Ok(Response::Reply(DraftTweet::new( [INFO] [stderr] 179 | r#"Sorry, I don't recognize that location. [INFO] [stderr] 180 | [INFO] [stderr] 181 | Consult JPL HORIZONS for valid options: https://ssd.jpl.nasa.gov/?horizons [INFO] [stderr] 182 | "#, [INFO] [stderr] 183 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | return Ok(Response::Reply(DraftTweet::new(message))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::Reply(DraftTweet::new(message)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | return Err(format_err!("Unrecognized exit code: {:?}", code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("Unrecognized exit code: {:?}", code))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | / return Ok(Response::RecordForm(EventForm { [INFO] [stderr] 170 | | tweet_id: tweet.id as i64, [INFO] [stderr] 171 | | celestial_body: body, [INFO] [stderr] 172 | | replied: false, [INFO] [stderr] 173 | | deadline: deadline.naive_utc(), [INFO] [stderr] 174 | | round_trip: travel_secs, [INFO] [stderr] 175 | | })); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 169 | Ok(Response::RecordForm(EventForm { [INFO] [stderr] 170 | tweet_id: tweet.id as i64, [INFO] [stderr] 171 | celestial_body: body, [INFO] [stderr] 172 | replied: false, [INFO] [stderr] 173 | deadline: deadline.naive_utc(), [INFO] [stderr] 174 | round_trip: travel_secs, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / return Ok(Response::Reply(DraftTweet::new( [INFO] [stderr] 179 | | r#"Sorry, I don't recognize that location. [INFO] [stderr] 180 | | [INFO] [stderr] 181 | | Consult JPL HORIZONS for valid options: https://ssd.jpl.nasa.gov/?horizons [INFO] [stderr] 182 | | "#, [INFO] [stderr] 183 | | ))); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | Ok(Response::Reply(DraftTweet::new( [INFO] [stderr] 179 | r#"Sorry, I don't recognize that location. [INFO] [stderr] 180 | [INFO] [stderr] 181 | Consult JPL HORIZONS for valid options: https://ssd.jpl.nasa.gov/?horizons [INFO] [stderr] 182 | "#, [INFO] [stderr] 183 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | return Ok(Response::Reply(DraftTweet::new(message))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::Reply(DraftTweet::new(message)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | return Err(format_err!("Unrecognized exit code: {:?}", code)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("Unrecognized exit code: {:?}", code))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.22s [INFO] running `"docker" "inspect" "05e4f9b65b01a40ea05655d4c2e4d0359c2f6596ce96475ccc169c41cdb2c771"` [INFO] running `"docker" "rm" "-f" "05e4f9b65b01a40ea05655d4c2e4d0359c2f6596ce96475ccc169c41cdb2c771"` [INFO] [stdout] 05e4f9b65b01a40ea05655d4c2e4d0359c2f6596ce96475ccc169c41cdb2c771