[INFO] updating cached repository pontakornth/rust-passwordgenerator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pontakornth/rust-passwordgenerator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pontakornth/rust-passwordgenerator" "work/ex/clippy-test-run/sources/stable/gh/pontakornth/rust-passwordgenerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pontakornth/rust-passwordgenerator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pontakornth/rust-passwordgenerator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontakornth/rust-passwordgenerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontakornth/rust-passwordgenerator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d3232e88f632ea6b4dbed613ef8d5f45e1492d6f [INFO] sha for GitHub repo pontakornth/rust-passwordgenerator: d3232e88f632ea6b4dbed613ef8d5f45e1492d6f [INFO] validating manifest of pontakornth/rust-passwordgenerator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pontakornth/rust-passwordgenerator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pontakornth/rust-passwordgenerator [INFO] finished frobbing pontakornth/rust-passwordgenerator [INFO] frobbed toml for pontakornth/rust-passwordgenerator written to work/ex/clippy-test-run/sources/stable/gh/pontakornth/rust-passwordgenerator/Cargo.toml [INFO] started frobbing pontakornth/rust-passwordgenerator [INFO] finished frobbing pontakornth/rust-passwordgenerator [INFO] frobbed toml for pontakornth/rust-passwordgenerator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontakornth/rust-passwordgenerator/Cargo.toml [INFO] crate pontakornth/rust-passwordgenerator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pontakornth/rust-passwordgenerator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pontakornth/rust-passwordgenerator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4ba21f0404ff7755e137ab0e509cf6b49a456dd1af698859ecb9f7b5e915239 [INFO] running `"docker" "start" "-a" "d4ba21f0404ff7755e137ab0e509cf6b49a456dd1af698859ecb9f7b5e915239"` [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking passwordgen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return password_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | let all : Vec = String::from(format!("{}{}{}{}",lowercase,uppercase,listnumber,other)).chars().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}{}{}{}",lowercase,uppercase,listnumber,other)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return password_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | let all : Vec = String::from(format!("{}{}{}{}",lowercase,uppercase,listnumber,other)).chars().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}{}{}{}",lowercase,uppercase,listnumber,other)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.05s [INFO] running `"docker" "inspect" "d4ba21f0404ff7755e137ab0e509cf6b49a456dd1af698859ecb9f7b5e915239"` [INFO] running `"docker" "rm" "-f" "d4ba21f0404ff7755e137ab0e509cf6b49a456dd1af698859ecb9f7b5e915239"` [INFO] [stdout] d4ba21f0404ff7755e137ab0e509cf6b49a456dd1af698859ecb9f7b5e915239