[INFO] updating cached repository polachok/test-tokio-fairness [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/polachok/test-tokio-fairness [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/polachok/test-tokio-fairness" "work/ex/clippy-test-run/sources/stable/gh/polachok/test-tokio-fairness"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/polachok/test-tokio-fairness'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/polachok/test-tokio-fairness" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/polachok/test-tokio-fairness"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/polachok/test-tokio-fairness'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dcc70c553cf8e3a08b6739a2280a7b235d63386c [INFO] sha for GitHub repo polachok/test-tokio-fairness: dcc70c553cf8e3a08b6739a2280a7b235d63386c [INFO] validating manifest of polachok/test-tokio-fairness on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of polachok/test-tokio-fairness on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing polachok/test-tokio-fairness [INFO] finished frobbing polachok/test-tokio-fairness [INFO] frobbed toml for polachok/test-tokio-fairness written to work/ex/clippy-test-run/sources/stable/gh/polachok/test-tokio-fairness/Cargo.toml [INFO] started frobbing polachok/test-tokio-fairness [INFO] finished frobbing polachok/test-tokio-fairness [INFO] frobbed toml for polachok/test-tokio-fairness written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/polachok/test-tokio-fairness/Cargo.toml [INFO] crate polachok/test-tokio-fairness has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting polachok/test-tokio-fairness against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/polachok/test-tokio-fairness:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 582eb2beb6c53c8315020c9bc6edbeb12a5db708ccc221b7c454d97b1b6b7768 [INFO] running `"docker" "start" "-a" "582eb2beb6c53c8315020c9bc6edbeb12a5db708ccc221b7c454d97b1b6b7768"` [INFO] [stderr] Compiling tsc v0.1.0 [INFO] [stderr] Checking scheduler v0.1.3 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking parking_lot_core v0.3.0 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking test-tokio-fairness v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:234:2 [INFO] [stderr] | [INFO] [stderr] 234 | serve [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | let serve = server.incoming().map_err(|e| panic!("{}", e)).for_each(move |stream| { [INFO] [stderr] | _________________^ [INFO] [stderr] 213 | | let process = loop_fn((stream, tx.clone()), |(stream, mut tx)| { [INFO] [stderr] 214 | | let buf = [0;16]; [INFO] [stderr] 215 | | read_exact(stream, buf).and_then(move |(stream, buf)| { [INFO] [stderr] ... | [INFO] [stderr] 232 | | tokio::spawn(process) [INFO] [stderr] 233 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:252:2 [INFO] [stderr] | [INFO] [stderr] 252 | conn [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | let conn = TcpStream::connect(&(([127, 0, 0, 1], 9000).into())) [INFO] [stderr] | ________________^ [INFO] [stderr] 239 | | .and_then(move |stream| loop_fn((stream, 0u64), move |(stream, count)| { [INFO] [stderr] 240 | | let buf = { [INFO] [stderr] 241 | | let mut buf = [0;16]; [INFO] [stderr] ... | [INFO] [stderr] 250 | | write_all(stream, buf).and_then(move |(stream, _)| Ok(Loop::Continue((stream, count+1)))) [INFO] [stderr] 251 | | })).map_err(|e| panic!("{}", e)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:230:47 [INFO] [stderr] | [INFO] [stderr] 230 | }).or_else(move |err| { panic!("{}", err); Ok(Loop::Break(())) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | use mio::net::{TcpListener, TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:234:2 [INFO] [stderr] | [INFO] [stderr] 234 | serve [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | let serve = server.incoming().map_err(|e| panic!("{}", e)).for_each(move |stream| { [INFO] [stderr] | _________________^ [INFO] [stderr] 213 | | let process = loop_fn((stream, tx.clone()), |(stream, mut tx)| { [INFO] [stderr] 214 | | let buf = [0;16]; [INFO] [stderr] 215 | | read_exact(stream, buf).and_then(move |(stream, buf)| { [INFO] [stderr] ... | [INFO] [stderr] 232 | | tokio::spawn(process) [INFO] [stderr] 233 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:252:2 [INFO] [stderr] | [INFO] [stderr] 252 | conn [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | let conn = TcpStream::connect(&(([127, 0, 0, 1], 9000).into())) [INFO] [stderr] | ________________^ [INFO] [stderr] 239 | | .and_then(move |stream| loop_fn((stream, 0u64), move |(stream, count)| { [INFO] [stderr] 240 | | let buf = { [INFO] [stderr] 241 | | let mut buf = [0;16]; [INFO] [stderr] ... | [INFO] [stderr] 250 | | write_all(stream, buf).and_then(move |(stream, _)| Ok(Loop::Continue((stream, count+1)))) [INFO] [stderr] 251 | | })).map_err(|e| panic!("{}", e)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/main.rs:230:47 [INFO] [stderr] | [INFO] [stderr] 230 | }).or_else(move |err| { panic!("{}", err); Ok(Loop::Break(())) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.99s [INFO] running `"docker" "inspect" "582eb2beb6c53c8315020c9bc6edbeb12a5db708ccc221b7c454d97b1b6b7768"` [INFO] running `"docker" "rm" "-f" "582eb2beb6c53c8315020c9bc6edbeb12a5db708ccc221b7c454d97b1b6b7768"` [INFO] [stdout] 582eb2beb6c53c8315020c9bc6edbeb12a5db708ccc221b7c454d97b1b6b7768