[INFO] updating cached repository poga/streaming-data-parsing-with-actix-lua [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/poga/streaming-data-parsing-with-actix-lua [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/poga/streaming-data-parsing-with-actix-lua" "work/ex/clippy-test-run/sources/stable/gh/poga/streaming-data-parsing-with-actix-lua"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/poga/streaming-data-parsing-with-actix-lua'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/poga/streaming-data-parsing-with-actix-lua" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poga/streaming-data-parsing-with-actix-lua"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poga/streaming-data-parsing-with-actix-lua'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 948dc8283670f4df8e6ecc6d030eddd3d59dee69 [INFO] sha for GitHub repo poga/streaming-data-parsing-with-actix-lua: 948dc8283670f4df8e6ecc6d030eddd3d59dee69 [INFO] validating manifest of poga/streaming-data-parsing-with-actix-lua on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of poga/streaming-data-parsing-with-actix-lua on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing poga/streaming-data-parsing-with-actix-lua [INFO] finished frobbing poga/streaming-data-parsing-with-actix-lua [INFO] frobbed toml for poga/streaming-data-parsing-with-actix-lua written to work/ex/clippy-test-run/sources/stable/gh/poga/streaming-data-parsing-with-actix-lua/Cargo.toml [INFO] started frobbing poga/streaming-data-parsing-with-actix-lua [INFO] finished frobbing poga/streaming-data-parsing-with-actix-lua [INFO] frobbed toml for poga/streaming-data-parsing-with-actix-lua written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poga/streaming-data-parsing-with-actix-lua/Cargo.toml [INFO] crate poga/streaming-data-parsing-with-actix-lua has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting poga/streaming-data-parsing-with-actix-lua against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/poga/streaming-data-parsing-with-actix-lua:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] def577afb8384bca5f51d167fa70a75182821bccfbb27b3d5601fbca984d11ed [INFO] running `"docker" "start" "-a" "def577afb8384bca5f51d167fa70a75182821bccfbb27b3d5601fbca984d11ed"` [INFO] [stderr] Checking lazycell v1.1.0 [INFO] [stderr] Compiling serde v1.0.78 [INFO] [stderr] Compiling actix-web v0.7.7 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling rlua v0.15.2 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-current-thread v0.1.1 [INFO] [stderr] Checking tokio-timer v0.2.6 [INFO] [stderr] Checking http v0.1.12 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking ring v0.13.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking openssl v0.10.12 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking crossbeam-channel v0.2.5 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking native-tls v0.2.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking tokio-tls v0.2.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.4 [INFO] [stderr] Checking actix-lua v0.4.0 [INFO] [stderr] Checking poe-api v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | if let Some(_) = stashes.get(stash_id) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 92 | | // diff [INFO] [stderr] 93 | | let mut next_items = HashSet::new(); [INFO] [stderr] 94 | | for item in stash["items"].as_array().unwrap() { [INFO] [stderr] ... | [INFO] [stderr] 146 | | ON_ADD.do_send(LuaMessage::from(stash.to_string())); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________- help: try this: `if stashes.get(stash_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(_) = new_items.get(&item_key) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 117 | | new_item_stash_items.push(item.clone()); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________________- help: try this: `if new_items.get(&item_key).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(_) = removed_items.get(&item_key) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 121 | | removed_item_stash_items.push(item.clone()); [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________________- help: try this: `if removed_items.get(&item_key).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | if new_item_stash_items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!new_item_stash_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | if removed_item_stash_items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!removed_item_stash_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | if let Some(_) = stashes.get(stash_id) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 92 | | // diff [INFO] [stderr] 93 | | let mut next_items = HashSet::new(); [INFO] [stderr] 94 | | for item in stash["items"].as_array().unwrap() { [INFO] [stderr] ... | [INFO] [stderr] 146 | | ON_ADD.do_send(LuaMessage::from(stash.to_string())); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________- help: try this: `if stashes.get(stash_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(_) = new_items.get(&item_key) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 117 | | new_item_stash_items.push(item.clone()); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________________- help: try this: `if new_items.get(&item_key).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(_) = removed_items.get(&item_key) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 121 | | removed_item_stash_items.push(item.clone()); [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________________- help: try this: `if removed_items.get(&item_key).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | if new_item_stash_items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!new_item_stash_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | if removed_item_stash_items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!removed_item_stash_items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "def577afb8384bca5f51d167fa70a75182821bccfbb27b3d5601fbca984d11ed"` [INFO] running `"docker" "rm" "-f" "def577afb8384bca5f51d167fa70a75182821bccfbb27b3d5601fbca984d11ed"` [INFO] [stdout] def577afb8384bca5f51d167fa70a75182821bccfbb27b3d5601fbca984d11ed