[INFO] updating cached repository pmll/fin-sdl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pmll/fin-sdl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pmll/fin-sdl" "work/ex/clippy-test-run/sources/stable/gh/pmll/fin-sdl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pmll/fin-sdl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pmll/fin-sdl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmll/fin-sdl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmll/fin-sdl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c4dc8cbf72bb5b8c2b7609a4261eb441885f53c [INFO] sha for GitHub repo pmll/fin-sdl: 0c4dc8cbf72bb5b8c2b7609a4261eb441885f53c [INFO] validating manifest of pmll/fin-sdl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pmll/fin-sdl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pmll/fin-sdl [INFO] finished frobbing pmll/fin-sdl [INFO] frobbed toml for pmll/fin-sdl written to work/ex/clippy-test-run/sources/stable/gh/pmll/fin-sdl/Cargo.toml [INFO] started frobbing pmll/fin-sdl [INFO] finished frobbing pmll/fin-sdl [INFO] frobbed toml for pmll/fin-sdl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmll/fin-sdl/Cargo.toml [INFO] crate pmll/fin-sdl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pmll/fin-sdl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pmll/fin-sdl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b874ce19173818dcf8bc0cc753c84d34aa0bc8ccfb1d59663067ae7dbe867fe1 [INFO] running `"docker" "start" "-a" "b874ce19173818dcf8bc0cc753c84d34aa0bc8ccfb1d59663067ae7dbe867fe1"` [INFO] [stderr] Checking find_folder v0.3.0 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking fin-sdl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/text.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | r: u8, g: u8, b: u8, a: u8, str: &str) { [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/text.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | r: u8, g: u8, b: u8, a: u8, str: &str) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/text.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | r: u8, g: u8, b: u8, a: u8, str: &str) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/text.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | r: u8, g: u8, b: u8, a: u8, str: &str) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/letter_bricks.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / if self.ship.alive() { [INFO] [stderr] 249 | | if self.bombs.collision(self.ship.area()) { [INFO] [stderr] 250 | | self.ship.kill(&mut self.animations); [INFO] [stderr] 251 | | } [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 248 | if self.ship.alive() && self.bombs.collision(self.ship.area()) { [INFO] [stderr] 249 | self.ship.kill(&mut self.animations); [INFO] [stderr] 250 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Bonus` [INFO] [stderr] --> src/bonus_bomb.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / enum BombType { [INFO] [stderr] 22 | | Bonus10, [INFO] [stderr] 23 | | Bonus30, [INFO] [stderr] 24 | | Bonus50, [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spiders.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spiders.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bombs.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bombs.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/animation.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | ((frames_left * 255 / 100)) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ship.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/letter_bricks.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / if self.ship.alive() { [INFO] [stderr] 249 | | if self.bombs.collision(self.ship.area()) { [INFO] [stderr] 250 | | self.ship.kill(&mut self.animations); [INFO] [stderr] 251 | | } [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 248 | if self.ship.alive() && self.bombs.collision(self.ship.area()) { [INFO] [stderr] 249 | self.ship.kill(&mut self.animations); [INFO] [stderr] 250 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Bonus` [INFO] [stderr] --> src/bonus_bomb.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / enum BombType { [INFO] [stderr] 22 | | Bonus10, [INFO] [stderr] 23 | | Bonus30, [INFO] [stderr] 24 | | Bonus50, [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spiders.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spiders.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bombs.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bombs.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/animation.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | ((frames_left * 255 / 100)) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ship.rs:185:68 [INFO] [stderr] | [INFO] [stderr] 185 | self.ship_image[0].render_resize(canvas, self.x + ((Ship::life_x(self.lives + 1) - self.x) as f64 * (1.0 - n)) as i32, SHIP_Y + ((LIVES_Y - SHIP_Y) as f64 * (1.0 - n)) as i32, 0.5 + 0.5 * n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ship::life_x(self.lives + 1) - self.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ship.rs:185:146 [INFO] [stderr] | [INFO] [stderr] 185 | self.ship_image[0].render_resize(canvas, self.x + ((Ship::life_x(self.lives + 1) - self.x) as f64 * (1.0 - n)) as i32, SHIP_Y + ((LIVES_Y - SHIP_Y) as f64 * (1.0 - n)) as i32, 0.5 + 0.5 * n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(LIVES_Y - SHIP_Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/letter_bricks.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | for i in self.letter_range[letter][row][0]..self.letter_range[letter][row][1] + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.letter_range[letter][row][0]..=self.letter_range[letter][row][1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/letter_bricks.rs:197:32 [INFO] [stderr] | [INFO] [stderr] 197 | if ! (self.letter_brick[k].filled || self.letter_brick[k].targetted) && [INFO] [stderr] | ________________________________^ [INFO] [stderr] 198 | | ! (self.targetted_to_left(k) || self.targetted_to_right(k)) { [INFO] [stderr] | |__________________________________________________________________________________________^ help: try: `!(self.targetted_to_right(k) || self.targetted_to_left(k) || self.letter_brick[k].targetted || self.letter_brick[k].filled)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/letter_bricks.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | for k in from..to + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `from..=to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | ((b.col - 13) as f64 * BRICK_WIDTH as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(b.col - 13)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:278:43 [INFO] [stderr] | [INFO] [stderr] 278 | ((b.col - 13) as f64 * BRICK_WIDTH as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BRICK_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:280:21 [INFO] [stderr] | [INFO] [stderr] 280 | ((b.row - 3) as f64 * BRICK_HEIGHT as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(b.row - 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:280:42 [INFO] [stderr] | [INFO] [stderr] 280 | ((b.row - 3) as f64 * BRICK_HEIGHT as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BRICK_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bonus_bomb.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self.bomb_state { [INFO] [stderr] 120 | | State::InFlight => { [INFO] [stderr] 121 | | if (self.y - START_Y) % 120 == 0 && self.sound_on { [INFO] [stderr] 122 | | self.bonus_bomb_sound.play(); [INFO] [stderr] ... | [INFO] [stderr] 129 | | _ => {} [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let State::InFlight = self.bomb_state { [INFO] [stderr] 120 | if (self.y - START_Y) % 120 == 0 && self.sound_on { [INFO] [stderr] 121 | self.bonus_bomb_sound.play(); [INFO] [stderr] 122 | } [INFO] [stderr] 123 | self.y += BOMB_SPEED; [INFO] [stderr] 124 | if self.y > SCREEN_HEIGHT as i32 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bonus_bomb.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match self.bomb_state { [INFO] [stderr] 138 | | State::InFlight => { [INFO] [stderr] 139 | | self.bomb_image[bt][an].render(canvas, self.x, self.y); [INFO] [stderr] 140 | | }, [INFO] [stderr] 141 | | _ => {}, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let State::InFlight = self.bomb_state { [INFO] [stderr] 138 | self.bomb_image[bt][an].render(canvas, self.x, self.y); [INFO] [stderr] 139 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:94:23 [INFO] [stderr] | [INFO] [stderr] 94 | self.x += mother_x as f64 + 0.5 * SPIDER_WIDTH * 0.2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(mother_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | self.y += mother_y as f64 - 0.5 * SPIDER_WIDTH * 0.2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(mother_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/spiders.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (y_target - self.y).signum() == y_vel.signum() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((y_target - self.y).signum() - y_vel.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/spiders.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (y_target - self.y).signum() == y_vel.signum() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:161:42 [INFO] [stderr] | [INFO] [stderr] 161 | let x_vel = if (self.x + x_vel > common::SCREEN_WIDTH as f64 - SPIDER_WIDTH && x_vel > 0.0) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(common::SCREEN_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/spiders.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / fn update(&mut self, base_bricks: &mut BaseBricks, letter_bricks: &mut LetterBricks, [INFO] [stderr] 184 | | bombs: &mut Bombs, restrict: bool, take_brick_sound: &SoundEffect, [INFO] [stderr] 185 | | deposit_brick_sound: &SoundEffect, sound_on: bool) { [INFO] [stderr] 186 | | match self.state { [INFO] [stderr] ... | [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:190:46 [INFO] [stderr] | [INFO] [stderr] 190 | self.x -= (PI + PI * n * r as f64).sin() * SWOOP_SPEED; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:191:46 [INFO] [stderr] | [INFO] [stderr] 191 | self.y += (PI + PI * n * r as f64).cos() * SWOOP_SPEED; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:206:37 [INFO] [stderr] | [INFO] [stderr] 206 | let adj_x = target_brick.x as f64 - 9.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:207:37 [INFO] [stderr] | [INFO] [stderr] 207 | let adj_y = target_brick.y as f64 - 40.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:257:30 [INFO] [stderr] | [INFO] [stderr] 257 | if self.y >= target.y as f64 - SPIDER_HEIGHT + 8.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(target.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:287:37 [INFO] [stderr] | [INFO] [stderr] 287 | let adj_x = (target_brick.x - 9) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.x - 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:288:37 [INFO] [stderr] | [INFO] [stderr] 288 | let adj_y = target_brick.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:555:21 [INFO] [stderr] | [INFO] [stderr] 555 | / &self.spider_image_empty[type_i][3] [INFO] [stderr] 556 | | .render_angle(canvas, x, y, 180.0, 0.2); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 555 | self.spider_image_empty[type_i][3] [INFO] [stderr] 556 | .render_angle(canvas, x, y, 180.0, 0.2); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:560:53 [INFO] [stderr] | [INFO] [stderr] 560 | let angle = 180.0 + 180.0 * n * r as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 564 | | .render_angle(canvas, x, y, angle, scale); [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 563 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 564 | .render_angle(canvas, x, y, angle, scale); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:567:21 [INFO] [stderr] | [INFO] [stderr] 567 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 568 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 567 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 568 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:571:21 [INFO] [stderr] | [INFO] [stderr] 571 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 572 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 571 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 572 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:576:21 [INFO] [stderr] | [INFO] [stderr] 576 | / &self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 577 | | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 576 | self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 577 | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:580:21 [INFO] [stderr] | [INFO] [stderr] 580 | / &self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 581 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 580 | self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 581 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:584:21 [INFO] [stderr] | [INFO] [stderr] 584 | / &self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 585 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 584 | self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 585 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:589:21 [INFO] [stderr] | [INFO] [stderr] 589 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 590 | | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 589 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 590 | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ship.rs:185:68 [INFO] [stderr] | [INFO] [stderr] 185 | self.ship_image[0].render_resize(canvas, self.x + ((Ship::life_x(self.lives + 1) - self.x) as f64 * (1.0 - n)) as i32, SHIP_Y + ((LIVES_Y - SHIP_Y) as f64 * (1.0 - n)) as i32, 0.5 + 0.5 * n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ship::life_x(self.lives + 1) - self.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ship.rs:185:146 [INFO] [stderr] | [INFO] [stderr] 185 | self.ship_image[0].render_resize(canvas, self.x + ((Ship::life_x(self.lives + 1) - self.x) as f64 * (1.0 - n)) as i32, SHIP_Y + ((LIVES_Y - SHIP_Y) as f64 * (1.0 - n)) as i32, 0.5 + 0.5 * n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(LIVES_Y - SHIP_Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/bombs.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / for b in self.bomb.iter_mut().filter(|b| ! b.in_flight).take(1) { [INFO] [stderr] 51 | | b.x = x - BOMB_WIDTH as i32 / 2; [INFO] [stderr] 52 | | b.y = y; [INFO] [stderr] 53 | | b.in_flight = true; [INFO] [stderr] 54 | | return true; [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/bombs.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / for b in self.bomb.iter_mut() [INFO] [stderr] 61 | | .filter(|b| b.in_flight && col_area.collides(b.area())) [INFO] [stderr] 62 | | .take(1) { [INFO] [stderr] 63 | | // once bomb has collided, it is no more, take care of it here [INFO] [stderr] 64 | | b.in_flight = false; [INFO] [stderr] 65 | | return true; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/letter_bricks.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | for i in self.letter_range[letter][row][0]..self.letter_range[letter][row][1] + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.letter_range[letter][row][0]..=self.letter_range[letter][row][1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/letter_bricks.rs:197:32 [INFO] [stderr] | [INFO] [stderr] 197 | if ! (self.letter_brick[k].filled || self.letter_brick[k].targetted) && [INFO] [stderr] | ________________________________^ [INFO] [stderr] 198 | | ! (self.targetted_to_left(k) || self.targetted_to_right(k)) { [INFO] [stderr] | |__________________________________________________________________________________________^ help: try: `!(self.targetted_to_right(k) || self.targetted_to_left(k) || self.letter_brick[k].targetted || self.letter_brick[k].filled)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/letter_bricks.rs:196:34 [INFO] [stderr] | [INFO] [stderr] 196 | for k in from..to + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `from..=to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | ((b.col - 13) as f64 * BRICK_WIDTH as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(b.col - 13)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:278:43 [INFO] [stderr] | [INFO] [stderr] 278 | ((b.col - 13) as f64 * BRICK_WIDTH as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BRICK_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:280:21 [INFO] [stderr] | [INFO] [stderr] 280 | ((b.row - 3) as f64 * BRICK_HEIGHT as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(b.row - 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/letter_bricks.rs:280:42 [INFO] [stderr] | [INFO] [stderr] 280 | ((b.row - 3) as f64 * BRICK_HEIGHT as f64 * self.expansion) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(BRICK_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:30:37 [INFO] [stderr] | [INFO] [stderr] 30 | let rect = Rect::new(x, y, (self.width as f64 * scale) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | (self.height as f64 * scale) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | let rect = Rect::new(x, y, (self.width as f64 * scale) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | (self.height as f64 * scale) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/text.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn render(&self, canvas: &mut Canvas, x: i32, y: i32, [INFO] [stderr] 21 | | r: u8, g: u8, b: u8, a: u8, str: &str) { [INFO] [stderr] 22 | | let texture_creator = canvas.texture_creator(); [INFO] [stderr] 23 | | let surface = self.font.render(str).blended(Color::RGB(r, g, b)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 30 | | canvas.copy(&texture, None, rect).unwrap(); [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | let scale = frames_left as f64 / 100.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frames_left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/animation.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | for i in 1..volume + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bonus_bomb.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self.bomb_state { [INFO] [stderr] 120 | | State::InFlight => { [INFO] [stderr] 121 | | if (self.y - START_Y) % 120 == 0 && self.sound_on { [INFO] [stderr] 122 | | self.bonus_bomb_sound.play(); [INFO] [stderr] ... | [INFO] [stderr] 129 | | _ => {} [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let State::InFlight = self.bomb_state { [INFO] [stderr] 120 | if (self.y - START_Y) % 120 == 0 && self.sound_on { [INFO] [stderr] 121 | self.bonus_bomb_sound.play(); [INFO] [stderr] 122 | } [INFO] [stderr] 123 | self.y += BOMB_SPEED; [INFO] [stderr] 124 | if self.y > SCREEN_HEIGHT as i32 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bonus_bomb.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match self.bomb_state { [INFO] [stderr] 138 | | State::InFlight => { [INFO] [stderr] 139 | | self.bomb_image[bt][an].render(canvas, self.x, self.y); [INFO] [stderr] 140 | | }, [INFO] [stderr] 141 | | _ => {}, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let State::InFlight = self.bomb_state { [INFO] [stderr] 138 | self.bomb_image[bt][an].render(canvas, self.x, self.y); [INFO] [stderr] 139 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:94:23 [INFO] [stderr] | [INFO] [stderr] 94 | self.x += mother_x as f64 + 0.5 * SPIDER_WIDTH * 0.2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(mother_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | self.y += mother_y as f64 - 0.5 * SPIDER_WIDTH * 0.2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(mother_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/spiders.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (y_target - self.y).signum() == y_vel.signum() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((y_target - self.y).signum() - y_vel.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/spiders.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (y_target - self.y).signum() == y_vel.signum() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:161:42 [INFO] [stderr] | [INFO] [stderr] 161 | let x_vel = if (self.x + x_vel > common::SCREEN_WIDTH as f64 - SPIDER_WIDTH && x_vel > 0.0) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(common::SCREEN_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/spiders.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / fn update(&mut self, base_bricks: &mut BaseBricks, letter_bricks: &mut LetterBricks, [INFO] [stderr] 184 | | bombs: &mut Bombs, restrict: bool, take_brick_sound: &SoundEffect, [INFO] [stderr] 185 | | deposit_brick_sound: &SoundEffect, sound_on: bool) { [INFO] [stderr] 186 | | match self.state { [INFO] [stderr] ... | [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:190:46 [INFO] [stderr] | [INFO] [stderr] 190 | self.x -= (PI + PI * n * r as f64).sin() * SWOOP_SPEED; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:191:46 [INFO] [stderr] | [INFO] [stderr] 191 | self.y += (PI + PI * n * r as f64).cos() * SWOOP_SPEED; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:206:37 [INFO] [stderr] | [INFO] [stderr] 206 | let adj_x = target_brick.x as f64 - 9.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:207:37 [INFO] [stderr] | [INFO] [stderr] 207 | let adj_y = target_brick.y as f64 - 40.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:257:30 [INFO] [stderr] | [INFO] [stderr] 257 | if self.y >= target.y as f64 - SPIDER_HEIGHT + 8.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(target.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:287:37 [INFO] [stderr] | [INFO] [stderr] 287 | let adj_x = (target_brick.x - 9) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.x - 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:288:37 [INFO] [stderr] | [INFO] [stderr] 288 | let adj_y = target_brick.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target_brick.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `fin-sdl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:555:21 [INFO] [stderr] | [INFO] [stderr] 555 | / &self.spider_image_empty[type_i][3] [INFO] [stderr] 556 | | .render_angle(canvas, x, y, 180.0, 0.2); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 555 | self.spider_image_empty[type_i][3] [INFO] [stderr] 556 | .render_angle(canvas, x, y, 180.0, 0.2); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/spiders.rs:560:53 [INFO] [stderr] | [INFO] [stderr] 560 | let angle = 180.0 + 180.0 * n * r as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 564 | | .render_angle(canvas, x, y, angle, scale); [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 563 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 564 | .render_angle(canvas, x, y, angle, scale); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:567:21 [INFO] [stderr] | [INFO] [stderr] 567 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 568 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 567 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 568 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:571:21 [INFO] [stderr] | [INFO] [stderr] 571 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 572 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 571 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 572 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:576:21 [INFO] [stderr] | [INFO] [stderr] 576 | / &self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 577 | | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 576 | self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 577 | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:580:21 [INFO] [stderr] | [INFO] [stderr] 580 | / &self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 581 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 580 | self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 581 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:584:21 [INFO] [stderr] | [INFO] [stderr] 584 | / &self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 585 | | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 584 | self.spider_image_laden[type_i][anim_frame] [INFO] [stderr] 585 | .render(canvas, spider.x as i32, spider.y as i32); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/spiders.rs:589:21 [INFO] [stderr] | [INFO] [stderr] 589 | / &self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 590 | | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 589 | self.spider_image_empty[type_i][anim_frame] [INFO] [stderr] 590 | .render_angle(canvas, spider.x as i32, spider.y as i32, angle, 1.0); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/bombs.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / for b in self.bomb.iter_mut().filter(|b| ! b.in_flight).take(1) { [INFO] [stderr] 51 | | b.x = x - BOMB_WIDTH as i32 / 2; [INFO] [stderr] 52 | | b.y = y; [INFO] [stderr] 53 | | b.in_flight = true; [INFO] [stderr] 54 | | return true; [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/bombs.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / for b in self.bomb.iter_mut() [INFO] [stderr] 61 | | .filter(|b| b.in_flight && col_area.collides(b.area())) [INFO] [stderr] 62 | | .take(1) { [INFO] [stderr] 63 | | // once bomb has collided, it is no more, take care of it here [INFO] [stderr] 64 | | b.in_flight = false; [INFO] [stderr] 65 | | return true; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:30:37 [INFO] [stderr] | [INFO] [stderr] 30 | let rect = Rect::new(x, y, (self.width as f64 * scale) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | (self.height as f64 * scale) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | let rect = Rect::new(x, y, (self.width as f64 * scale) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/image.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | (self.height as f64 * scale) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/text.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn render(&self, canvas: &mut Canvas, x: i32, y: i32, [INFO] [stderr] 21 | | r: u8, g: u8, b: u8, a: u8, str: &str) { [INFO] [stderr] 22 | | let texture_creator = canvas.texture_creator(); [INFO] [stderr] 23 | | let surface = self.font.render(str).blended(Color::RGB(r, g, b)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 30 | | canvas.copy(&texture, None, rect).unwrap(); [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | let scale = frames_left as f64 / 100.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frames_left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/animation.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | for i in 1..volume + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fin-sdl`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b874ce19173818dcf8bc0cc753c84d34aa0bc8ccfb1d59663067ae7dbe867fe1"` [INFO] running `"docker" "rm" "-f" "b874ce19173818dcf8bc0cc753c84d34aa0bc8ccfb1d59663067ae7dbe867fe1"` [INFO] [stdout] b874ce19173818dcf8bc0cc753c84d34aa0bc8ccfb1d59663067ae7dbe867fe1