[INFO] updating cached repository planet0104/spaceout [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/planet0104/spaceout [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/planet0104/spaceout" "work/ex/clippy-test-run/sources/stable/gh/planet0104/spaceout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/planet0104/spaceout'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/planet0104/spaceout" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/spaceout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/spaceout'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbf55b2a49cef020eabb5cc6d728b019e8eadb4d [INFO] sha for GitHub repo planet0104/spaceout: fbf55b2a49cef020eabb5cc6d728b019e8eadb4d [INFO] validating manifest of planet0104/spaceout on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of planet0104/spaceout on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing planet0104/spaceout [INFO] finished frobbing planet0104/spaceout [INFO] frobbed toml for planet0104/spaceout written to work/ex/clippy-test-run/sources/stable/gh/planet0104/spaceout/Cargo.toml [INFO] started frobbing planet0104/spaceout [INFO] finished frobbing planet0104/spaceout [INFO] frobbed toml for planet0104/spaceout written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/spaceout/Cargo.toml [INFO] crate planet0104/spaceout has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting planet0104/spaceout against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/planet0104/spaceout:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c6016947f77fbbc7f47753bac271e8ba8442765c2773052df6dabdfb9803f36 [INFO] running `"docker" "start" "-a" "5c6016947f77fbbc7f47753bac271e8ba8442765c2773052df6dabdfb9803f36"` [INFO] [stderr] Checking spaceout v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | id:id, [INFO] [stderr] | ^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | height: height [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | bottom: bottom [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | bitmap:bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | velocity: velocity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | z_order: z_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `z_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | bounds_action: bounds_action, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounds_action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | fps:fps, [INFO] [stderr] | ^^^^^^^ help: replace it with: `fps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | num_stars: num_stars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_stars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | twink_delay: twink_delay, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `twink_delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | stars: stars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | star_colors: star_colors [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `star_colors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | id:id, [INFO] [stderr] | ^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | height: height [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | bottom: bottom [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | bitmap:bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | velocity: velocity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | z_order: z_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `z_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | bounds_action: bounds_action, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounds_action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | fps:fps, [INFO] [stderr] | ^^^^^^^ help: replace it with: `fps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | num_stars: num_stars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_stars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | twink_delay: twink_delay, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `twink_delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | stars: stars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/background.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | star_colors: star_colors [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `star_colors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `log_int`, `log_string` [INFO] [stderr] --> src/engine.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | use ::{play_sound, write_string, log_string, log_int, play_music, pause_music}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `log_int`, `log_string` [INFO] [stderr] --> src/engine.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | use ::{play_sound, write_string, log_string, log_int, play_music, pause_music}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `canvas_style_height` [INFO] [stderr] --> src/game.rs:359:42 [INFO] [stderr] | [INFO] [stderr] 359 | let (canvas_style_width, canvas_style_height) = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_canvas_style_height` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/game.rs:329:52 [INFO] [stderr] | [INFO] [stderr] 329 | fn on_touch_event(&mut self, event:i32, x:i32, y:i32){ [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `canvas_style_height` [INFO] [stderr] --> src/game.rs:359:42 [INFO] [stderr] | [INFO] [stderr] 359 | let (canvas_style_width, canvas_style_height) = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_canvas_style_height` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/game.rs:329:52 [INFO] [stderr] | [INFO] [stderr] 329 | fn on_touch_event(&mut self, event:i32, x:i32, y:i32){ [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contain` [INFO] [stderr] --> src/sprite.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn contain(&self, x:i32, y:i32)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_velocity_point` [INFO] [stderr] --> src/sprite.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | pub fn set_velocity_point(&mut self, velocity:&Point){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `velocity` [INFO] [stderr] --> src/sprite.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | pub fn velocity(&self)->&Point{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_point_inside` [INFO] [stderr] --> src/sprite.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | pub fn is_point_inside(&self, x:i32, y:i32)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `hidden` [INFO] [stderr] --> src/sprite.rs:363:5 [INFO] [stderr] | [INFO] [stderr] 363 | pub fn hidden(&self)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dying` [INFO] [stderr] --> src/sprite.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | pub fn dying(&self)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `fps` [INFO] [stderr] --> src/timer.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | fps:u64, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fps` [INFO] [stderr] --> src/timer.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn fps(&self)->u64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start` [INFO] [stderr] --> src/timer.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn start(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width` [INFO] [stderr] --> src/engine.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | width:i32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/engine.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | height:i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_point_in_sprite` [INFO] [stderr] --> src/engine.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn is_point_in_sprite(&self, x:i32, y:i32)->Option<&Sprite>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `initialize` [INFO] [stderr] --> src/engine.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn initialize(&mut self)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end` [INFO] [stderr] --> src/engine.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn end(&self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `last_touch` [INFO] [stderr] --> src/game.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | last_touch: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `drive_left` [INFO] [stderr] --> src/game.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | drive_left:i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `drive_right` [INFO] [stderr] --> src/game.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | drive_right:i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `start_time` [INFO] [stderr] --> src/game.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | start_time: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contain` [INFO] [stderr] --> src/sprite.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn contain(&self, x:i32, y:i32)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_velocity_point` [INFO] [stderr] --> src/sprite.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | pub fn set_velocity_point(&mut self, velocity:&Point){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `velocity` [INFO] [stderr] --> src/sprite.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | pub fn velocity(&self)->&Point{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_point_inside` [INFO] [stderr] --> src/sprite.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | pub fn is_point_inside(&self, x:i32, y:i32)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `hidden` [INFO] [stderr] --> src/sprite.rs:363:5 [INFO] [stderr] | [INFO] [stderr] 363 | pub fn hidden(&self)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dying` [INFO] [stderr] --> src/sprite.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | pub fn dying(&self)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `fps` [INFO] [stderr] --> src/timer.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | fps:u64, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fps` [INFO] [stderr] --> src/timer.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn fps(&self)->u64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start` [INFO] [stderr] --> src/timer.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn start(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `width` [INFO] [stderr] --> src/engine.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | width:i32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `height` [INFO] [stderr] --> src/engine.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | height:i32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_point_in_sprite` [INFO] [stderr] --> src/engine.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn is_point_in_sprite(&self, x:i32, y:i32)->Option<&Sprite>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `initialize` [INFO] [stderr] --> src/engine.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn initialize(&mut self)->bool{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end` [INFO] [stderr] --> src/engine.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn end(&self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `last_touch` [INFO] [stderr] --> src/game.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | last_touch: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `drive_left` [INFO] [stderr] --> src/game.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | drive_left:i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `drive_right` [INFO] [stderr] --> src/game.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | drive_right:i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `start_time` [INFO] [stderr] --> src/game.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | start_time: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sprite.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | / match self.one_cycle{ [INFO] [stderr] 293 | | true => self.dying = true, [INFO] [stderr] 294 | | _ => self.cur_frame = 0 [INFO] [stderr] 295 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.one_cycle { self.dying = true } else { self.cur_frame = 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sprite.rs:305:51 [INFO] [stderr] | [INFO] [stderr] 305 | pub fn set_velocity_point(&mut self, velocity:&Point){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sprite.rs:314:51 [INFO] [stderr] | [INFO] [stderr] 314 | pub fn set_position_point(&mut self, position:&Point){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if self.sprites.len()>0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.sprites.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sprite.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | / match self.one_cycle{ [INFO] [stderr] 293 | | true => self.dying = true, [INFO] [stderr] 294 | | _ => self.cur_frame = 0 [INFO] [stderr] 295 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.one_cycle { self.dying = true } else { self.cur_frame = 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sprite.rs:305:51 [INFO] [stderr] | [INFO] [stderr] 305 | pub fn set_velocity_point(&mut self, velocity:&Point){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sprite.rs:314:51 [INFO] [stderr] | [INFO] [stderr] 314 | pub fn set_position_point(&mut self, position:&Point){ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/engine.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | s.id() != sprite_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(s.id() - sprite_id).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/engine.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | s.id() != sprite_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/engine.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | if sprite.id() == id{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(sprite.id() - id).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/engine.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | if sprite.id() == id{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | if self.sprites.len()>0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.sprites.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/engine.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | s.id() != sprite_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(s.id() - sprite_id).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/engine.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | s.id() != sprite_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/engine.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | if sprite.id() == id{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(sprite.id() - id).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/engine.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | if sprite.id() == id{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:408:27 [INFO] [stderr] | [INFO] [stderr] 408 | set_text_size("20px Arial".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"20px Arial"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:409:49 [INFO] [stderr] | [INFO] [stderr] 409 | add_resource_url(RES_SPLASH_BITMAP, "Splash1.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Splash1.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:410:49 [INFO] [stderr] | [INFO] [stderr] 410 | add_resource_url(RES_DESERT_BITMAP, "Desert.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Desert.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:411:46 [INFO] [stderr] | [INFO] [stderr] 411 | add_resource_url(RES_CAR_BITMAP, "Car.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Car.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:412:49 [INFO] [stderr] | [INFO] [stderr] 412 | add_resource_url(RES_SM_CAR_BITMAP, "SmCar.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SmCar.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:413:50 [INFO] [stderr] | [INFO] [stderr] 413 | add_resource_url(RES_MISSILE_BITMAP, "Missile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Missile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:414:49 [INFO] [stderr] | [INFO] [stderr] 414 | add_resource_url(RES_BLOBBO_BITMAP, "Blobbo.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Blobbo.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:415:51 [INFO] [stderr] | [INFO] [stderr] 415 | add_resource_url(RES_BMISSILE_BITMAP, "BMissile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"BMissile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:416:48 [INFO] [stderr] | [INFO] [stderr] 416 | add_resource_url(RES_JELLY_BITMAP, "Jelly.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Jelly.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:417:51 [INFO] [stderr] | [INFO] [stderr] 417 | add_resource_url(RES_JMISSILE_BITMAP, "JMissile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"JMissile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:418:48 [INFO] [stderr] | [INFO] [stderr] 418 | add_resource_url(RES_TIMMY_BITMAP, "Timmy.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Timmy.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:419:51 [INFO] [stderr] | [INFO] [stderr] 419 | add_resource_url(RES_TMISSILE_BITMAP, "TMissile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"TMissile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:420:55 [INFO] [stderr] | [INFO] [stderr] 420 | add_resource_url(RES_SM_EXPLOSION_BITMAP, "SmExplosion.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SmExplosion.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:421:55 [INFO] [stderr] | [INFO] [stderr] 421 | add_resource_url(RES_LG_EXPLOSION_BITMAP, "LgExplosion.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"LgExplosion.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:422:52 [INFO] [stderr] | [INFO] [stderr] 422 | add_resource_url(RES_GAME_OVER_BITMAP, "GameOver.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"GameOver.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:424:50 [INFO] [stderr] | [INFO] [stderr] 424 | add_resource_url(RES_BMISSILE_SOUND, "BMissile.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"BMissile.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:425:50 [INFO] [stderr] | [INFO] [stderr] 425 | add_resource_url(RES_GAMEOVER_SOUND, "GameOver.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"GameOver.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:426:50 [INFO] [stderr] | [INFO] [stderr] 426 | add_resource_url(RES_JMISSILE_SOUND, "JMissile.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"JMissile.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:427:49 [INFO] [stderr] | [INFO] [stderr] 427 | add_resource_url(RES_MISSILE_SOUND, "Missile.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Missile.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:428:52 [INFO] [stderr] | [INFO] [stderr] 428 | add_resource_url(RES_LG_EXPLODE_SOUND, "LgExplode.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"LgExplode.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:429:52 [INFO] [stderr] | [INFO] [stderr] 429 | add_resource_url(RES_SM_EXPLODE_SOUND, "SmExplode.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SmExplode.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:408:27 [INFO] [stderr] | [INFO] [stderr] 408 | set_text_size("20px Arial".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"20px Arial"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:409:49 [INFO] [stderr] | [INFO] [stderr] 409 | add_resource_url(RES_SPLASH_BITMAP, "Splash1.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Splash1.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:410:49 [INFO] [stderr] | [INFO] [stderr] 410 | add_resource_url(RES_DESERT_BITMAP, "Desert.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Desert.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:411:46 [INFO] [stderr] | [INFO] [stderr] 411 | add_resource_url(RES_CAR_BITMAP, "Car.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Car.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:412:49 [INFO] [stderr] | [INFO] [stderr] 412 | add_resource_url(RES_SM_CAR_BITMAP, "SmCar.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SmCar.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:413:50 [INFO] [stderr] | [INFO] [stderr] 413 | add_resource_url(RES_MISSILE_BITMAP, "Missile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Missile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:414:49 [INFO] [stderr] | [INFO] [stderr] 414 | add_resource_url(RES_BLOBBO_BITMAP, "Blobbo.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Blobbo.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:415:51 [INFO] [stderr] | [INFO] [stderr] 415 | add_resource_url(RES_BMISSILE_BITMAP, "BMissile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"BMissile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:416:48 [INFO] [stderr] | [INFO] [stderr] 416 | add_resource_url(RES_JELLY_BITMAP, "Jelly.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Jelly.png"` [INFO] [stderr] | [INFO] [stderr] warning: transmute from a pointer type (`*const SpaceOut`) to a reference type (`&'a mut SpaceOut`) [INFO] [stderr] --> src/game.rs:498:9 [INFO] [stderr] | [INFO] [stderr] 498 | transmute(GAME) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *GAME` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:417:51 [INFO] [stderr] | [INFO] [stderr] 417 | add_resource_url(RES_JMISSILE_BITMAP, "JMissile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"JMissile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:418:48 [INFO] [stderr] | [INFO] [stderr] 418 | add_resource_url(RES_TIMMY_BITMAP, "Timmy.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Timmy.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:419:51 [INFO] [stderr] | [INFO] [stderr] 419 | add_resource_url(RES_TMISSILE_BITMAP, "TMissile.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"TMissile.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:420:55 [INFO] [stderr] | [INFO] [stderr] 420 | add_resource_url(RES_SM_EXPLOSION_BITMAP, "SmExplosion.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SmExplosion.png"` [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:531:21 [INFO] [stderr] | [INFO] [stderr] 531 | ((random()*(b as f64 - l as f64 + 1.0)).floor()+l as f64) as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:531:32 [INFO] [stderr] | [INFO] [stderr] 531 | ((random()*(b as f64 - l as f64 + 1.0)).floor()+l as f64) as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(l)` [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:421:55 [INFO] [stderr] | [INFO] [stderr] 421 | add_resource_url(RES_LG_EXPLOSION_BITMAP, "LgExplosion.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"LgExplosion.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:422:52 [INFO] [stderr] | [INFO] [stderr] 422 | add_resource_url(RES_GAME_OVER_BITMAP, "GameOver.png".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"GameOver.png"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:424:50 [INFO] [stderr] | [INFO] [stderr] 424 | add_resource_url(RES_BMISSILE_SOUND, "BMissile.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"BMissile.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:425:50 [INFO] [stderr] | [INFO] [stderr] 425 | add_resource_url(RES_GAMEOVER_SOUND, "GameOver.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"GameOver.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:426:50 [INFO] [stderr] | [INFO] [stderr] 426 | add_resource_url(RES_JMISSILE_SOUND, "JMissile.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"JMissile.ogg"` [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:531:57 [INFO] [stderr] | [INFO] [stderr] 531 | ((random()*(b as f64 - l as f64 + 1.0)).floor()+l as f64) as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(l)` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:427:49 [INFO] [stderr] | [INFO] [stderr] 427 | add_resource_url(RES_MISSILE_SOUND, "Missile.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Missile.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:428:52 [INFO] [stderr] | [INFO] [stderr] 428 | add_resource_url(RES_LG_EXPLODE_SOUND, "LgExplode.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"LgExplode.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/game.rs:429:52 [INFO] [stderr] | [INFO] [stderr] 429 | add_resource_url(RES_SM_EXPLODE_SOUND, "SmExplode.ogg".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SmExplode.ogg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/game.rs:635:35 [INFO] [stderr] | [INFO] [stderr] 635 | let _ = CString::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const SpaceOut`) to a reference type (`&'a mut SpaceOut`) [INFO] [stderr] --> src/game.rs:498:9 [INFO] [stderr] | [INFO] [stderr] 498 | transmute(GAME) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut *GAME` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:531:21 [INFO] [stderr] | [INFO] [stderr] 531 | ((random()*(b as f64 - l as f64 + 1.0)).floor()+l as f64) as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:531:32 [INFO] [stderr] | [INFO] [stderr] 531 | ((random()*(b as f64 - l as f64 + 1.0)).floor()+l as f64) as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:531:57 [INFO] [stderr] | [INFO] [stderr] 531 | ((random()*(b as f64 - l as f64 + 1.0)).floor()+l as f64) as i32 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/game.rs:635:35 [INFO] [stderr] | [INFO] [stderr] 635 | let _ = CString::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `spaceout`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `spaceout`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5c6016947f77fbbc7f47753bac271e8ba8442765c2773052df6dabdfb9803f36"` [INFO] running `"docker" "rm" "-f" "5c6016947f77fbbc7f47753bac271e8ba8442765c2773052df6dabdfb9803f36"` [INFO] [stdout] 5c6016947f77fbbc7f47753bac271e8ba8442765c2773052df6dabdfb9803f36