[INFO] updating cached repository planet0104/rust-stroke-editor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/planet0104/rust-stroke-editor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/planet0104/rust-stroke-editor" "work/ex/clippy-test-run/sources/stable/gh/planet0104/rust-stroke-editor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/planet0104/rust-stroke-editor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/planet0104/rust-stroke-editor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/rust-stroke-editor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/rust-stroke-editor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2ddb943e7d779caba75e6e3a491e2d77265e7eb [INFO] sha for GitHub repo planet0104/rust-stroke-editor: a2ddb943e7d779caba75e6e3a491e2d77265e7eb [INFO] validating manifest of planet0104/rust-stroke-editor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of planet0104/rust-stroke-editor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing planet0104/rust-stroke-editor [INFO] finished frobbing planet0104/rust-stroke-editor [INFO] frobbed toml for planet0104/rust-stroke-editor written to work/ex/clippy-test-run/sources/stable/gh/planet0104/rust-stroke-editor/Cargo.toml [INFO] started frobbing planet0104/rust-stroke-editor [INFO] finished frobbing planet0104/rust-stroke-editor [INFO] frobbed toml for planet0104/rust-stroke-editor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/rust-stroke-editor/Cargo.toml [INFO] crate planet0104/rust-stroke-editor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting planet0104/rust-stroke-editor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/planet0104/rust-stroke-editor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] becdc08aeaaa3a0c231f2c29d16e2af2d233d0823f9583182ebbcb434b3fe013 [INFO] running `"docker" "start" "-a" "becdc08aeaaa3a0c231f2c29d16e2af2d233d0823f9583182ebbcb434b3fe013"` [INFO] [stderr] Compiling stdweb-internal-runtime v0.1.2 [INFO] [stderr] Compiling base-x v0.2.3 [INFO] [stderr] Checking discard v1.0.4 [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Compiling stdweb-internal-macros v0.2.2 [INFO] [stderr] Compiling stdweb v0.4.10 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling stdweb-derive v0.5.1 [INFO] [stderr] Checking rust-stroke-editor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | static ref STROKES: Mutex>>> = Mutex::new(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | static ref STROKES: Mutex>>> = Mutex::new(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | let (width, height) = (CANVAS.width() as f64, CANVAS.height() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(CANVAS.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:51 [INFO] [stderr] | [INFO] [stderr] 74 | let (width, height) = (CANVAS.width() as f64, CANVAS.height() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(CANVAS.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | CONTEXT.arc(pt.0 as f64, pt.1 as f64, 20.0, 0.0, 360.0, false); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(pt.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:30 [INFO] [stderr] | [INFO] [stderr] 113 | CONTEXT.arc(pt.0 as f64, pt.1 as f64, 20.0, 0.0, 360.0, false); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(pt.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:25 [INFO] [stderr] | [INFO] [stderr] 142 | CONTEXT.move_to(stroke[0].0 as f64, stroke[0].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[0].0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:45 [INFO] [stderr] | [INFO] [stderr] 142 | CONTEXT.move_to(stroke[0].0 as f64, stroke[0].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[0].1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `stroke`. [INFO] [stderr] --> src/main.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | for i in 1..stroke.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 143 | for in stroke.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | CONTEXT.line_to(stroke[i].0 as f64, stroke[i].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[i].0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:144:49 [INFO] [stderr] | [INFO] [stderr] 144 | CONTEXT.line_to(stroke[i].0 as f64, stroke[i].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[i].1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | if points.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `points.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | let mut vec:Vec<(char, Vec>)> = vec![]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:239:26 [INFO] [stderr] | [INFO] [stderr] 239 | let strokes: Vec<(char, Vec>)> = deserialize(&data).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:297:16 [INFO] [stderr] | [INFO] [stderr] 297 | if ch.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:398:12 [INFO] [stderr] | [INFO] [stderr] 398 | if ch.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | static ref STROKES: Mutex>>> = Mutex::new(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | static ref STROKES: Mutex>>> = Mutex::new(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | let (width, height) = (CANVAS.width() as f64, CANVAS.height() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(CANVAS.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:51 [INFO] [stderr] | [INFO] [stderr] 74 | let (width, height) = (CANVAS.width() as f64, CANVAS.height() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(CANVAS.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | CONTEXT.arc(pt.0 as f64, pt.1 as f64, 20.0, 0.0, 360.0, false); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(pt.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:30 [INFO] [stderr] | [INFO] [stderr] 113 | CONTEXT.arc(pt.0 as f64, pt.1 as f64, 20.0, 0.0, 360.0, false); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(pt.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:25 [INFO] [stderr] | [INFO] [stderr] 142 | CONTEXT.move_to(stroke[0].0 as f64, stroke[0].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[0].0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:45 [INFO] [stderr] | [INFO] [stderr] 142 | CONTEXT.move_to(stroke[0].0 as f64, stroke[0].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[0].1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `stroke`. [INFO] [stderr] --> src/main.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | for i in 1..stroke.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 143 | for in stroke.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | CONTEXT.line_to(stroke[i].0 as f64, stroke[i].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[i].0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:144:49 [INFO] [stderr] | [INFO] [stderr] 144 | CONTEXT.line_to(stroke[i].0 as f64, stroke[i].1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(stroke[i].1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | if points.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `points.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | let mut vec:Vec<(char, Vec>)> = vec![]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:239:26 [INFO] [stderr] | [INFO] [stderr] 239 | let strokes: Vec<(char, Vec>)> = deserialize(&data).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:297:16 [INFO] [stderr] | [INFO] [stderr] 297 | if ch.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:398:12 [INFO] [stderr] | [INFO] [stderr] 398 | if ch.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.15s [INFO] running `"docker" "inspect" "becdc08aeaaa3a0c231f2c29d16e2af2d233d0823f9583182ebbcb434b3fe013"` [INFO] running `"docker" "rm" "-f" "becdc08aeaaa3a0c231f2c29d16e2af2d233d0823f9583182ebbcb434b3fe013"` [INFO] [stdout] becdc08aeaaa3a0c231f2c29d16e2af2d233d0823f9583182ebbcb434b3fe013