[INFO] updating cached repository pkinsky/rusty-raft [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pkinsky/rusty-raft [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pkinsky/rusty-raft" "work/ex/clippy-test-run/sources/stable/gh/pkinsky/rusty-raft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pkinsky/rusty-raft'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pkinsky/rusty-raft" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pkinsky/rusty-raft"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pkinsky/rusty-raft'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9b341c1ceef1f8ecdd028f6c34fb294ad76becf [INFO] sha for GitHub repo pkinsky/rusty-raft: e9b341c1ceef1f8ecdd028f6c34fb294ad76becf [INFO] validating manifest of pkinsky/rusty-raft on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pkinsky/rusty-raft on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pkinsky/rusty-raft [INFO] finished frobbing pkinsky/rusty-raft [INFO] frobbed toml for pkinsky/rusty-raft written to work/ex/clippy-test-run/sources/stable/gh/pkinsky/rusty-raft/Cargo.toml [INFO] started frobbing pkinsky/rusty-raft [INFO] finished frobbing pkinsky/rusty-raft [INFO] frobbed toml for pkinsky/rusty-raft written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pkinsky/rusty-raft/Cargo.toml [INFO] crate pkinsky/rusty-raft has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pkinsky/rusty-raft against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pkinsky/rusty-raft:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e003812fd30534e165c2a12368d4fb4a8099c91d4d2c9dcc47c6d5e40daab7b [INFO] running `"docker" "start" "-a" "0e003812fd30534e165c2a12368d4fb4a8099c91d4d2c9dcc47c6d5e40daab7b"` [INFO] [stderr] Compiling syn v0.15.15 [INFO] [stderr] Checking tokio-signal v0.2.6 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling actix_derive v0.3.1 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking actix v0.7.5 [INFO] [stderr] Checking raft v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | vote_granted: vote_granted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vote_granted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | vote_granted: vote_granted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vote_granted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if (req.term > self.persisted.current_term) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/main.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | let addr = Node::default().start(); [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | fn handle(&mut self, req: RequestVote, state: &mut Context) -> Self::Result { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/main.rs:230:27 [INFO] [stderr] | [INFO] [stderr] 230 | fn started(&mut self, ctx: &mut Self::Context) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `term` [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | term : Term, // currentTerm, for candidate to update itself [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vote_granted` [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | vote_granted : bool, // true means candidate received vote [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `value` [INFO] [stderr] --> src/main.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | value: String, // todo replace [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `volatile` [INFO] [stderr] --> src/main.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | volatile: VolatileState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `next_index` [INFO] [stderr] --> src/main.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | next_index: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `match_index` [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | match_index: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `commit_index` [INFO] [stderr] --> src/main.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | commit_index: LogIdx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `last_applied` [INFO] [stderr] --> src/main.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | last_applied: LogIdx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Candidate` [INFO] [stderr] --> src/main.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | Candidate, // todo: candidate-specific state (vote-tracking) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Leader` [INFO] [stderr] --> src/main.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | Leader(VolatileLeaderState), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `candidateLogAtLeastAsUpToDate` should have a snake case name such as `candidate_log_at_least_as_up_to_date` [INFO] [stderr] --> src/main.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let candidateLogAtLeastAsUpToDate = self.persisted.log.last().map_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if (req.term > self.persisted.current_term) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/main.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | let addr = Node::default().start(); [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | fn handle(&mut self, req: RequestVote, state: &mut Context) -> Self::Result { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/main.rs:230:27 [INFO] [stderr] | [INFO] [stderr] 230 | fn started(&mut self, ctx: &mut Self::Context) { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `term` [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | term : Term, // currentTerm, for candidate to update itself [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `vote_granted` [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | vote_granted : bool, // true means candidate received vote [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `value` [INFO] [stderr] --> src/main.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | value: String, // todo replace [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `volatile` [INFO] [stderr] --> src/main.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | volatile: VolatileState, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `next_index` [INFO] [stderr] --> src/main.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | next_index: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `match_index` [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | match_index: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `commit_index` [INFO] [stderr] --> src/main.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | commit_index: LogIdx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `last_applied` [INFO] [stderr] --> src/main.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | last_applied: LogIdx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Candidate` [INFO] [stderr] --> src/main.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | Candidate, // todo: candidate-specific state (vote-tracking) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Leader` [INFO] [stderr] --> src/main.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | Leader(VolatileLeaderState), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `candidateLogAtLeastAsUpToDate` should have a snake case name such as `candidate_log_at_least_as_up_to_date` [INFO] [stderr] --> src/main.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let candidateLogAtLeastAsUpToDate = self.persisted.log.last().map_or( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.01s [INFO] running `"docker" "inspect" "0e003812fd30534e165c2a12368d4fb4a8099c91d4d2c9dcc47c6d5e40daab7b"` [INFO] running `"docker" "rm" "-f" "0e003812fd30534e165c2a12368d4fb4a8099c91d4d2c9dcc47c6d5e40daab7b"` [INFO] [stdout] 0e003812fd30534e165c2a12368d4fb4a8099c91d4d2c9dcc47c6d5e40daab7b