[INFO] updating cached repository pjungwir/rust-thread-read-to-string [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pjungwir/rust-thread-read-to-string [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pjungwir/rust-thread-read-to-string" "work/ex/clippy-test-run/sources/stable/gh/pjungwir/rust-thread-read-to-string"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pjungwir/rust-thread-read-to-string'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pjungwir/rust-thread-read-to-string" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjungwir/rust-thread-read-to-string"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjungwir/rust-thread-read-to-string'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 45c3aacc5ff0bd0df32aff67a1d240948f047874 [INFO] sha for GitHub repo pjungwir/rust-thread-read-to-string: 45c3aacc5ff0bd0df32aff67a1d240948f047874 [INFO] validating manifest of pjungwir/rust-thread-read-to-string on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pjungwir/rust-thread-read-to-string on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pjungwir/rust-thread-read-to-string [INFO] finished frobbing pjungwir/rust-thread-read-to-string [INFO] frobbed toml for pjungwir/rust-thread-read-to-string written to work/ex/clippy-test-run/sources/stable/gh/pjungwir/rust-thread-read-to-string/Cargo.toml [INFO] started frobbing pjungwir/rust-thread-read-to-string [INFO] finished frobbing pjungwir/rust-thread-read-to-string [INFO] frobbed toml for pjungwir/rust-thread-read-to-string written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pjungwir/rust-thread-read-to-string/Cargo.toml [INFO] crate pjungwir/rust-thread-read-to-string has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pjungwir/rust-thread-read-to-string against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/pjungwir/rust-thread-read-to-string:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9c97f58c444c06cfe050bed908c00d477b6d94bdac97d5347ee83dcd1725441 [INFO] running `"docker" "start" "-a" "e9c97f58c444c06cfe050bed908c00d477b6d94bdac97d5347ee83dcd1725441"` [INFO] [stderr] Checking unicode-bidi v0.2.5 [INFO] [stderr] Checking mime v0.2.2 [INFO] [stderr] Checking num_cpus v1.3.0 [INFO] [stderr] Compiling hyper v0.10.5 [INFO] [stderr] Checking idna v0.1.0 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Checking thread-read-to-string v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Request` [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | use hyper::client::{Request, Response}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Request` [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | use hyper::client::{Request, Response}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:27:7 [INFO] [stderr] | [INFO] [stderr] 27 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:141:7 [INFO] [stderr] | [INFO] [stderr] 141 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status_code` [INFO] [stderr] --> src/main.rs:185:8 [INFO] [stderr] | [INFO] [stderr] 185 | let (status_code, buf) = get_url_with_timeout_3("http://example.com/").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_status_code` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status_code` [INFO] [stderr] --> src/main.rs:188:8 [INFO] [stderr] | [INFO] [stderr] 188 | let (status_code, buf) = get_url_with_timeout_4("http://example.com/").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_status_code` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status_code` [INFO] [stderr] --> src/main.rs:193:7 [INFO] [stderr] | [INFO] [stderr] 193 | let status_code = get_url_with_timeout_5("http://example.com/", &shbuf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_status_code` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | let mut req = c.get(url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:27:7 [INFO] [stderr] | [INFO] [stderr] 27 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let mut req = c.get(&url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | let mut ret = match req.send() { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t` [INFO] [stderr] --> src/main.rs:141:7 [INFO] [stderr] | [INFO] [stderr] 141 | let t = thread::spawn(move || { [INFO] [stderr] | ^ help: consider using `_t` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status_code` [INFO] [stderr] --> src/main.rs:185:8 [INFO] [stderr] | [INFO] [stderr] 185 | let (status_code, buf) = get_url_with_timeout_3("http://example.com/").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_status_code` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status_code` [INFO] [stderr] --> src/main.rs:188:8 [INFO] [stderr] | [INFO] [stderr] 188 | let (status_code, buf) = get_url_with_timeout_4("http://example.com/").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_status_code` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status_code` [INFO] [stderr] --> src/main.rs:193:7 [INFO] [stderr] | [INFO] [stderr] 193 | let status_code = get_url_with_timeout_5("http://example.com/", &shbuf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_status_code` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let mut req = c.get(&url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let mut ret = match req.send() { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | let mut req = c.get(&url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | let mut ret = match req.send() { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:137:38 [INFO] [stderr] | [INFO] [stderr] 137 | fn get_url_with_timeout_5(url: &str, mut shbuf: &Arc>) -> Result { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | let mut req = c.get(url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | req.send().map_err(|e| MyAppError::TcpError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyAppError::TcpError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match tx.send(send_request(&url)) { [INFO] [stderr] 29 | | Ok(()) => {}, // everything good [INFO] [stderr] 30 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(send_request(&url)) {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | resp.read_to_string(&mut buf).map_err(|e| MyAppError::ReadError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyAppError::ReadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | let mut req = c.get(&url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | let mut ret = match req.send() { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | resp.read_to_string(&mut buf).map_err(|e| MyAppError::ReadError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyAppError::ReadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let mut req = c.get(&url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let mut ret = match req.send() { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let mut c = Client::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | let mut req = c.get(&url); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | let mut ret = match req.send() { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:137:38 [INFO] [stderr] | [INFO] [stderr] 137 | fn get_url_with_timeout_5(url: &str, mut shbuf: &Arc>) -> Result { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / match tx.send(ret) { [INFO] [stderr] 88 | | Ok(()) => {}, // everything good [INFO] [stderr] 89 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(ret) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / match tx.send(ret) { [INFO] [stderr] 123 | | Ok(()) => {}, // everything good [INFO] [stderr] 124 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(ret) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | req.send().map_err(|e| MyAppError::TcpError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyAppError::TcpError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match tx.send(send_request(&url)) { [INFO] [stderr] 29 | | Ok(()) => {}, // everything good [INFO] [stderr] 30 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(send_request(&url)) {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | resp.read_to_string(&mut buf).map_err(|e| MyAppError::ReadError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyAppError::ReadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | resp.read_to_string(&mut buf).map_err(|e| MyAppError::ReadError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyAppError::ReadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / match tx.send(ret) { [INFO] [stderr] 88 | | Ok(()) => {}, // everything good [INFO] [stderr] 89 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(ret) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / match tx.send(ret) { [INFO] [stderr] 156 | | Ok(()) => {}, // everything good [INFO] [stderr] 157 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(ret) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / match tx.send(ret) { [INFO] [stderr] 123 | | Ok(()) => {}, // everything good [INFO] [stderr] 124 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(ret) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / match tx.send(ret) { [INFO] [stderr] 156 | | Ok(()) => {}, // everything good [INFO] [stderr] 157 | | Err(_) => {}, // we have been released, no biggie [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(()) = tx.send(ret) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.85s [INFO] running `"docker" "inspect" "e9c97f58c444c06cfe050bed908c00d477b6d94bdac97d5347ee83dcd1725441"` [INFO] running `"docker" "rm" "-f" "e9c97f58c444c06cfe050bed908c00d477b6d94bdac97d5347ee83dcd1725441"` [INFO] [stdout] e9c97f58c444c06cfe050bed908c00d477b6d94bdac97d5347ee83dcd1725441